sgraenitz abandoned this revision.
sgraenitz added a comment.

In D65939#1620780 <https://reviews.llvm.org/D65939#1620780>, @labath wrote:

> So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work 
> even in standalone builds...


LLVM_ENABLE_WERROR affects the entire build tree. If another subproject causes 
a warning the build fails. In a way, you are right that this is sufficient, 
because the no-warnings policy seems to work well upstream.
The issue I was trying to solve is, that we can't use the setting with some 
external subprojects, because they are not strictly warning free. But then it 
may be better to have downstream. I agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65939/new/

https://reviews.llvm.org/D65939



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to