https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/133299
This reverts commit d7cea2b18717f0cc31b7da4a03f772d89ee201db. It causes crashes
in API tests.
>From 4139d0625afed999878ff26bd86e61c873beb29f Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Thu, 27 Mar
rupprecht wrote:
Still seeing a crash even with the latest fix applied
```
assertion failed at clang/include/clang/AST/Type.h:945 in const
ExtQualsTypeCommonBase *clang::QualType::getCommonPtr() const: !isNull() &&
"Cannot retrieve a NULL type pointer"
*** Check failure stack trace: ***
@
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/133542
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
Saw the same thing running tests internally; reverted.
https://github.com/llvm/llvm-project/pull/132370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/133299
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
Nevermind, 74e1554d7b4013a975cf5fb8df64a6419bb14a45 already fixed this, I was a
bit behind trunk in my last test
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
rupprecht wrote:
I'm unable to observe this issue with a fully optimized build, hinting that
this is some UB conveniently being optimized out in release builds, but
sanitizers aren't picking anything up.
https://github.com/llvm/llvm-project/pull/112109
_
rupprecht wrote:
The `command-expr-diagnostics.test` test added here (migrated from API->shell,
really) is flaky for me. It expects this:
```
(lldb) p a+b
˄ ˄
│ ╰─ error: use of undeclared identifier 'b'
╰─ error: use of undeclared identifier 'a'
```
But half the tim
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/113251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/113251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,3 +6,6 @@ include Makefile.rules
# Copy file into the build folder to enable the test to modify it.
main-copy.cpp: main.cpp
cp -f $< $@
+ifneq "$(OS)" "Windows_NT" # chmod is not available on Windows
rupprecht wrote:
Excellent. Removed the condit
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/113251
>From 0d27f7643007805bc2b1f2965edbd71d6563dae3 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 21 Oct 2024 19:29:50 -0700
Subject: [PATCH 1/2] [lldb][test] Fix TestUseSourceCache for readonly source
rupprecht wrote:
A more platform-agnostic way to do this would be to do it from Python:
```py
src = self.getBuildArtifact("main-copy.cpp")
statinfo = os.stat(src)
os.chmod(src, statinfo.st_mode | stat.S_IWUSR)
```
However, I don't understand the test case well enough to
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/113251
TestUseSourceCache attempts to write to a build artifact copied from the source
tree, and asserts the write succeeded. If the source tree is read only, the
copy will also be read only, causing it to fail. Whe
https://github.com/rupprecht approved this pull request.
LGTM, but heads up for @mysterymath if this causes issues w/ Fuchsia's build
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
https://github.com/rupprecht commented:
LGTM
https://github.com/llvm/llvm-project/pull/89692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/89609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/89260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/89260
The `LLDB_TEST_USE_VENDOR_PACKAGES` has defaulted to `Off` for a while. Either
installing `pexpect` or skipping those tests with
`-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` seems to be enough that we can
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/87263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/87263
We check if the next character after `N.` is `*` before we check its length.
Using `split` on the string is cleaner and less error prone than using indices
with `find` and `substr`.
Note: this does not make `
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/86962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/86962
The commit 8bed754c2f965c8cbbb050be6f650b78f7fd78a6 was intended to support the
use case where users want to run all the LLDB tests in an environment where
pexpect is not installed. Those users can build with
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/84860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/84860
>From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 11 Mar 2024 11:23:59 -0700
Subject: [PATCH 1/5] [lldb][test] Add `pexpect` category for tests that
`imp
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/84860
>From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 11 Mar 2024 11:23:59 -0700
Subject: [PATCH 1/4] [lldb][test] Add `pexpect` category for tests that
`imp
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/84860
>From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 11 Mar 2024 11:23:59 -0700
Subject: [PATCH 1/3] [lldb][test] Add `pexpect` category for tests that
`imp
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/84860
>From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 11 Mar 2024 11:23:59 -0700
Subject: [PATCH 1/2] [lldb][test] Add `pexpect` category for tests that
`imp
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/84860
Instead of directly annotating pexpect-based tests with `@skipIfWindows`, we
can tag them with a new `pexpect` category. We still automatically skip windows
behavior by adding `pexpect` to the skip category li
rupprecht wrote:
@mysterymath do you run the API test suites with that custom python, i.e.
`ninja check-lldb-api`? If so, would you be able to add bundle `pexpect` for
your tests even if it's not in what you ship?
The goal is to be able to delete
https://github.com/llvm/llvm-project/tree/main
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/84270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
btw, it would be nice if LLDB buildbots were clean before landing this.
https://green.lab.llvm.org/green/view/LLDB/ is currently giving me
ERR_CONNECTION_REFUSED. The others are failing but I'm hoping
ec72909b62ce568ed27c6ad0581e50c0fdd70df4 restores that.
https://github.com/
Author: Jordan Rupprecht
Date: 2024-03-06T18:41:18-08:00
New Revision: ec72909b62ce568ed27c6ad0581e50c0fdd70df4
URL:
https://github.com/llvm/llvm-project/commit/ec72909b62ce568ed27c6ad0581e50c0fdd70df4
DIFF:
https://github.com/llvm/llvm-project/commit/ec72909b62ce568ed27c6ad0581e50c0fdd70df4.di
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/84270
This switches the default of `LLDB_TEST_USE_VENDOR_PACKAGES` from `ON` to `OFF`
in preparation for eventually deleting it. All known LLDB buildbots have this
package installed, so flipping the default will unc
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/83366
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
> @rupprecht @oontvoo How do you feel about the current approach? The other
> alternative is to make this function a NOOP on all platforms but Darwin
> (where I want to actively use it). It's not currently load bearing (except
> the log, which is opt-in).
This approach LGTM.
Author: Jordan Rupprecht
Date: 2024-03-04T11:21:47-08:00
New Revision: 503075e4d4a9c1b3754b21ee9ec41f176e54fd83
URL:
https://github.com/llvm/llvm-project/commit/503075e4d4a9c1b3754b21ee9ec41f176e54fd83
DIFF:
https://github.com/llvm/llvm-project/commit/503075e4d4a9c1b3754b21ee9ec41f176e54fd83.di
rupprecht wrote:
> FYI @labath as the x86 bot owner.
I checked w/ them that
[lldb-x86_64-debian](https://lab.llvm.org/buildbot/#/builders/68) has
python3-pexpect (specifically 4.8) installed.
> > It should perhaps unset the variable first, I'll see if I can implement
> > that.
>
> [ec95379]
@@ -89,8 +89,17 @@ using namespace lldb;
using namespace lldb_private;
#if !defined(__APPLE__)
+#if !defined(_WIN32)
+#include
+void Host::SystemLog(llvm::StringRef message) {
+ openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
+ syslog(LOG_INFO, "%s", message.dat
@@ -89,8 +89,17 @@ using namespace lldb;
using namespace lldb_private;
#if !defined(__APPLE__)
+#if !defined(_WIN32)
+#include
+void Host::SystemLog(llvm::StringRef message) {
+ openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
+ syslog(LOG_INFO, "%s", message.dat
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/83192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/83191
>From d21ac756226a364603acd0180f9a06c23600acb1 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 27 Feb 2024 13:25:12 -0800
Subject: [PATCH 1/2] [lldb][test] Exclude third_party packages by default
Th
rupprecht wrote:
> Though maybe you intend this to break builds, that way obscure builders that
> we don't know about will still hear about this?
>
Yes, but I agree with your suggestion to land this with a default of `ON`,
which makes this change NFC. I can then switch it to `OFF` once known
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/83191
The goal here is to remove the third_party/Python/module tree, which LLDB tests
only use to `import pexpect`. This package is available on `pip`, and I believe
should not be hard to obtain.
However, in case i
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/83162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/83162
The `EventThreadFunction` can end up calling `HandleCommand` concurrently with
the main request processing thread. The underlying API does not appear to be
thread safe, so add a narrowly scoped mutex lock to p
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
> 🥳
>
> Please wait a little bit for others to look. Thanks for taking care of this!
Yep, no problem! I'll give it a few days, and assume no comments == submit.
Next up: I'd like to remove `pexpect` (available on pip) and completely remove
the lldb/third_party/ tree.
https:/
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/82672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/82672
None
>From 9b971b403448a6e7ff374558c5d963b7c5636ea1 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Thu, 22 Feb 2024 10:24:22 -0800
Subject: [PATCH] [lldb][docs] Remove/update docs pointing to unittest2
rupprecht wrote:
> This change has caused a failing test on Linux:
> https://lab.llvm.org/buildbot/#/builders/68/builds/69157
>
Fixed w/ 675791335285fa86434dc46e5c92f543e0e79d19
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailin
@@ -9,43 +9,27 @@
#include "gtest/gtest.h"
#include "Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h"
-#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h"
-#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h"
#include "Plugins/Script
Author: Jordan Rupprecht
Date: 2024-02-21T22:59:03-08:00
New Revision: 675791335285fa86434dc46e5c92f543e0e79d19
URL:
https://github.com/llvm/llvm-project/commit/675791335285fa86434dc46e5c92f543e0e79d19
DIFF:
https://github.com/llvm/llvm-project/commit/675791335285fa86434dc46e5c92f543e0e79d19.di
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/82526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self):
"doing_the_work_2",
"queue 2's pending item #0 should be doing_the_work_2",
)
-self.assertTrue(
-queue_performer_2.GetPendingItemAtIndex().IsValid() == False
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/82526
Any time we see the pattern `assertEqual(value, bool)`, we can replace that
with `assert(value)`. Likewise for `assertNotEqual`.
Technically this relaxes the test a bit, as we may want to make sure `value` is
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/82503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self):
"doing_the_work_2",
"queue 2's pending item #0 should be doing_the_work_2",
)
-self.assertTrue(
-queue_performer_2.GetPendingItemAtIndex().IsValid() == False
rupprecht wrote:
Thanks! Nice cleanup.
https://github.com/llvm/llvm-project/pull/82073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
Skipped the test in 65c25a4c40865a0e460c0fecb1b33f7cf7455573
Tear down behavior was patched for LLDB back in
b1490b6172c48cf802b24bd738c90eeb019436fe. I'm guessing that explains why we
weren't noticing those errors -- they get logged as cleanup_errors, not as
errors. (Maybe I
Author: Jordan Rupprecht
Date: 2024-02-15T11:51:44-08:00
New Revision: 65c25a4c40865a0e460c0fecb1b33f7cf7455573
URL:
https://github.com/llvm/llvm-project/commit/65c25a4c40865a0e460c0fecb1b33f7cf7455573
DIFF:
https://github.com/llvm/llvm-project/commit/65c25a4c40865a0e460c0fecb1b33f7cf7455573.di
rupprecht wrote:
I believe the old unittest framework may have been ignoring failures that
happen during teardown.
I have started looking at https://github.com/llvm/llvm-project/issues/81686 a
bit, but +1 to suppressing this temporarily -- I should be able to land that in
a bit.
https://gith
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/81703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
> Yeah given GreenDragon has been red for 20h, I'd like to get this merged
> sooner rather than later. @DavidSpickett what's the benefit of waiting for
> the arm bots to come back up?
Broadly speaking, if a buildbot is down, it interferes with bisection if
something unexpecte
rupprecht wrote:
The arm bots still haven't picked up the change :(
Green Dragon is back online, and TestRequireHWBreakpoints.py is failing:
https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/16077/testReport/lldb-api/functionalities_breakpoint_hardware_breakpoints_require_hw_breakpoi
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/81703
Switching to modern `unittest` in 5b386158aacac4b41126983a5379d36ed413d0ea
needs xfail annotations to be known prior to test running. In contrast,
skipping can happen at any time, even during test execution.
rupprecht wrote:
I got one buildbot email:
https://lab.llvm.org/buildbot/#/builders/68/builds/68776
Looks like lldb-dap crashes occasionally, and so the `disconnect` event doesn't
get the response it was expecting. (The buildbot does not enable the dap
request/response logging, but I have it
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/79945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/79945
>From ff9ef2f1dba9b2227916c16ebf7c11810e67a1dd Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 29 Jan 2024 19:07:36 -0800
Subject: [PATCH 1/6] Blanket unittest2 -> unittest replacement (excluding
do
rupprecht wrote:
> I ran this on Arm and AArch64 Linux. One test
> `lldb/test/API/functionalities/breakpoint/hardware_breakpoints/require_hw_breakpoints/TestRequireHWBreakpoints.py`
> was xfailed on AArch64 is now not. Before:
>
> ```
> PASS: LLDB (/home/david.spickett/build-llvm-aarch64/bin/c
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/79945
This removes the dependency LLDB API tests have on
lldb/third_party/Python/module/unittest2, and instead uses the standard one
provided by Python.
This does not actually remove the vendored dep yet, nor updat
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/73067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
rupprecht wrote:
IIUC, the issue is that even though we are working in the build directory,
which is writeable, we are copying a file from the source tree, which may be
readonly, and those readonly permission bits persist when they're copied to the
build directory.
https://github.com/llvm/llv
rupprecht wrote:
> Is this a performance optimization or a function al change?
Neither. This should only affect tests, and the set of tests we skip/mark as
xfail should not change, we just generally know about it earlier in the test
setup.
https://github.com/llvm/llvm-project/pull/73067
_
rupprecht wrote:
ping :)
https://github.com/llvm/llvm-project/pull/73067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/73028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73028
>From a0805cfc2b2b1c84d58c0551ccf1acfaf2326a4a Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 11:38:43 -0800
Subject: [PATCH 1/3] [lldb][test] Remove `reason` from
`unittest2.expectedFa
rupprecht wrote:
> I suppose we don't really lose anything by moving away from `expectedFailure`
> from decorators?
>
Someone filed a FR ages ago for the standard unittest to take a reason for
xfail: https://bugs.python.org/issue12681
tl;dr good idea but that ship has sailed. So, this PR isn
rupprecht wrote:
> * This is still early enough that the standard `unittest` framework will
> recognize the test as xfail/skip by the time the test actually runs.
I did a little bit more research, turns out this is not a difference between
unittest and unittest2, but rather just something we h
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73028
>From a0805cfc2b2b1c84d58c0551ccf1acfaf2326a4a Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 11:38:43 -0800
Subject: [PATCH 1/2] [lldb][test] Remove `reason` from
`unittest2.expectedFa
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/73067
The @expectedFailureAll and @skipIf decorators will mark the test case as
xfail/skip if _all_ conditions passed in match, including debug_info.
* If debug_info is not one of the matching conditions, we can imme
rupprecht wrote:
This cleanup isn't strictly required to proceed w/ unittest2->unittest; we
already have a wrapper in decorators.py that we could update, from:
```py
def expectedFailure(func):
return unittest2.expectedFailure(func)
```
To:
```py
def expectedFailure(func):
if callable(f
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/73028
None
>From a0805cfc2b2b1c84d58c0551ccf1acfaf2326a4a Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 11:38:43 -0800
Subject: [PATCH] [lldb][test] Remove `reason` from `unittest2.expectedF
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rupprecht wrote:
> Beautiful, thank you for working on this. After this change, what's left to
> get us using the python-provided `unittest`?
The giant lambda inside `_decorateTest` has one remaining `self` reference,
which is `self.getDebugInfo()` -- i.e. the debug info specific variant creat
@@ -184,3 +187,144 @@ def hasChattyStderr(test_case):
):
return True # The dynamic linker on the device will complain about
unknown DT entries
return False
+
+
+def builder_module():
+return get_builder(sys.platform)
+
+
+def getArchitecture():
+"""Ret
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/72416
>From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Wed, 15 Nov 2023 08:58:17 -0800
Subject: [PATCH 1/2] [lldb][test] Move most `self` references out of decorato
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/72416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/72416
None
>From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Wed, 15 Nov 2023 08:58:17 -0800
Subject: [PATCH] [lldb][test] Move most `self` references out of decora
rupprecht wrote:
This seems to cause `TestTemplatePackArgs.py` to fail, e.g.
https://lab.llvm.org/buildbot/#/builders/68/builds/61819
```shell
File
"/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/lang/cpp/class-template-parameter-pack/TestTemplatePackArgs.py",
line 42, in
1 - 100 of 173 matches
Mail list logo
