rupprecht wrote: > Yeah given GreenDragon has been red for 20h, I'd like to get this merged > sooner rather than later. @DavidSpickett what's the benefit of waiting for > the arm bots to come back up?
Broadly speaking, if a buildbot is down, it interferes with bisection if something unexpected happens, particularly for commits like this and 5b386158aacac4b41126983a5379d36ed413d0ea which have a broader impact. So if the buildbot comes back up and TestRequireHWBreakpoints.py is failing, it'd be useful to see if it was because of this commit or something else. ... that's what I figure at least. In hindsight it would have been a good idea to check that buildbots were mostly green before landing the original change. I just assumed things were always green :) I feel relatively confident that this should fix the green dragon builds, and is worth the risk that it may create more of a mess in arm bots (but hopefully not!). Reverting 5b386158aacac4b41126983a5379d36ed413d0ea is also an option, but it seems like it has already exposed some crashes in `lldb-dap` that were previously ignored, so I think it's worth keeping. I'll merge this shortly. https://github.com/llvm/llvm-project/pull/81703 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
