[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-21 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/136065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Just to be super clear, if we were talking about core lldb behavior, I would be insistent about how it behaves. But we're talking about DAP and i'm just a bystander on that part of the codebase, and my feedback is just an opinion that you might want to consider, but don't

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: One side note, I was commenting while not 100% awake and didn't realize this was only in the DAP side of the codebase, I have less weight to argue one way or the other there. After I posted that I was like, I wonder why I didn't see the `stop-assembly-display` preference u

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Maybe I'm missing something, but I disagree with this change. We're talking about when you're stopped in a stack frame that has debug info (a file and line number), but the source file is unavailable, right. There is a setting to control this behavior already -- `stop-disa

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/136065 >From 41274f7632d13ab7ec83a420c6ad6258e6fe8c36 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 16 Apr 2025 17:18:02 -0700 Subject: [PATCH 1/3] [lldb][Mach-O corefiles] Don't init Target arch to cor

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/136065 >From 41274f7632d13ab7ec83a420c6ad6258e6fe8c36 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 16 Apr 2025 17:18:02 -0700 Subject: [PATCH 1/2] [lldb][Mach-O corefiles] Don't init Target arch to cor

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jason Molenda via lldb-commits
@@ -578,20 +605,47 @@ Status ProcessMachCore::DoLoadCore() { SetCanJIT(false); + // If we have an executable binary in the Target already, + // use that to set the Target's ArchSpec. + // + // Don't initialize the ArchSpec based on the corefile's cputype/cpusubtype + /

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/136065 This patch is making three changes, when loading a Mach-O corefile: 1. At the start of `DoLoadCore`, if a binary was provided in addition to the corefile, initialize the Target's ArchSpec. 2. Before Proce

[Lldb-commits] [lldb] [lldb] Fix lock inversion between statusline mutex and output mutex (PR #135956)

2025-04-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Looks good, thanks! https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-14 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: As the patch notes, Apple's M4 has the SME register & instructions, plus Streaming SVE Mode and the SVE register set, but most of the SVE instructions are not supported. And the SVE registers (z0-31, p0-15) are only available when the core is in Streaming SVE Mode I believe

[Lldb-commits] [lldb] [lldb] Slide eh_frame unwind plan if it doesn't begin at function boundary (PR #135333)

2025-04-14 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. OK looks reasonable. https://github.com/llvm/llvm-project/pull/135333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Nice debugging on this one, it can be a little unclear of the intended jobs for each of the reset/clear/terminate methods. This looks good to me. https://github.com/llvm/llvm-project/pull/135296 ___

[Lldb-commits] [lldb] df28c81 - [lldb][debugserver] Fix an off-by-one error in watchpoint identification (#134314)

2025-04-10 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-07T13:50:31-07:00 New Revision: df28c81f5a2b61a3b5ad1e6274dd27697a9367ac URL: https://github.com/llvm/llvm-project/commit/df28c81f5a2b61a3b5ad1e6274dd27697a9367ac DIFF: https://github.com/llvm/llvm-project/commit/df28c81f5a2b61a3b5ad1e6274dd27697a9367ac.diff

[Lldb-commits] [lldb] 369c773 - Revert "[lldb][debugserver] Fix an off-by-one error in watchpoint identification (#134314)"

2025-04-10 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-07T11:21:58-07:00 New Revision: 369c7739d0853b7931410037843d5a63f50bc0a1 URL: https://github.com/llvm/llvm-project/commit/369c7739d0853b7931410037843d5a63f50bc0a1 DIFF: https://github.com/llvm/llvm-project/commit/369c7739d0853b7931410037843d5a63f50bc0a1.diff

[Lldb-commits] [lldb] 50e218a - Revert "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)"

2025-04-08 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-08T21:05:50-07:00 New Revision: 50e218ad9cef3e59f8d8ba8c9c7b57ce9c213c52 URL: https://github.com/llvm/llvm-project/commit/50e218ad9cef3e59f8d8ba8c9c7b57ce9c213c52 DIFF: https://github.com/llvm/llvm-project/commit/50e218ad9cef3e59f8d8ba8c9c7b57ce9c213c52.diff

[Lldb-commits] [lldb] 76d7227 - [lldb][Minidump] Fix MAX_WRITE_CHUNK_SIZE type

2025-04-08 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-08T14:00:42-07:00 New Revision: 76d722732d7b417438f7aee8c36d79bf4feb2e97 URL: https://github.com/llvm/llvm-project/commit/76d722732d7b417438f7aee8c36d79bf4feb2e97 DIFF: https://github.com/llvm/llvm-project/commit/76d722732d7b417438f7aee8c36d79bf4feb2e97.diff

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/134314 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a19c018 - Revert "[lldb][debugserver] Save and restore the SVE/SME register state (#134184)"

2025-04-05 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-02T23:01:51-07:00 New Revision: a19c018379a1d08eceb5db533a19a6bf37423975 URL: https://github.com/llvm/llvm-project/commit/a19c018379a1d08eceb5db533a19a6bf37423975 DIFF: https://github.com/llvm/llvm-project/commit/a19c018379a1d08eceb5db533a19a6bf37423975.diff

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-04 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: CI bots showed a fail in lldb-api.tools/lldb-server.TestGdbRemoteRegisterState.py , will debug and update. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/23305/ https://github.com/llvm/llvm-project/pull/134184 __

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-04 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/134184 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-03 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/134314 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-03 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/134314 >From 780fc8f5081f97234749c70a139ad6034f48f3ae Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 3 Apr 2025 15:38:23 -0700 Subject: [PATCH 1/2] [lldb][debugserver] Fix an off-by-one error in watchpoin

[Lldb-commits] [lldb] f1c6612 - [lldb][debugserver] Save and restore the SVE/SME register state (#134184)

2025-04-03 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-03T15:48:54-07:00 New Revision: f1c6612202d88cbde224387621327a31609f2177 URL: https://github.com/llvm/llvm-project/commit/f1c6612202d88cbde224387621327a31609f2177 DIFF: https://github.com/llvm/llvm-project/commit/f1c6612202d88cbde224387621327a31609f2177.diff

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-03 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/134184 >From 7cc45f1a300b1b0f2cbb529f11a0f9e56c41ffea Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 2 Apr 2025 18:05:29 -0700 Subject: [PATCH 1/2] [lldb][debugserver] Save and restore the SVE/SME registe

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-02 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/134184 >From 7cc45f1a300b1b0f2cbb529f11a0f9e56c41ffea Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 2 Apr 2025 18:05:29 -0700 Subject: [PATCH 1/3] [lldb][debugserver] Save and restore the SVE/SME registe

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-02 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/134184 debugserver isn't saving and restoring the SVE/SME register state around inferior function calls. Making arbitrary function calls while in Streaming SVE mode is generally a poor idea because a NEON instru

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-28 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/132128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-27 Thread Jason Molenda via lldb-commits
@@ -1594,6 +1594,10 @@ static uint64_t bits(uint64_t value, uint32_t msbit, uint32_t lsbit) { m_sent_interrupt_signo); } } else { + // We've requested that the process stop anew; if we had recorded this + // requested stop as being

[Lldb-commits] [lldb] [lldb] Ignore registers that the debugserver fails to read (PR #132122)

2025-03-26 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: FWIW this is a change from September, https://github.com/llvm/llvm-project/pull/108663 , where debugserver can report DS, ES, SS, GSbase contents when the kernel provides them. But they are most often not available, so reads will fail. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-26 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Sorry for not commenting last week when this issue was live, but with regards to Apple silicon macs, there was a kernel behavior where watchpoints and hardware breakpoints were disabled by the kernel when it was single instruction stepping. I believe this was fixed in macO

[Lldb-commits] [lldb] [lldb] Teach FuncUnwinders about discontinuous functions (PR #133072)

2025-03-26 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/133072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] remove g/G packet handling from debugserver (PR #132127)

2025-03-20 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/132127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-20 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/132128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-19 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/132128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-19 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/132128 This fixes an uncommon bug with debugserver controlling an inferior process that is hitting an internal breakpoint & continuing when multiple interrupts are sent by SB API to lldb. In the reproducing setu

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/5] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb][debugserver] Synchronize interrupt and resume signals (PR #131073)

2025-03-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/131073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [debugserver] Fix mutex scope in RNBRemote::CommDataReceived (PR #131077)

2025-03-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Yes looks correct to me. https://github.com/llvm/llvm-project/pull/131077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Synchronize interrupt and resume signals (PR #131073)

2025-03-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I was worried about the timing in `MachProcess::PrivateResume` versus `Interrupt` but I think it will be OK. `PrivateResume` does ``` void MachProcess::PrivateResume() { PTHREAD_MUTEX_LOCKER(locker, m_exception_messages_mutex); // Set our state accordingly if (m_thre

[Lldb-commits] [lldb] 09a36c8 - [lldb][NFC] Correct whitespace in SearchForKernelWithDebugHints

2025-03-13 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-03-13T10:08:09-07:00 New Revision: 09a36c82793ba32b87faf11fbfc2e7624f25e92e URL: https://github.com/llvm/llvm-project/commit/09a36c82793ba32b87faf11fbfc2e7624f25e92e DIFF: https://github.com/llvm/llvm-project/commit/09a36c82793ba32b87faf11fbfc2e7624f25e92e.diff

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: FTR on the CI bot my API test did not make correctly. I reverted the PR, rewrote the makefiles for the API test, relanded. https://github.com/llvm/llvm-project/pull/129967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 82af988 - Revert "[lldb][Mach-O] Don't read symbol table of specially marked binary (#129967)"

2025-03-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-03-06T17:19:43-08:00 New Revision: 82af9888dbbcd248ec4d41968c53135e12e13454 URL: https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454 DIFF: https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454.diff

[Lldb-commits] [lldb] cec36e2 - Revert "Add LDFLAGS to fix bot failure"

2025-03-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-03-06T17:19:43-08:00 New Revision: cec36e279cb871dd011e105e0c9d3edccd0dcad9 URL: https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9 DIFF: https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9.diff

[Lldb-commits] [lldb] 00fdc52 - Add LDFLAGS to fix bot failure

2025-03-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-03-06T17:03:16-08:00 New Revision: 00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977 URL: https://github.com/llvm/llvm-project/commit/00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977 DIFF: https://github.com/llvm/llvm-project/commit/00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977.diff

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/129967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > LGTM. I think you could simplify the test even further by using C++ but on > the other hand the C tests compile a little faster. yeah I was going to rewrite it into slightly nicer C but then I realized there was more value in doing it exactly the same as the other test t

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,19 @@ +C_SOURCES := main.c +LD_EXTRAS = -Wl,-rpath "-Wl,$(shell pwd)" -L. -lno-nlists -lhas-nlists + +.PHONY: build-libno-nlists build-libhas-nlists +all: build-libno-nlists build-libhas-nlists a.out + +include Makefile.rules + +build-libno-nlists: no-nlists.c no-nlist-

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I adopted the synchronization scheme that we do in other attach tests -- the python provides a filename that the inferior should create with its pid, we launch it and wait until that file exists (indicating that the inferior is done setting up) and then the python tests exe

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/7] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/6] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,81 @@ +""" +Test that we read don't read the nlist symbols for a specially marked dylib +when read from memory. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from time import sle

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/4] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/3] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/129967 >From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Mar 2025 17:27:20 -0800 Subject: [PATCH 1/2] [lldb][Mach-O] Don't read symbol table of specially mar

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-05 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The change to ObjectFileMachO looks a little larger than it really is because i moved the SectionSP initializations ~100 lines earlier in ParseSymtab than they were. I'm scanning for this new section the same way we scan for eh_frame. ObjectFileMachO already had "load lev

[Lldb-commits] [lldb] [lldb][Mach-O] Don't read symbol table of specially marked binary (PR #129967)

2025-03-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/129967 We have a binary image on Darwin that has no code, only metadata. It has a large symbol table with many external symbol names that will not be needed in the debugger. And it is possible to not have this b

[Lldb-commits] [lldb] [lldb] Add missing calls to SetThreadHitBreakpointSite/DetectThreadStoppedAtUnexecutedBP (PR #128726)

2025-02-26 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I'm not sure if this edge case can come up with this MemoryThread use cases. https://github.com/llvm/llvm-project/pull/128726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] [lldb] Add missing calls to SetThreadHitBreakpointSite/DetectThreadStoppedAtUnexecutedBP (PR #128726)

2025-02-26 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Felipe and I have been discussing these mechanisms all this week, and one edge case would be a thread that hits a breakpoint instruction, and the bp has a thread ID match requirement which this thread doesn't satisfy. In that scenario, the thread will not have an eStopReas

[Lldb-commits] [lldb] [lldb] Add missing calls to SetThreadHitBreakpointSite/DetectThreadStoppedAtUnexecutedBP (PR #128726)

2025-02-25 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/128726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Improve duplicated code in unexecuted breakpoint detection (PR #128724)

2025-02-25 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Good idea. I think you need to also update ProcessWindows.cpp? I'm still a little unsatisfied with my approach of "a thread calls `DetectThreadStoppedAtUnexecutedBP()` and if it turns out it DID execute the breakpoint, then calls `Set

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-02-20 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > From a quick check of the logs, green dragon seems to be set up to build > debugserver, too. greendragon probably does build debugserver, but tests use Xcode's debugserver for proper codesigning, not the built debugserver. https://github.com/llvm/llvm-project/pull/123945

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/127156 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/127156 >From 0a6558940403814ffa2bf6c265bc0e9267eef855 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 13 Feb 2025 18:20:28 -0800 Subject: [PATCH 1/4] [lldb][Mach-O] Read dyld_all_image_infos addr from `mai

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/127156 >From 0a6558940403814ffa2bf6c265bc0e9267eef855 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 13 Feb 2025 18:20:28 -0800 Subject: [PATCH 1/3] [lldb][Mach-O] Read dyld_all_image_infos addr from `mai

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-18 Thread Jason Molenda via lldb-commits
@@ -5669,6 +5673,10 @@ bool ObjectFileMachO::GetCorefileMainBinaryInfo(addr_t &value, type = eBinaryTypeStandalone; typestr = "standalone"; break; + case 4: +type = eBinaryTypeUserAllImageInfos; +typestr = "u

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/127156 >From 0a6558940403814ffa2bf6c265bc0e9267eef855 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 13 Feb 2025 18:20:28 -0800 Subject: [PATCH 1/2] [lldb][Mach-O] Read dyld_all_image_infos addr from `mai

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I wanted to add a new `eBinaryType` enum from the ObjectFile to describe what address is being returned. But within ProcessMachCore, there was no need to add the distinction between the existing `m_dyld_addr` and the new `m_dyld_all_image_infos_addr`, I did it to keep the

[Lldb-commits] [lldb] [lldb][Mach-O] Read dyld_all_image_infos addr from `main bin spec` LC_NOTE (PR #127156)

2025-02-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/127156 Mach-O corefiles have LC_NOTE metadata, one LC_NOTE that lldb recognizes is `main bin spec` which can specify that this is a kernel corefile, userland corefile, or firmware/standalone corefile. With a user

[Lldb-commits] [lldb] [lldb] Don't warn that libobjc was read from memory in corefile (PR #127138)

2025-02-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/127138 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't warn that libobjc was read from memory in corefile (PR #127138)

2025-02-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/127138 AppleObjCRuntimeV2 prints a warning when we read libobjc.A.dylib from memory, as a canary to detect that we are reading system binaries out of memory (which is slow, and we try hard to avoid). But with a c

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2025-02-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: For the record, this PR was finally re-landed as https://github.com/llvm/llvm-project/pull/126988 after four separate commits to address issues found in CI testing when I originally merged this. https://github.com/llvm/llvm-project/pull/96260 ___

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126988 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior (PR #105594)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/105594 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior (PR #105594)

2025-02-12 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I'm abandoning this PR where I was working through all the CI regressions, but landed them in separate clean PRs. I created https://github.com/llvm/llvm-project/pull/126988 to re-land the July 2024 patch, rebased to current sources. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-12 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The PRs I landed before this to make this run cleanly on the CI bots are https://github.com/llvm/llvm-project/pull/108518 https://github.com/llvm/llvm-project/pull/108504 https://github.com/llvm/llvm-project/pull/108127 https://github.com/llvm/llvm-project/pull/126838 (plus

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126988 lldb today has two rules: When a thread stops at a BreakpointSite, we set the thread's StopReason to be "breakpoint hit" (regardless if we've actually hit the breakpoint, or if we've merely stopped *at* th

[Lldb-commits] [lldb] [lldb] Correctly resolve (discontinuous) function offsets when disassembling (PR #126925)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This looks straightforward. https://github.com/llvm/llvm-project/pull/126925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] fa71238 - [lldb] inserted a typeo when checking in a suggested fix

2025-02-12 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-12T14:00:41-08:00 New Revision: fa71238da800f3a818ec0e0649462389dc577890 URL: https://github.com/llvm/llvm-project/commit/fa71238da800f3a818ec0e0649462389dc577890 DIFF: https://github.com/llvm/llvm-project/commit/fa71238da800f3a818ec0e0649462389dc577890.diff

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126838 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/126838 >From 4bc364c7217ad43b886ece04f4ee00e5b0a03ce3 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 11 Feb 2025 18:01:33 -0800 Subject: [PATCH 1/2] [lldb] Update ThreadPlanStepOut to handle new breakpoin

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior (PR #105594)

2025-02-11 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105594 >From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 19 Jul 2024 17:26:13 -0700 Subject: [PATCH 01/14] [lldb] Change lldb's breakpoint handling behavior (#

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior (PR #105594)

2025-02-11 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The details of the bug that Martin found were actually bit a interesting. The core of the issue is that the thread has a ThreadPlanStepOut, and before we resume execution, because we're at a BreakpointSite that has been hit, we push a ThreadPlanStepOverBreakpoint plan. It

[Lldb-commits] [lldb] fb623a3 - [lldb] Fix two old UUID method calls in ObjectFileMachO

2025-02-10 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-10T15:08:03-08:00 New Revision: fb623a35248ed84cc7c82c696bf92419324720de URL: https://github.com/llvm/llvm-project/commit/fb623a35248ed84cc7c82c696bf92419324720de DIFF: https://github.com/llvm/llvm-project/commit/fb623a35248ed84cc7c82c696bf92419324720de.diff

[Lldb-commits] [lldb] [lldb] [darwin] Upstream a few DriverKit cases (PR #126604)

2025-02-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [darwin] Upstream a few DriverKit cases (PR #126604)

2025-02-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126604 A DriverKit process is a kernel extension that runs in userland, instead of running in the kernel address space/priv levels, they've been around a couple of years. From lldb's perspective a DriverKit proc

[Lldb-commits] [lldb] [lldb] Upstream a few remaining Triple::XROS patches (PR #126335)

2025-02-08 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream a few remaining Triple::XROS patches (PR #126335)

2025-02-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126335 Recognize the visionOS Triple::OSType::XROS os type. Some of these have already been landed on main, but I reviewed the downstream sources and there were a few that still needed to be landed upstream. >Fr

[Lldb-commits] [lldb] [lldb] Use Lambda to simplify repeptitive code in DynamicLoaderDarwin (NFC) (PR #126175)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Yeah that is better, thanks, I should have done it myself. https://github.com/llvm/llvm-project/pull/126175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/126171 >From af2fa2e17ceb527dd9a2b8c5d7e72da374b4512b Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 6 Feb 2025 18:48:02 -0800 Subject: [PATCH 1/2] [lldb][Darwin] Change DynamicLoaderDarwin to default to

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I originally removed the old DynamicLoader plugin except for corefiles. But it seemed unnecessary to break lldb from working on old macOS for no reason. I should probably remove the iOS/watchOS/tvOS cases, it's years outside Xcode's supported OS versions. https://github.

[Lldb-commits] [lldb] d8e0b13 - [lldb][NFC] Small comment fix in Process.h

2025-02-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-06T18:54:30-08:00 New Revision: d8e0b130bd7b2dd168642a82056b8eca21c49f9f URL: https://github.com/llvm/llvm-project/commit/d8e0b130bd7b2dd168642a82056b8eca21c49f9f DIFF: https://github.com/llvm/llvm-project/commit/d8e0b130bd7b2dd168642a82056b8eca21c49f9f.diff

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126171 In Sep 2016 and newer Darwin releases, debugserver uses libdyld SPI to gather information about the binaries loaded in a process. Before Sep 2016, lldb would inspect the dyld internal data structures dire

[Lldb-commits] [lldb] 163ccfa - [lldb][NFC] whitespace reflow

2025-02-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-06T15:04:29-08:00 New Revision: 163ccfac33201948eb430db6fac38d265958cfaa URL: https://github.com/llvm/llvm-project/commit/163ccfac33201948eb430db6fac38d265958cfaa DIFF: https://github.com/llvm/llvm-project/commit/163ccfac33201948eb430db6fac38d265958cfaa.diff

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The Xcode installed on the macOS CI bots was updated to Xcode 16.2 a few weeks ago, so we've got a pretty recent debugserver being used on them now. https://github.com/llvm/llvm-project/pull/126144 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126144 When a test depends on a new debugserver feature/fix, the API test must be marked @skipIfOutOfTreeDebugserver because the macOS CI bots test using the latest Xcode release debugserver. But over time all o

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   4   5   6   7   8   9   10   >