Author: Jason Molenda Date: 2025-04-08T21:05:50-07:00 New Revision: 50e218ad9cef3e59f8d8ba8c9c7b57ce9c213c52
URL: https://github.com/llvm/llvm-project/commit/50e218ad9cef3e59f8d8ba8c9c7b57ce9c213c52 DIFF: https://github.com/llvm/llvm-project/commit/50e218ad9cef3e59f8d8ba8c9c7b57ce9c213c52.diff LOG: Revert "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" This reverts commit 232525f06942adb3b9977632e38dcd5f08c0642d. This change is causing test crashes while running TestCompletion.py on Darwin systems, most of the CI runs have failed since it has been merged in. Added: Modified: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/test/API/macosx/thread_start_bps/TestBreakpointsThreadInit.py Removed: ################################################################################ diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp index d7e8c2ce7944e..68360788c96e6 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -3410,9 +3410,6 @@ Status ProcessGDBRemote::DisableWatchpoint(WatchpointSP wp_sp, bool notify) { void ProcessGDBRemote::Clear() { m_thread_list_real.Clear(); m_thread_list.Clear(); - if (m_thread_create_bp_sp) - if (TargetSP target_sp = m_target_wp.lock()) - target_sp->RemoveBreakpointByID(m_thread_create_bp_sp->GetID()); } Status ProcessGDBRemote::DoSignal(int signo) { diff --git a/lldb/test/API/macosx/thread_start_bps/TestBreakpointsThreadInit.py b/lldb/test/API/macosx/thread_start_bps/TestBreakpointsThreadInit.py index bf667f6f7d336..1c6fd4f91c73e 100644 --- a/lldb/test/API/macosx/thread_start_bps/TestBreakpointsThreadInit.py +++ b/lldb/test/API/macosx/thread_start_bps/TestBreakpointsThreadInit.py @@ -35,23 +35,3 @@ def test_internal_bps_resolved(self): for bp in bps: num_resolved += bp.GetNumResolvedLocations() self.assertGreater(num_resolved, 0) - - @skipUnlessDarwin - def test_internal_bps_deleted_on_relaunch(self): - self.build() - - source_file = lldb.SBFileSpec("main.c") - target, process, thread, bkpt = lldbutil.run_to_source_breakpoint( - self, "initial hello", source_file - ) - - self.runCmd("break list --internal") - output = self.res.GetOutput() - self.assertEqual(output.count("thread-creation"), 1) - - process.Kill() - self.runCmd("run", RUN_SUCCEEDED) - - self.runCmd("break list --internal") - output = self.res.GetOutput() - self.assertEqual(output.count("thread-creation"), 1) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
