Author: Jason Molenda Date: 2025-04-08T14:00:42-07:00 New Revision: 76d722732d7b417438f7aee8c36d79bf4feb2e97
URL: https://github.com/llvm/llvm-project/commit/76d722732d7b417438f7aee8c36d79bf4feb2e97 DIFF: https://github.com/llvm/llvm-project/commit/76d722732d7b417438f7aee8c36d79bf4feb2e97.diff LOG: [lldb][Minidump] Fix MAX_WRITE_CHUNK_SIZE type MinidumpFileBuilder calls std::min(MAX_WRITE_CHUNK_SIZE, func_returning_uint64_t) and on Darwin this errors out with unsigned long long & unsigned long not being the same type. Added: Modified: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h Removed: ################################################################################ diff --git a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h index a3f8f00ee215d..46b20f90138fe 100644 --- a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h +++ b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h @@ -171,7 +171,7 @@ class MinidumpFileBuilder { // but we want to try to keep the size of m_data small // and we will only exceed a 128 mb buffer if we get a memory region // that is larger than 128 mb. - static constexpr size_t MAX_WRITE_CHUNK_SIZE = (1024 * 1024 * 128); + static constexpr uint64_t MAX_WRITE_CHUNK_SIZE = (1024 * 1024 * 128); static constexpr size_t HEADER_SIZE = sizeof(llvm::minidump::Header); static constexpr size_t DIRECTORY_SIZE = sizeof(llvm::minidump::Directory); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
