[Lldb-commits] [PATCH] D89813: [CMake][NFC] Limit the use of uppercase_CMAKE_BUILD_TYPE

ctetreau created this revision. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, Sanitizers, lebedev.ri, hiraditya, arichardson, mgorny. Herald added a reviewer: lebedev.ri. Herald added projects: Sanitizers, LLDB, libc++, libc++abi, libunwind, LLVM. Herald added a reviewer: l

[Lldb-commits] [PATCH] D89813: [CMake][NFC] Limit the use of uppercase_CMAKE_BUILD_TYPE

ctetreau added a comment. In D89813#2342552 , @ctetreau wrote: > I would assume so. I'll take a look. It doesn't seem to work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89813/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D89813: [CMake][NFC] Limit the use of uppercase_CMAKE_BUILD_TYPE

ctetreau added a comment. I would assume so. I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89813/new/ https://reviews.llvm.org/D89813 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D89813: [CMake][NFC] Limit the use of uppercase_CMAKE_BUILD_TYPE

ctetreau marked an inline comment as done. ctetreau added a comment. In D89813#2342463 , @ldionne wrote: > I quite like this. We should strive to use the same name as CMake uses for > its build types, i.e. `Debug`, `Release`, etc. > > If I configure CMake

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG26459e6d8eeb: Fix "Unknown arguments specified" to if in lldb (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/ https://revie

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau added a comment. OK, for now, I've restored the use of uppercase_CMAKE_BUILD_TYPE. It looks like this does get set, and it's just the empty string on my machine because windows. I'd like to see it get removed, but this commit is about fixing the build. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau updated this revision to Diff 299491. ctetreau added a comment. restore use of uppercase_CMAKE_BUILD_TYPE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/ https://reviews.llvm.org/D89807 Files: lldb/cmake/modules/FindPythonAndSw

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau planned changes to this revision. ctetreau added a comment. After experimenting a bit, it seems that if you pass `-DCMAKE_BUILD_TYPE=RELEASE`, then the value of CMAKE_BUILD_TYPE will also be uppercase. This might represent a "good reason" to use the uppercase_CMAKE_BUILD_TYPE version.

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau added a comment. In D89807#2342192 , @JDevlieghere wrote: > What's the motivation for this? This is preventing me from generating the build system: -- SWIG 2 or later is required for Python support in LLDB but could not be found CMake Erro

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

ctetreau created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. ctetreau requested review of this revision. Herald added a subscriber: JDevlieghere. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89807 Files: lldb/cmake/modules/Fin

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dea3f129878: [SVE] Add new VectorType subclasses (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259126. ctetreau added a comment. split C api stuff into separate commit. Do bare minimum here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Exp

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259114. ctetreau added a comment. Catch stragglers in C api Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/in

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259104. ctetreau added a comment. remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/inclu

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259095. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/include/llvm-c/Core.h

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259044. ctetreau added a comment. Fixup canLosslesslyBitCastTo to use FixedVectorType again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expres

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 257542. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/i

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau marked an inline comment as done. ctetreau added inline comments. Comment at: llvm/include/llvm/IR/DerivedTypes.h:430 + /// Construct a VectorType that has the same shape as some other VectorType + static VectorType *get(Type *ElementType, VectorType *Other) { +ret

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 257138. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/include/llvm-c/Core.h

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau marked 2 inline comments as done. ctetreau added inline comments. Comment at: llvm/include/llvm/IR/DerivedTypes.h:436 + + static VectorType *get(Type *ElementType, const VectorType *Other) { +return VectorType::get(ElementType, Other->getElementCount()); ---

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256435. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/i

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau marked an inline comment as done. ctetreau added inline comments. Comment at: llvm/lib/ExecutionEngine/ExecutionEngine.cpp:1011 llvm_unreachable("Unknown constant pointer type!"); - } - break; + } break; efriedma wrote: > ? clang-format-diff mu

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256129. ctetreau added a comment. Move getMinNumElements to ScalableVectorType. There's no reason for it to be in base VectorType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256100. ctetreau added a comment. Herald added subscribers: lldb-commits, frgossen, grosul1, Joonsoo, kerbowa, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, nhaehnle, jve

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256101. ctetreau added a comment. Fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/include/llvm

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau added a comment. In D77587#1965604 , @efriedma wrote: > If I'm following correctly, this should apply on its own. Then you're > expecting the following API changes: > > 1. getNumElements() will move from VectorType to FixedVectorType. Existing