ctetreau updated this revision to Diff 299491. ctetreau added a comment. restore use of uppercase_CMAKE_BUILD_TYPE
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/ https://reviews.llvm.org/D89807 Files: lldb/cmake/modules/FindPythonAndSwig.cmake Index: lldb/cmake/modules/FindPythonAndSwig.cmake =================================================================== --- lldb/cmake/modules/FindPythonAndSwig.cmake +++ lldb/cmake/modules/FindPythonAndSwig.cmake @@ -48,7 +48,7 @@ get_property(MULTI_CONFIG GLOBAL PROPERTY GENERATOR_IS_MULTI_CONFIG) if ("${Python3_VERSION}" VERSION_GREATER_EQUAL "3.7" AND "${SWIG_VERSION}" VERSION_LESS "4.0" AND WIN32 AND ( - ${MULTI_CONFIG} OR (${uppercase_CMAKE_BUILD_TYPE} STREQUAL "DEBUG"))) + ${MULTI_CONFIG} OR (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG"))) # Technically this can happen with non-Windows builds too, but we are not # able to detect whether Python was built with assertions, and only Windows # has the requirement that Debug LLDB must use Debug Python.
Index: lldb/cmake/modules/FindPythonAndSwig.cmake =================================================================== --- lldb/cmake/modules/FindPythonAndSwig.cmake +++ lldb/cmake/modules/FindPythonAndSwig.cmake @@ -48,7 +48,7 @@ get_property(MULTI_CONFIG GLOBAL PROPERTY GENERATOR_IS_MULTI_CONFIG) if ("${Python3_VERSION}" VERSION_GREATER_EQUAL "3.7" AND "${SWIG_VERSION}" VERSION_LESS "4.0" AND WIN32 AND ( - ${MULTI_CONFIG} OR (${uppercase_CMAKE_BUILD_TYPE} STREQUAL "DEBUG"))) + ${MULTI_CONFIG} OR (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG"))) # Technically this can happen with non-Windows builds too, but we are not # able to detect whether Python was built with assertions, and only Windows # has the requirement that Debug LLDB must use Debug Python.
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits