ctetreau added a comment. In D89807#2342192 <https://reviews.llvm.org/D89807#2342192>, @JDevlieghere wrote:
> What's the motivation for this? This is preventing me from generating the build system: -- SWIG 2 or later is required for Python support in LLDB but could not be found CMake Error at [redacted]/lldb/cmake/modules/FindPythonAndSwig.cmake:49 (if): if given arguments: "3.8.0" "VERSION_GREATER_EQUAL" "3.7" "AND" "" "VERSION_LESS" "4.0" "AND" "WIN32" "AND" "(" "1" "OR" "(" "STREQUAL" "Debug" ")" ")" Unknown arguments specified Call Stack (most recent call first): [redacted]/lldb/cmake/modules/LLDBConfig.cmake:48 (find_package) [redacted]/lldb/cmake/modules/LLDBConfig.cmake:59 (add_optional_dependency) [redacted]/lldb/CMakeLists.txt:29 (include) -- Configuring incomplete, errors occurred! There are two issues: `STREQUAL` accepts variables on the LHS, so the braces are unneccesary. The real issue though is that `uppercase_CMAKE_BUILD_TYPE` is not defined at this point. I could define it, but the case of the possible values of `CMAKE_BUILD_TYPE` are well defined so there's no reason to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/ https://reviews.llvm.org/D89807 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits