https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/143183
When testing LLDB, we want to make sure to use the same Python as the one we
used to build it.
This patch used the CMake variable `Python3_ROOT_DIR` to set the `PYTHONHOME`
env variable in LLDB lit test
charles-zablit wrote:
> But if we're just going to consume it anyway, then keeping them as
> `CalculateNumChildrenIgnoringErrors` seems fine (though I would still prefer
> bubbling up errors, but that brings us back to the discussion about how we
> should be using `llvm::Expected`)
Agreed, th
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/142139
This patch removes a redundant check in DemangledNameInfo::hasBasename.
Since the start and end range are unsigned, if end > start, then end is always
greater than 0.
>From 738d0058769811d6f760f0a351a43
charles-zablit wrote:
Please feel free to merge when possible, as I do not have commit access yet.
https://github.com/llvm/llvm-project/pull/141790
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
charles-zablit wrote:
> The warning in question is `-Wmissing-field-initializers`, which is warning
> that in the unit test not all fields of this struct are explicitly
> initialized. Even if these fields are optional, I think this is the wrong way
> to address this: we should either update th
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/141790
>From 788cabe234336be7168996805f40da7f26fdbec9 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 28 May 2025 16:17:34 +0100
Subject: [PATCH 1/3] add explicit default initialization to DemangledName
charles-zablit wrote:
> Could you add the missing initializers to the test? I think you can just add
> a default value so you don't need to touch every test-case
Sorry about that, fixed it with explicit default values in
https://github.com/llvm/llvm-project/pull/141790.
https://github.com/llv
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/141790
https://github.com/llvm/llvm-project/pull/140762 introduces some compilation
warnings in `lldb/unittests/Core/MangledTest.cpp`. This patch adds explicit
default initialization to `DemangledNameInfo` to s
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/9] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/8] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/7] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/6] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/5] refactor demangler range tracking
---
lldb/include
charles-zablit wrote:
> But lets add a test to confirm that no plugin currently handles the new
> `FunctionPrefix` variable
Sorry I forgot about the test, will add it 👍
https://github.com/llvm/llvm-project/pull/140762
___
lldb-commits mailing list
@@ -6,7 +6,7 @@ add_lldb_unittest(LLDBCoreTests
DumpDataExtractorTest.cpp
DumpRegisterInfoTest.cpp
FormatEntityTest.cpp
- MangledTest.cpp
+ ItaniumMangledTest.cpp
charles-zablit wrote:
The rename was to separate the Swift tests from the Itanium tests.
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
@@ -88,6 +88,7 @@ struct Entry {
FunctionNameWithArgs,
FunctionNameNoArgs,
FunctionMangledName,
+FunctionPrefix,
charles-zablit wrote:
Fixed, thanks 👍
https://github.com/llvm/llvm-project/pull/140762
__
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/4] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/2] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/140762
This PR is a subset of the commits made in
https://github.com/swiftlang/llvm-project/pull/10710.
The most notable change is the addition of `PrefixRange` and `SuffixRange`
which are a catch-all to trac
@@ -270,10 +270,14 @@ class VectorTypeSyntheticFrontEnd : public
SyntheticChildrenFrontEnd {
}
llvm::Expected GetIndexOfChildWithName(ConstString name) override {
-const char *item_name = name.GetCString();
-uint32_t idx = ExtractIndexFromString(item_name);
-i
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/138297
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/138297
>From 8f62523c8ccece4a1c11af51ccf320b19b2ed013 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 2 May 2025 16:37:09 +0100
Subject: [PATCH 1/2] [lldb] Upgrade ExtractIndexFromString to use
llvm::E
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/138249
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -142,6 +142,7 @@ add_lldb_library(liblldb SHARED ${option_framework}
lldbValueObject
lldbVersion
${LLDB_ALL_PLUGINS}
+swiftCore
charles-zablit wrote:
You are correct, sorry about that. I opened the PR here:
https://github.com/llvm/llvm-proj
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/138249
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/138249
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/138297
This PR is in continuation of https://github.com/llvm/llvm-project/pull/136693.
It upgrades `ExtractIndexFromString` to use `llvm::Expected`.
Rate limit · GitHub
b
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/138249
When building LLDB on Windows with `build.ps1`, the following linker error
happens, especially after rebuilding incrementally. The error sometimes goes
away after deleting CMakeCache.txt, but that's not
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public
SyntheticChildrenFrontEnd {
GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib);
- size_t GetIndexOfChildWithName(ConstString name) override {
+ llvm::Expected GetIndexOfChildWithName(ConstString name) override
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1202,13 +1225,16 @@ lldb_private::formatters::Foundation1100::
m_data_64 = nullptr;
}
-size_t
-lldb_private::formatters::Foundation1100::
- NSDictionaryMSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) {
+llvm::Expected lldb_private::formatters::Foundation11
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public
SyntheticChildrenFrontEnd {
GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib);
- size_t GetIndexOfChildWithName(ConstString name) override {
+ llvm::Expected GetIndexOfChildWithName(ConstString name) override
@@ -14,6 +14,7 @@
#include "llvm/Support/Format.h"
#include "llvm/Support/FormatProviders.h"
#include "llvm/Support/FormatVariadicDetails.h"
+#include
charles-zablit wrote:
Fixed, thanks!
https://github.com/llvm/llvm-project/pull/136693
_
@@ -456,9 +464,13 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
-? StringLayout::DSC
-: StringLayout::CSD;
+ auto index_or_
@@ -152,7 +152,8 @@
lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdVectorSyntheticFront
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -173,7 +173,8 @@
lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::Update() {
return ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdProxyArraySyntheti
@@ -488,10 +488,12 @@
lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::GetChildAtIndex(
return m_pair_sp->GetChildAtIndex(idx);
}
-size_t lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibCxxMapIterator
@@ -456,7 +460,7 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
+ StringLayout layout = l->GetIndexOfChildWithName("__data_").get() == 0
charles-zablit wrote:
Fix
@@ -199,10 +199,12 @@
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t StdlibCoroutineHandleSyntheticFrontEnd::GetIndexOfChildWithName(
+llvm::Expected
+StdlibCoroutineHandleSyntheticFrontEnd::Get
@@ -172,8 +173,15 @@ bool lldb_private::formatters::BlockPointerSummaryProvider(
static const ConstString s_FuncPtr_name("__FuncPtr");
- lldb::ValueObjectSP child_sp = synthetic_children->GetChildAtIndex(
- synthetic_children->GetIndexOfChildWithName(s_FuncPtr_name));
@@ -218,10 +218,11 @@ bool
ScriptedSyntheticChildren::FrontEnd::MightHaveChildren() {
return m_interpreter->MightHaveChildrenSynthProviderInstance(m_wrapper_sp);
}
-size_t ScriptedSyntheticChildren::FrontEnd::GetIndexOfChildWithName(
-ConstString name) {
+llvm::Expected
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/136693
This patch replaces the use of `UINT32_MAX` as the error return value of
`GetIndexOfChildWithName` with `llvm::Expected`.
>From 143140ca46927e87019dcc818702785ebdb15540 Mon Sep 17 00:00:00 2001
From: Cha
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/135963
>From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 16 Apr 2025 11:28:54 +0100
Subject: [PATCH 1/3] [lldb] Remove unused API
CompilerType::GetIndexOfFi
charles-zablit wrote:
Sorry I forgot to run `clang-format` I will configure a pre-commit hook.
https://github.com/llvm/llvm-project/pull/135963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/135963
>From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 16 Apr 2025 11:28:54 +0100
Subject: [PATCH 1/4] [lldb] Remove unused API
CompilerType::GetIndexOfFi
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/135963
>From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 16 Apr 2025 11:28:54 +0100
Subject: [PATCH 1/3] [lldb] Remove unused API
CompilerType::GetIndexOfFi
charles-zablit wrote:
> I think the test can just do this:
>
> ```
> uint64_t bit_offset;
> std::string name;
> field_type = field_type.GetFieldAtIndex(
> field_type.GetIndexOfChildWithName(field_name,
> /*omit_empty_base_classes=*/false),
> name, &
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/135963
>From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 16 Apr 2025 11:28:54 +0100
Subject: [PATCH 1/3] [lldb] Remove unused API
CompilerType::GetIndexOfFi
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/135963
>From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 16 Apr 2025 11:28:54 +0100
Subject: [PATCH 1/2] [lldb] Remove unused API
CompilerType::GetIndexOfFi
charles-zablit wrote:
> We probably shouldnt be removing the test. Is there some way to test whatever
> we used to test without the API?
I see 2 options:
1. Move the body of `CompilerType::GetIndexOfFieldWithName` into the test
directly. This way, we remove the API but keep the test.
2. Keep
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/135963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/135963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
> It's worth mentioning that the LLVM convention (as opposed to what is done in
> the swift fork) is to avoid force-pushing.
Thanks! I will avoid that for the future PRs 👍
https://github.com/llvm/llvm-project/pull/135963
___
ll
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/135963
>From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 16 Apr 2025 11:28:54 +0100
Subject: [PATCH] [lldb] Remove unused API
CompilerType::GetIndexOfFieldW
charles-zablit wrote:
> Is this API used for anything outside of that `PlatformSigInfoTest`? It
> doesn't seem to be used anywhere (including the apple fork). Should we just
> remove this API?
It's not used anywhere apart from the `PlatformSigInfoTest`. It's also inside
the `lldb_private` nam
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/135963
This patch updates the `CompilerType::GetIndexOfFieldWithName` API to use
`llvm::Expected` if no index is found instead of `UINT32_MAX`.
>From aaf9c4ec3e68d78d963cdac3d3f08dc207d49cad Mon Sep 17 00:00:00
60 matches
Mail list logo
