https://github.com/charles-zablit approved this pull request.
https://github.com/llvm/llvm-project/pull/148235
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
Is it a reasonable use case to want to not print anything? If not, then I think
this is a valid way of deactivating the plugin formatting.
https://github.com/llvm/llvm-project/pull/148235
___
lldb-commits mailing list
lldb-commit
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/147768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
Deactivating these tests allows the CI to pass on the Apple bots:
https://github.com/swiftlang/llvm-project/pull/10971
https://github.com/llvm/llvm-project/pull/147768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/147768
https://github.com/llvm/llvm-project/pull/144913 was reverted because some of
the Darwin tests were failing on SDKs prior to `15.0`. This config is not
supported (having a version of lldb which is more r
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/146903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/146903
Fix an error message which incorrectly says that we failed to handle a
`basename`. It should say `formatted-arguments` instead.
>From 0be82628756ca149de165452ba2d28d83c24b0f9 Mon Sep 17 00:00:00 2001
Fro
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/7] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/6] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/6] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/5] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/4] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
@@ -1128,17 +1128,8 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
FileSpec sysroot_spec;
- if (target) {
-if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/3] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
@@ -1130,13 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/2] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/146062
This patch is part of an effort to remove the ResolveSDKPathFromDebugInfo
method, and more specifically the variant which takes a Module as argument.
This PR should be merged after https://github.com/llv
charles-zablit wrote:
> Looks like this does break all the modules tests:
> https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/28395/execution/node/106/log/
> ...
> Could we revert for now to unblock bots?
Just opened a revert PR for this commit and a child commit.
https://
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/145864
Revert the changes made in the following PRs as they are causing bot failures:
- https://github.com/llvm/llvm-project/pull/145744
- https://github.com/llvm/llvm-project/pull/144913
>From a540d68b0a882f0f
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/145744
This patch is part of an effort to remove the `ResolveSDKPathFromDebugInfo`
method, and more specifically the variant which takes a `Module` as argument.
This PR should be merged after https://github.com
charles-zablit wrote:
Confirmed that this builds fine with the changes 👍
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/145744
>From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 19 Jun 2025 16:17:33 +0100
Subject: [PATCH 1/4] [lldb][darwin] force BuiltinHeadersInSystemModules t
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
@andrurogerz do you need us to merge this for you?
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1130,14 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/145744
>From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 19 Jun 2025 16:17:33 +0100
Subject: [PATCH 1/5] [lldb][darwin] force BuiltinHeadersInSystemModules t
https://github.com/charles-zablit approved this pull request.
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144913
>From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 19 Jun 2025 16:17:33 +0100
Subject: [PATCH 1/2] [lldb][darwin] force BuiltinHeadersInSystemModules t
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/144731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first;
}
+ /// Returns \c true if `BasenameRange` is empty.
+ bool isBasenameEmpty() const {
+return BasenameRange.first == BasenameRange.second;
charles-zab
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 01/13] [lldb] upgrade HandleFrameFormatVariable callees t
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first;
}
+ /// Returns \c true if `BasenameRange` is empty.
+ bool isBasenameEmpty() const {
+return BasenameRange.first == BasenameRange.second;
charles-zab
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 01/12] [lldb] upgrade HandleFrameFormatVariable callees t
@@ -236,199 +236,158 @@ static bool PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
return true;
}
-static std::optional
-GetDemangledBasename(const SymbolContext &sc) {
+static llvm::Expected>
+GetAndValidateInfo(const SymbolContext &sc) {
Mangled mangled = sc.GetPo
charles-zablit wrote:
I only get one test failures when running the `check-lldb-api` target:
`commands/platform/sdk/TestPlatformSDK.py` but it also happens on the main
branch, so there's probably something wrong with the SDK configuration on my
system.
https://github.com/llvm/llvm-project/pul
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 01/10] [lldb] upgrade HandleFrameFormatVariable callees t
@@ -236,199 +236,158 @@ static bool PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
return true;
}
-static std::optional
-GetDemangledBasename(const SymbolContext &sc) {
+static llvm::Expected>
+GetAndValidateInfo(const SymbolContext &sc) {
Mangled mangled = sc.GetPo
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/8] [lldb] upgrade HandleFrameFormatVariable callees to
@@ -2008,38 +1979,54 @@ bool CPlusPlusLanguage::HandleFrameFormatVariable(
return true;
}
case FormatEntity::Entry::Type::FunctionReturnRight: {
-std::optional return_rhs = GetDemangledReturnTypeRHS(sc);
-if (!return_rhs)
+auto return_rhs_or_err = GetDemangl
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/9] [lldb] upgrade HandleFrameFormatVariable callees to
@@ -236,199 +236,156 @@ static bool PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
return true;
}
-static std::optional
-GetDemangledBasename(const SymbolContext &sc) {
+static llvm::Expected>
+GetAndValidateInfo(const SymbolContext &sc) {
Mangled mangled = sc.GetPo
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/7] [lldb] upgrade HandleFrameFormatVariable callees to
@@ -236,199 +236,156 @@ static bool PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
return true;
}
-static std::optional
-GetDemangledBasename(const SymbolContext &sc) {
+static llvm::Expected>
+GetAndValidateInfo(const SymbolContext &sc) {
Mangled mangled = sc.GetPo
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/6] [lldb] upgrade HandleFrameFormatVariable callees to
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/144913
`SDKSupportsBuiltinModules` always returns true on newer versions of Darwin
based OS. The only way for this call to return `false` would be to have a
version mismatch between lldb and the SDK (recent lld
charles-zablit wrote:
> I think we should wait before the following PR gets merged before merging, in
> order to use the new `has` methods.
Done ✅
https://github.com/llvm/llvm-project/pull/144731
___
lldb-commits mailing list
lldb-commits@lists.llv
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/5] [lldb] upgrade HandleFrameFormatVariable callees to
charles-zablit wrote:
I think we should wait before the following PR gets merged before merging, in
order to use the new `has` methods.
- https://github.com/llvm/llvm-project/pull/144549
https://github.com/llvm/llvm-project/pull/144731
___
lldb-commi
@@ -236,199 +236,141 @@ static bool PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
return true;
}
-static std::optional
-GetDemangledBasename(const SymbolContext &sc) {
+static llvm::Expected>
+GetAndValidateInfo(const SymbolContext &sc) {
Mangled mangled = sc.GetPo
@@ -1954,32 +1896,41 @@ bool CPlusPlusLanguage::HandleFrameFormatVariable(
FormatEntity::Entry::Type type, Stream &s) {
switch (type) {
case FormatEntity::Entry::Type::FunctionScope: {
-std::optional scope = GetDemangledScope(sc);
-if (!scope)
+auto scope_or
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From fdff64cca23ab113c80ed431949d7a58bdedb8c7 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/4] [lldb] upgrade HandleFrameFormatVariable callees to
@@ -236,199 +236,140 @@ static bool PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
return true;
}
-static std::optional
-GetDemangledBasename(const SymbolContext &sc) {
+static llvm::Expected>
+GetAndValidateInfo(const SymbolContext &sc) {
Mangled mangled = sc.GetPo
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From fdff64cca23ab113c80ed431949d7a58bdedb8c7 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/3] [lldb] upgrade HandleFrameFormatVariable callees to
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From fdff64cca23ab113c80ed431949d7a58bdedb8c7 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 1/2] [lldb] upgrade HandleFrameFormatVariable callees to
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/144731
Upgrade the callees of `HandleFrameFormatVariable`
(`GetDemangledTemplateArguments`, etc), to return a `llvm::Expected` instead of
an `std::optional`.
This patch also bundles the logic of validating the
@@ -982,7 +982,7 @@ lldb::LanguageType
SymbolFileDWARF::ParseLanguage(CompileUnit &comp_unit) {
return eLanguageTypeUnknown;
}
-XcodeSDK SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
+XcodeSDKPath SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
---
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144396
>From 0d773d07856aeb5434d748f439a2a1c00361ed20 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Mon, 16 Jun 2025 17:54:44 +0100
Subject: [PATCH 1/2] [lldb] move XcodeSDK's sysroot into a separate class
charles-zablit wrote:
Rationale: I am working on a patch
(https://github.com/swiftlang/llvm-project/pull/10710) which adds the
`hasArguments` method and I think it would be a good fit for upstream llvm as
well.
https://github.com/llvm/llvm-project/pull/144549
_
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/144549
Add `hasX` methods to all the attributes of `DemangledNameInfo`.
>From 876fa6243e267b427df95ac01855173b366ec1e8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 17 Jun 2025 16:38:45 +0100
Subject
charles-zablit wrote:
> Is there a follow-up PR already up?
Not yet, the original motivation is this issue on the Swift forums and more
specifically this comment:
https://forums.swift.org/t/lldb-crashes-during-vs-code-debug-session-on-windows-10/79902/10
`GetSDKPathFromDebugInfo` is not imple
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/144396
This PR introduces a new class (`XcodeSDKPath`) which holds both an `XcodeSDK`
and a `sysroot` for that SDK.
This motivation for this refactor is to eventually implement
`GetSDKPathFromDebugInfo` on `Pl
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/143930
>From 900a01df2892660602c837b0ad0335238337197e Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 12 Jun 2025 17:36:06 +0100
Subject: [PATCH 1/2] [lit] cleanup unused imports
---
lld/test/Unit/lit
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/143756
>From 0a4aee29aedd9079d03750c0757f4a2e93da5933 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 11 Jun 2025 18:43:13 +0100
Subject: [PATCH 1/2] [lldb] make lit use the same Python executable for
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/143183
When testing LLDB, we want to make sure to use the same Python as the one we
used to build it.
This patch used the CMake variable `Python3_ROOT_DIR` to set the `PYTHONHOME`
env variable in LLDB lit test
charles-zablit wrote:
> But if we're just going to consume it anyway, then keeping them as
> `CalculateNumChildrenIgnoringErrors` seems fine (though I would still prefer
> bubbling up errors, but that brings us back to the discussion about how we
> should be using `llvm::Expected`)
Agreed, th
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/142139
This patch removes a redundant check in DemangledNameInfo::hasBasename.
Since the start and end range are unsigned, if end > start, then end is always
greater than 0.
>From 738d0058769811d6f760f0a351a43
charles-zablit wrote:
Please feel free to merge when possible, as I do not have commit access yet.
https://github.com/llvm/llvm-project/pull/141790
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
charles-zablit wrote:
> The warning in question is `-Wmissing-field-initializers`, which is warning
> that in the unit test not all fields of this struct are explicitly
> initialized. Even if these fields are optional, I think this is the wrong way
> to address this: we should either update th
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/141790
>From 788cabe234336be7168996805f40da7f26fdbec9 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 28 May 2025 16:17:34 +0100
Subject: [PATCH 1/3] add explicit default initialization to DemangledName
charles-zablit wrote:
> Could you add the missing initializers to the test? I think you can just add
> a default value so you don't need to touch every test-case
Sorry about that, fixed it with explicit default values in
https://github.com/llvm/llvm-project/pull/141790.
https://github.com/llv
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/141790
https://github.com/llvm/llvm-project/pull/140762 introduces some compilation
warnings in `lldb/unittests/Core/MangledTest.cpp`. This patch adds explicit
default initialization to `DemangledNameInfo` to s
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/9] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/8] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/7] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/6] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/5] refactor demangler range tracking
---
lldb/include
charles-zablit wrote:
> But lets add a test to confirm that no plugin currently handles the new
> `FunctionPrefix` variable
Sorry I forgot about the test, will add it 👍
https://github.com/llvm/llvm-project/pull/140762
___
lldb-commits mailing list
@@ -6,7 +6,7 @@ add_lldb_unittest(LLDBCoreTests
DumpDataExtractorTest.cpp
DumpRegisterInfoTest.cpp
FormatEntityTest.cpp
- MangledTest.cpp
+ ItaniumMangledTest.cpp
charles-zablit wrote:
The rename was to separate the Swift tests from the Itanium tests.
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
@@ -88,6 +88,7 @@ struct Entry {
FunctionNameWithArgs,
FunctionNameNoArgs,
FunctionMangledName,
+FunctionPrefix,
charles-zablit wrote:
Fixed, thanks 👍
https://github.com/llvm/llvm-project/pull/140762
__
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/4] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/140762
>From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 20 May 2025 17:45:20 +0100
Subject: [PATCH 1/2] refactor demangler range tracking
---
lldb/include
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/140762
This PR is a subset of the commits made in
https://github.com/swiftlang/llvm-project/pull/10710.
The most notable change is the addition of `PrefixRange` and `SuffixRange`
which are a catch-all to trac
@@ -270,10 +270,14 @@ class VectorTypeSyntheticFrontEnd : public
SyntheticChildrenFrontEnd {
}
llvm::Expected GetIndexOfChildWithName(ConstString name) override {
-const char *item_name = name.GetCString();
-uint32_t idx = ExtractIndexFromString(item_name);
-i
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/138297
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/138297
>From 8f62523c8ccece4a1c11af51ccf320b19b2ed013 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 2 May 2025 16:37:09 +0100
Subject: [PATCH 1/2] [lldb] Upgrade ExtractIndexFromString to use
llvm::E
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/138249
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -142,6 +142,7 @@ add_lldb_library(liblldb SHARED ${option_framework}
lldbValueObject
lldbVersion
${LLDB_ALL_PLUGINS}
+swiftCore
charles-zablit wrote:
You are correct, sorry about that. I opened the PR here:
https://github.com/llvm/llvm-proj
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/138249
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/138249
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/138297
This PR is in continuation of https://github.com/llvm/llvm-project/pull/136693.
It upgrades `ExtractIndexFromString` to use `llvm::Expected`.
Rate limit · GitHub
b
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/138249
When building LLDB on Windows with `build.ps1`, the following linker error
happens, especially after rebuilding incrementally. The error sometimes goes
away after deleting CMakeCache.txt, but that's not
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public
SyntheticChildrenFrontEnd {
GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib);
- size_t GetIndexOfChildWithName(ConstString name) override {
+ llvm::Expected GetIndexOfChildWithName(ConstString name) override
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1202,13 +1225,16 @@ lldb_private::formatters::Foundation1100::
m_data_64 = nullptr;
}
-size_t
-lldb_private::formatters::Foundation1100::
- NSDictionaryMSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) {
+llvm::Expected lldb_private::formatters::Foundation11
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public
SyntheticChildrenFrontEnd {
GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib);
- size_t GetIndexOfChildWithName(ConstString name) override {
+ llvm::Expected GetIndexOfChildWithName(ConstString name) override
1 - 100 of 125 matches
Mail list logo
