charles-zablit wrote:

> But if we're just going to consume it anyway, then keeping them as 
> `CalculateNumChildrenIgnoringErrors` seems fine (though I would still prefer 
> bubbling up errors, but that brings us back to the discussion about how we 
> should be using `llvm::Expected`)

Agreed, the current changes just feel like moving the logic out of 
`CalculateNumChildrenIgnoringErrors`.

https://github.com/llvm/llvm-project/pull/142607
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to