@@ -1873,6 +1873,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
tgs-sc wrote:
Addressed
https://github.com/llvm/llvm-project/pull/15412
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/152618
>From b1a41aa0b3f65b5c72190a19091de88965d4fd6a Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Thu, 7 Aug 2025 17:15:29 -0700
Subject: [PATCH] [NFC][lldb] Cleanup the ArchDefinitionEntry definitons.
This pat
https://github.com/tgs-sc updated
https://github.com/llvm/llvm-project/pull/154123
>From 407331b05499cdc1f232cc9e7e3990b38a3923b5 Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 8 Sep 2025 14:43:50 +0300
Subject: [PATCH] [lldb][DWARFASTParserClang] Added a check for the
specializati
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/157435
>From 528fbe2b518b586283ffa6ce93674dbf346687d7 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 8 Sep 2025 12:03:58 +
Subject: [PATCH 1/2] [lldb][test] Enable non-address bit WritePointerToMemo
@@ -1725,6 +1725,7 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
const dw_tag_t tag = die.Tag();
SymbolFileDWARF *dwarf = die.GetDWARF();
LanguageType cu_language = SymbolFileDWARF::GetLanguage(*die.GetCU());
+ ModuleSP module_sp = dwarf->GetObj
@@ -599,6 +599,39 @@ TEST_F(DWARFASTParserClangTests,
TestDefaultTemplateParamParsing) {
}
}
+TEST_F(DWARFASTParserClangTests, TestSpecDeclExistsError) {
+ // Tests checking error if ClassTemplateSpecializationDecl already exists.
+ auto BufferOrError = llvm::MemoryBuffer
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
In this commit:
9c8e71644227 [lldb] Make StackID call Fix{Code,Data} pointers (#152796)
We made StackID keep track of the CFA without any pointer metadata in it. This
is necessary when c
@@ -0,0 +1,10 @@
+# REQUIRES: target=riscv32-{{.*}}
+
+# RUN: %lldb -b -o "disassemble -b -n main" %p/Inputs/riscv_xqci.out |
FileCheck %s
+
+# CHECK: 051f 0058 qc.e.li a0, 0x58
+# CHECK: 1516 qc.extu a0, a0, 0x6, 0x0
DavidSpickett wrote:
Mayb
https://github.com/tgs-sc updated
https://github.com/llvm/llvm-project/pull/154123
>From f86f3acf76227f618c36147c260ae5fb72fc9e80 Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 18 Aug 2025 17:29:01 +0300
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Added a check for the
special
dsandersllvm wrote:
> > Some targets like PowerPC store their
>
> Is there some text missing here?
Oops, fixed it.
> Do we know what vector extension s390x/SystemZ has and what order it uses?
I don't know but I've found
https://github.com/bytecodealliance/wasmtime/issues/4566 so @uweigand mi
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/157503
>From ec45d323014b15ce7a960fc519ef3782820a44d2 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 8 Sep 2025 09:05:15 -0700
Subject: [PATCH] [lldb-mcp] Auto connect to the first running lldb mcp
instance.
https://github.com/dsandersllvm edited
https://github.com/llvm/llvm-project/pull/157198
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/156803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dsandersllvm closed
https://github.com/llvm/llvm-project/pull/157196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tgs-sc wrote:
Seems like problem is in `GetBuiltinTypeForDWARFEncodingAndBitSize` where we
ignore type_name for DW_ATE_float. I think that we should take into account
type_name there.
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits
@@ -51,41 +46,28 @@ class StackID {
void Dump(Stream *s);
- // Operators
- const StackID &operator=(const StackID &rhs) {
-if (this != &rhs) {
- m_pc = rhs.m_pc;
- m_cfa = rhs.m_cfa;
- m_symbol_scope = rhs.m_symbol_scope;
-}
-return *this;
- }
clayborg wrote:
> I think this makes sense.
>
> Out of curiosity, what does clang-format do to the formatting?
It will complain or try to reformat. This allows lines to exceed the column
limit and also won't reformat any spacing.
https://github.com/llvm/llvm-project/pull/152618
__
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Due to a fallback in GDBRemoteCommunicationClient.cpp, on Linux we will assume
a PID of 1 if the remote does not respond in some way that tells us the real
PID.
So if PID 1 happened to be a process t
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/157474
`INSERT BEFORE` keyword is not supported in current versions gold and mold
linkers. Since we cannot confirm accurately what linker and version is
available on the system and when it will be supported. We test
Michael137 wrote:
> @Michael137, probably we should return finding and adding specialization in
> DWARFASTParserClang.cpp?
That would be equivalent to the way your current version handles this right? I
don't see how that would change anything.
I now realize this is trickier than expected. E.g
@@ -327,6 +366,11 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
std::unique_lock lock(dap_sessions_mutex);
dap_sessions.erase(&loop);
std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock));
+
+ // St
https://github.com/tgs-sc updated
https://github.com/llvm/llvm-project/pull/154123
>From cc0df387c22a7be4539707ecf4e20713e65d4b06 Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 8 Sep 2025 14:43:50 +0300
Subject: [PATCH] [lldb][DWARFASTParserClang] Added a check for the
specializati
https://github.com/Michael137 auto_merge_disabled
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/133078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/157503
This improves the flow by automatically connecting to an exisitng lldb
instance, if one is found.
Future improvements include:
* Launching a binary if an instance isn't detected.
* Multiplexing if multiple inst
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/133078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan converted_to_draft
https://github.com/llvm/llvm-project/pull/157498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/157498
In this commit:
9c8e71644227 [lldb] Make StackID call Fix{Code,Data} pointers (#152796)
We made StackID keep track of the CFA without any pointer metadata in it. This
is necessary when comparing two Sta
Nerixyz wrote:
> Why can't the native plugin use `PDB_DataKind::ObjectPtr`?
It's something DIA determines - in
[`IDiaSymbol::get_dataKind`](https://learn.microsoft.com/en-us/visualstudio/debugger/debug-interface-access/idiasymbol-get-datakind?view=vs-2022).
The symbol information we have is th
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/157483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> As far as I know, there isn't anything in the debug info that says "this
> variable is the this pointer" other than the name/type of a variable and the
> type of the function.
How does the DIA PDB plugin do it then? Why can't the native plugin use
`PDB_DataKind::ObjectPtr`
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/157493
After parsing blocks in a function, the blocks should be marked as parsed for
them to be dumped (see
[Function::Dump](https://github.com/llvm/llvm-project/blob/e6aefbec782dbb57f72eb0ae399ed944fe49db2e/lldb/sour
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/157483
>From 668e90948beabe437ea283b84ae0ffc9ea7c4a78 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 8 Sep 2025 07:43:38 -0700
Subject: [PATCH 1/2] [lldb][NFC] Fix style issues with StackID
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/157432
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-09-08T15:20:15Z
New Revision: b45f1fb377636a34c01e34b89341c97d19975554
URL:
https://github.com/llvm/llvm-project/commit/b45f1fb377636a34c01e34b89341c97d19975554
DIFF:
https://github.com/llvm/llvm-project/commit/b45f1fb377636a34c01e34b89341c97d19975554.diff
LOG
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/155485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// Try to find an existing specialization with these template arguments and
+//
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/157483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
thanks!
https://github.com/llvm/llvm-project/pull/157150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
Some comments were "suffixed" to member variable declarations; these are moved
to before the variable.
Some constructors and operators were just defaulted and not necessary.
Some comment
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/157483
Some comments were "suffixed" to member variable declarations; these are moved
to before the variable.
Some constructors and operators were just defaulted and not necessary.
Some comments dividing the c
@@ -1725,6 +1725,7 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
const dw_tag_t tag = die.Tag();
SymbolFileDWARF *dwarf = die.GetDWARF();
LanguageType cu_language = SymbolFileDWARF::GetLanguage(*die.GetCU());
+ ModuleSP module_sp = dwarf->GetObj
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/157432
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/155274
>From 57697a66cfdddf2028c7260f1ce61ecacc550d00 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 25 Aug 2025 17:15:36 +
Subject: [PATCH 01/64] Add AArch64 support to the premerge tests
---
.github/wo
DavidSpickett wrote:
I'll try it but I have a suspicion we have code that says "anything on
localhost must be the host machine".
https://github.com/llvm/llvm-project/pull/157432
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
`INSERT BEFORE` keyword is not supported in current versions gold and mold
linkers. Since we cannot confirm accurately what linker and version is
available on the system and when it will be supported. We test
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/157432
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> would runCmd("platform select remote-linux") have the same effect?
This does work.
@tstellar can you confirm that this PR fixes the test for you?
https://github.com/llvm/llvm-project/pull/157432
___
lldb-commits mailing list
ll
Author: David Spickett
Date: 2025-09-08T12:39:07Z
New Revision: bf51a4df728fb5386b0305ce05353cf7e3eb3f01
URL:
https://github.com/llvm/llvm-project/commit/bf51a4df728fb5386b0305ce05353cf7e3eb3f01
DIFF:
https://github.com/llvm/llvm-project/commit/bf51a4df728fb5386b0305ce05353cf7e3eb3f01.diff
LOG
Author: David Spickett
Date: 2025-09-08T13:58:40Z
New Revision: d2e153981e62fb2ea781ef456ff744f9893e0733
URL:
https://github.com/llvm/llvm-project/commit/d2e153981e62fb2ea781ef456ff744f9893e0733
DIFF:
https://github.com/llvm/llvm-project/commit/d2e153981e62fb2ea781ef456ff744f9893e0733.diff
LOG
labath wrote:
> I'll try it but I have a suspicion we have code that says "anything on
> localhost must be the host machine".
I hope we don't. The code I'm targetting is in
TargetList::CreateTargetInternal, which gives preference to the selected
platform.
https://github.com/llvm/llvm-project
@@ -1593,6 +1620,13 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec
&arch,
features_str += "+a,+m,";
}
+ llvm::StringRef additional_features = arch.GetDisassemblyFeatures();
+ // Prepend the additional_features if it's not already in the features_str to
+ // a
@@ -1284,6 +1285,54 @@
ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data,
return error;
}
+void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length,
+ ArchSpec &arch_spec) {
+ lldb::off
@@ -617,6 +617,13 @@ void ArchSpec::SetFlags(const std::string &elf_abi) {
SetFlags(flag);
}
+void ArchSpec::SetDisassemblyFeatures(std::string additional_features) {
DavidSpickett wrote:
This name is misleading. Set implies overwrite.
`AddDisassemblyFeatu
@@ -1446,6 +1446,33 @@ bool
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
return InstrDesc.isAuthenticated() || IsBrkC47x;
}
+void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef
additional_features,
+std::string &
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/147990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1446,6 +1446,33 @@ bool
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
return InstrDesc.isAuthenticated() || IsBrkC47x;
}
+void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef
additional_features,
DavidSpickett wrote:
If this is only cal
@@ -1446,6 +1446,33 @@ bool
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
return InstrDesc.isAuthenticated() || IsBrkC47x;
}
+void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef
additional_features,
+std::string &
Michael137 wrote:
Based on the test failure in `TestCppTemplateArguments.py` maybe we need to
return the `ClassTemplateDeclSpecialization` that we found, instead of
returning `nullptr`. We would create a new `TypeSP` for it, but that shouldn't
be an issue i think
https://github.com/llvm/llvm-
@@ -0,0 +1,10 @@
+# REQUIRES: target=riscv32-{{.*}}
+
+# RUN: %lldb -b -o "disassemble -b -n main" %p/Inputs/riscv_xqci.out |
FileCheck %s
+
+# CHECK: 051f 0058 qc.e.li a0, 0x58
+# CHECK: 1516 qc.extu a0, a0, 0x6, 0x0
DavidSpickett wrote:
Also
DavidSpickett wrote:
As in:
obj2yaml the file you have
yaml2obj and make the test work
cut bits out of the yaml
repeat until it's as small as you can reasonably get it
https://github.com/llvm/llvm-project/pull/147990
@@ -1446,6 +1446,33 @@ bool
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
return InstrDesc.isAuthenticated() || IsBrkC47x;
}
+void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef
additional_features,
+std::string &
@@ -1284,6 +1285,54 @@
ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data,
return error;
}
+void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length,
DavidSpickett wrote:
`const DataExtractor &data` if you can
@@ -1593,6 +1620,13 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec
&arch,
features_str += "+a,+m,";
}
+ llvm::StringRef additional_features = arch.GetDisassemblyFeatures();
+ // Prepend the additional_features if it's not already in the features_str to
+ // a
@@ -0,0 +1,10 @@
+# REQUIRES: target=riscv32-{{.*}}
+
+# RUN: %lldb -b -o "disassemble -b -n main" %p/Inputs/riscv_xqci.out |
FileCheck %s
+
+# CHECK: 051f 0058 qc.e.li a0, 0x58
+# CHECK: 1516 qc.extu a0, a0, 0x6, 0x0
+
+# RUN: %lldb -b -o "disassemble -b -n ma
@@ -0,0 +1,10 @@
+# REQUIRES: target=riscv32-{{.*}}
+
+# RUN: %lldb -b -o "disassemble -b -n main" %p/Inputs/riscv_xqci.out |
FileCheck %s
DavidSpickett wrote:
There is also a setting:
```
target.disassembly-features -- Specify additional CPU features for
dis
https://github.com/tgs-sc deleted
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1873,6 +1873,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
Michael137 wrote:
lets move the check before we call `CreateClassTemplat
@@ -1676,6 +1676,13 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ // Special
C0rn3j wrote:
Replacing `sanity` with `sound`, as in `sound of mind`, a *direct synonym* with
the exact same connotation, seems like it'd do more harm than good.
https://github.com/user-attachments/assets/28533e29-d9a7-42c4-a4dd-cedb03ad4a22";
/>
https://github.com/llvm/llvm-project/pull/156
@@ -1676,6 +1676,13 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ // Special
https://github.com/tgs-sc updated
https://github.com/llvm/llvm-project/pull/154123
>From 795c01cbfeb6c92c27d674970db938528fd25a56 Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 8 Sep 2025 14:43:50 +0300
Subject: [PATCH] [lldb][DWARFASTParserClang] Added a check for the
specializati
https://github.com/tgs-sc updated
https://github.com/llvm/llvm-project/pull/154123
>From f076aea3116c72d8c3bdf2c8e5b151b0df73036a Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 8 Sep 2025 14:43:50 +0300
Subject: [PATCH] [lldb][DWARFASTParserClang] Added a check for the
specializati
Michael137 wrote:
> @Michael137, do you think that this PR(#154134) is still needed?
I'll comment on that PR
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -1676,6 +1676,13 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ // Special
@@ -1873,6 +1873,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+if (!class_specialization_decl) {
+ if (log) {
+dwarf->GetObjectFile()
Michael137 wrote:
friendly ping
https://github.com/llvm/llvm-project/pull/155485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1873,6 +1873,19 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// If we got nullptr, then such specialization already exists.
Mic
@@ -1676,6 +1676,14 @@ TypeSystemClang::CreateClassTemplateSpecializationDecl(
class_template_specialization_decl->setInstantiationOf(class_template_decl);
class_template_specialization_decl->setTemplateArgs(
TemplateArgumentList::CreateCopy(ast, args));
+ void *Inse
@@ -1873,6 +1873,18 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+if (!class_specialization_decl) {
+ if (log) {
+dwarf->GetObjectFile()
@@ -1873,6 +1873,19 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// If we got nullptr, then such specialization already exists.
tgs
tgs-sc wrote:
Does this patch look ok now?
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tgs-sc updated
https://github.com/llvm/llvm-project/pull/154123
>From a2390655ad8a77ef9f1087e24089e36d8925e604 Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 18 Aug 2025 17:29:01 +0300
Subject: [PATCH 1/3] [lldb][DWARFASTParserClang] Added a check for the
special
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// Try to find an existing specialization with these template arguments and
+//
@@ -599,6 +599,39 @@ TEST_F(DWARFASTParserClangTests,
TestDefaultTemplateParamParsing) {
}
}
+TEST_F(DWARFASTParserClangTests, TestSpecDeclExistsError) {
+ // Tests checking error if ClassTemplateSpecializationDecl already exists.
+ auto BufferOrError = llvm::MemoryBuffer
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// Try to find an existing specialization with these template arguments and
+//
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
clang_type =
m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+// Try to find an existing specialization with these template arguments and
+//
@@ -2125,9 +2125,9 @@ bool DWARFASTParserClang::ParseTemplateDIE(
if (tag == DW_TAG_template_value_parameter && uval64_valid) {
if (auto value = MakeAPValue(ast, clang_type, uval64)) {
template_param_infos.InsertArg(
- name, clang::TemplateA
@@ -48,7 +48,7 @@ int main() {
// COMMON-SAME: templateParams: ![[PARAM:[0-9]+]]
// COMMON: ![[PARAM]] = !{![[TEMPL_TYPE_PARAM:[0-9]+]]}
// GDB: ![[TEMPL_TYPE_PARAM]] = !DITemplateTypeParameter(name: "T",
type: ![[BAR_INT_TY]])
-// LLDB: