================
@@ -617,6 +617,13 @@ void ArchSpec::SetFlags(const std::string &elf_abi) {
   SetFlags(flag);
 }
 
+void ArchSpec::SetDisassemblyFeatures(std::string additional_features) {
----------------
DavidSpickett wrote:

This name is misleading. Set implies overwrite.

`AddDisassemblyFeatures` allows you to be vague about how it's added.

Also, do you ever call this with more than one feature? I don't think so and if 
so, make all this singular so that's clear.

https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to