labath wrote:
I'm not entirely comfortable with putting the (obviously c++ specific) helper
function into the DataFormatters) library. There's no reason to call this from
outside the c++ language plugin, right? What would you say to putting this into
some header inside the plugin (or creating
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/146950
>From 155c6ee3d65d33de5640cfc961ebcb4cbb3ddfbc Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Wed, 2 Jul 2025 23:29:26 +0300
Subject: [PATCH] [lldb-dap] Add external terminal support
---
.../test/tools/
UltimateForce21 wrote:
@JDevlieghere @adrian-prantl I have created the [PR
#144238](https://github.com/llvm/llvm-project/pull/144238) dependent Rich
Disassembler Annotations PR.
https://github.com/llvm/llvm-project/pull/147460
___
lldb-commits mailin
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/UltimateForce21 created
https://github.com/llvm/llvm-project/pull/147460
This PR builds upon the functionality introduced in [PR
#144238](https://github.com/llvm/llvm-project/pull/144238), which adds support
for annotating disassembly output with DWARF variable locations.
T
https://github.com/UltimateForce21 deleted
https://github.com/llvm/llvm-project/pull/144238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/UltimateForce21 edited
https://github.com/llvm/llvm-project/pull/144238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,6 +54,38 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
b10902118 wrote:
Oh thanks you make it clear. This fix actually follows kernel's 64bit logic. I
wrongly mentioned compat_ptrace, which is for 32bit tracer use old HBP commands.
https://github.com/llvm/llvm-project/pull/147198
___
lldb-commits mailing
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/147438
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/146950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/146950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -242,6 +242,12 @@ struct Configuration {
std::string platformName;
};
+enum Console : unsigned {
+ eInternalConsole,
+ eIntegratedTerminal,
+ eExternalTerminal
+};
ashgti wrote:
I think the naming convention in lldb is that these should be:
```cpp
en
@@ -23,9 +23,10 @@ namespace lldb_dap {
/// Launch request; value of command field is 'launch'.
Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const
{
// Validate that we have a well formed launch request.
- if (!arguments.launchCommands.empty() &&
https://github.com/ashgti approved this pull request.
Overall, looks good to me with a few questions/style nits.
https://github.com/llvm/llvm-project/pull/146950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -528,7 +528,23 @@
"runInTerminal": {
"type": "boolean",
"description": "Launch the program inside an integrated
terminal in the IDE. Useful for debugging interactive command line programs",
-"default": false
+
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This should improve synchronizing the MainLoopWindows monitor thread with the
main loop state.
This uses the `m_ready` and `m_event` event handles to manage when the Monitor
thread continues and adds new tes
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/147438
>From 8a60d1cbd3d75e640d5efddf23c717278e7d6b80 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 7 Jul 2025 17:31:25 -0700
Subject: [PATCH] [lldb] Improving synchronization of MainLoopWindows.
This should
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/147438
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/147438
This should improve synchronizing the MainLoopWindows monitor thread with the
main loop state.
This uses the `m_ready` and `m_event` event handles to manage when the Monitor
thread continues and adds new tests
JDevlieghere wrote:
> How should a proper debugger shutdown sequence look like?
>
> 1. Release all `SBModule` pointers.
> 2. Call `SBDebugger::MemoryPressureDetected`.
> 3. Call `SBDebugger::Destroy`.
Ideally, `SBDebugger::Destroy` would clean up all the modules in the module
cache. You say we
asavonic wrote:
> > However, when lldb is used as a library, we need a way to manage opened
> > modules to avoid problems with file locks (on some systems) for modules
> > that we no longer need.
>
> Can you give a concrete example? This seems like its own issue that should be
> solved rather
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147355
>From 78533da4cfb0c5d5f9f142cce19609810e630dd7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 18:36:57 +0100
Subject: [PATCH 1/2] [lldb][test] Combine libstdc++ and libc++ std::string
test
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/147396
Iteration by index is not thread-safe with PathMapingList's design. Instead, we
can expose a `ForEach` method that grabs the PathMappingList's lock before the
callback.
There is a potential pitfall here wher
https://github.com/dmpots closed
https://github.com/llvm/llvm-project/pull/146166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: qxy11
Date: 2025-07-07T12:01:22-07:00
New Revision: 7bd06c41a344fd107a3a300c8c20d78cbc34db35
URL:
https://github.com/llvm/llvm-project/commit/7bd06c41a344fd107a3a300c8c20d78cbc34db35
DIFF:
https://github.com/llvm/llvm-project/commit/7bd06c41a344fd107a3a300c8c20d78cbc34db35.diff
LOG: De
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/146950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -236,6 +236,7 @@ contain the following key/value pairs:
| **env** | dictionary | | Environment
variables to set when launching the program. The format of each environment
variable string is "VAR=VALUE" for environment variables with values or j
@@ -236,6 +236,7 @@ contain the following key/value pairs:
| **env** | dictionary | | Environment
variables to set when launching the program. The format of each environment
variable string is "VAR=VALUE" for environment variables with values or j
@@ -242,6 +242,8 @@ struct Configuration {
std::string platformName;
};
+enum Terminal : unsigned { eConsole, eIntegrated, eExternal };
ashgti wrote:
I believe the format for these should be `eTerminalConsole`,
`eTerminalIntegrated`, `eTerminalExternal`.
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/146950
>From d0b98039440d4cca76db55e03914b1e4d452ebbb Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Wed, 2 Jul 2025 23:29:26 +0300
Subject: [PATCH] [lldb-dap] Add external terminal support
---
.../test/tools/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/146773
>From 2674e5af817e1e6b06521c7b7f39b23150aed747 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 2 Jul 2025 13:05:31 -0700
Subject: [PATCH 1/2] [lldb-dap] Improving 'variables' hover requests.
This partial
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147253
>From e592d39c751480838ed90fcaa2b247e96b5bab59 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 6 Jul 2025 09:58:02 +0100
Subject: [PATCH 1/4] [lldb][test] Combine libstdc++ and libc++ std::variant
tes
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Currently when we explicitly dereference a std::shared_ptr, both the libstdc++
and libc++ formatters will cast the type of the synthetic pointer child to
whatever the `std::shared_ptr::element_type` is ali
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/147340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
>From 44b7628d7d77d3c63001890cb678ee6ab85e8034 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:24:03 -0700
Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters
Thi
@@ -305,7 +305,7 @@
lldb_private::formatters::LibcxxSharedPtrSyntheticFrontEnd::Update() {
llvm::Expected
lldb_private::formatters::LibcxxSharedPtrSyntheticFrontEnd::
GetIndexOfChildWithName(ConstString name) {
- if (name == "__ptr_" || name == "pointer")
+ if (name == "
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/147340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
```
File
"/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/utils/lit/lit/Test.py",
line 418, in getUnsupportedFeatures
raise ValueError("Error in UNSUPPORTED list:\n%s" % str(e))
ValueError: Error in UNSUPPORTED list:
couldn't parse text: '*'
in expression:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147253
>From 30e4862aceee140084e10610b0ac2e7962d195dd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 6 Jul 2025 09:58:02 +0100
Subject: [PATCH 1/3] [lldb][test] Combine libstdc++ and libc++ std::variant
tes
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/145621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> However, when lldb is used as a library, we need a way to manage opened
> modules to avoid problems with file locks (on some systems) for modules that
> we no longer need.
Can you give a concrete example? This seems like its own issue that should be
solved rather than wo
@@ -44,26 +163,20 @@ MainLoopWindows::~MainLoopWindows() {
}
llvm::Expected MainLoopWindows::Poll() {
- std::vector events;
+ std::vector events;
events.reserve(m_read_fds.size() + 1);
- for (auto &[fd, info] : m_read_fds) {
-int result = WSAEventSelect(fd, info.even
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
>From 69009b34c7bfa0cb39f5ff805b213fe0164a2193 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:24:03 -0700
Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters
Thi
@@ -7248,6 +7248,12 @@ QualType
TreeTransform::TransformDependentBitIntType(
return Result;
}
+template
+QualType TreeTransform::TransformPredefinedSugarType(
+TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) {
+ llvm_unreachable("This type does not need to be transfor
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/143653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -7248,6 +7248,12 @@ QualType
TreeTransform::TransformDependentBitIntType(
return Result;
}
+template
+QualType TreeTransform::TransformPredefinedSugarType(
+TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) {
+ llvm_unreachable("This type does not need to be transfor
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
--
@@ -181,7 +181,17 @@ void EvaluateRequestHandler::operator()(
expression = dap.last_nonempty_var_expression;
else
dap.last_nonempty_var_expression = expression;
+} else {
+ // If this isn't a REPL context, trim leading pointer/reference
character
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/147340
None
>From dba291d4b0b5ac6e62cfc084340cc0524d15d51c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 14:45:59 +0100
Subject: [PATCH] [lldb][Formatters] Consistently unwrap pointer element_ty
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -7,64 +7,43 @@
//===--===//
#include "DAP.h"
-#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "ProtocolUtils.h"
#include "RequestHandler.h"
+using namespace lldb_dap::protocol;
namespace lld
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &,
DisassembledInstruction &,
llvm::json::Path);
llvm::json::Value toJSON(const DisassembledInstruction &);
+struct Module {
+ /// Unique identifier for the module.
+ std::string id;
+
+ /// A name of
@@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &,
DisassembledInstruction &,
llvm::json::Path);
llvm::json::Value toJSON(const DisassembledInstruction &);
+struct Module {
+ /// Unique identifier for the module.
+ std::string id;
+
+ /// A name of
@@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &,
DisassembledInstruction &,
llvm::json::Path);
llvm::json::Value toJSON(const DisassembledInstruction &);
+struct Module {
+ /// Unique identifier for the module.
+ std::string id;
+
+ /// A name of
@@ -41,6 +41,21 @@ struct CapabilitiesEventBody {
};
llvm::json::Value toJSON(const CapabilitiesEventBody &);
+/// The event indicates that some information about a module has changed.
+struct ModuleEventBody {
+ enum Reason : unsigned { eReasonNew, eReasonChanged, eReasonRem
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
+SignedSiz
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -1002,14 +1002,14 @@ RValue CodeGenFunction::EmitCoroutineIntrinsic(const
CallExpr *E,
}
case llvm::Intrinsic::coro_size: {
auto &Context = getContext();
-CanQualType SizeTy = Context.getSizeType();
+CanQualType SizeTy = Context.getCanonicalSizeType();
-
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -7248,6 +7250,22 @@ QualType
TreeTransform::TransformDependentBitIntType(
return Result;
}
+template
+QualType TreeTransform::TransformPredefinedSugarType(
+TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) {
+ const PredefinedSugarType *EIT = TL.getTypePtr();
+ Qua
@@ -7248,6 +7248,12 @@ QualType
TreeTransform::TransformDependentBitIntType(
return Result;
}
+template
+QualType TreeTransform::TransformPredefinedSugarType(
+TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) {
+ llvm_unreachable("This type does not need to be transfor
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
+SignedSiz
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
+SignedSiz
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
--
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
+SignedSiz
@@ -7248,6 +7248,12 @@ QualType
TreeTransform::TransformDependentBitIntType(
return Result;
}
+template
+QualType TreeTransform::TransformPredefinedSugarType(
+TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) {
+ llvm_unreachable("This type does not need to be transfor
@@ -320,6 +320,92 @@ bool
clang::analyze_format_string::ParseUTF8InvalidSpecifier(
// Methods on ArgType.
//===--===//
+static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT,
+
@@ -721,7 +721,8 @@ static bool matchesStlAllocatorFn(const Decl *D, const
ASTContext &Ctx) {
(MD->getNumParams() != 1 && MD->getNumParams() != 2))
return false;
- if (MD->parameters()[0]->getType().getCanonicalType() != Ctx.getSizeType())
+ if (MD->parameters()[0
@@ -5613,3 +5613,16 @@
HLSLAttributedResourceType::findHandleTypeOnResource(const Type *RT) {
}
return nullptr;
}
+
+StringRef PredefinedSugarType::getName(Kind KD) {
+ switch (KD) {
+ case Kind::SizeT:
+return "__size_t";
+ case Kind::SignedSizeT:
+return "__si
@@ -696,11 +696,17 @@ void TypeLocWriter::VisitPipeTypeLoc(PipeTypeLoc TL) {
void TypeLocWriter::VisitBitIntTypeLoc(clang::BitIntTypeLoc TL) {
addSourceLocation(TL.getNameLoc());
}
+
erichkeane wrote:
Another unrelated change.
https://github.com/llvm/llvm-p
@@ -2595,8 +2595,12 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T)
const {
Align = static_cast(Width);
}
}
+
erichkeane wrote:
Unrelated change?
https://github.com/llvm/llvm-project/pull/143653
@@ -1002,14 +1002,14 @@ RValue CodeGenFunction::EmitCoroutineIntrinsic(const
CallExpr *E,
}
case llvm::Intrinsic::coro_size: {
auto &Context = getContext();
-CanQualType SizeTy = Context.getSizeType();
+CanQualType SizeTy = Context.getCanonicalSizeType();
-
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public
ExtQualsTypeCommonBase {
unsigned NumExpansions;
};
+ enum class PredefinedSugarKind {
+/// The "size_t" type.
+SizeT,
+
+/// The signed integer type corresponding to "size_t".
--
https://github.com/erichkeane commented:
I'm a little concerned about the semi-canonical nature of this type, requiring
the separate 'getCanonicalSizeType' esque functions, which should just be
either stored as a CanQualType or compared properly.
That said, for hte most part I like this change
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/143653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-07T14:28:19+01:00
New Revision: 9ebe6f9a1f9e3473166cd57282c9827df12416a3
URL:
https://github.com/llvm/llvm-project/commit/9ebe6f9a1f9e3473166cd57282c9827df12416a3
DIFF:
https://github.com/llvm/llvm-project/commit/9ebe6f9a1f9e3473166cd57282c9827df12416a3.diff
https://github.com/labath approved this pull request.
Cool. Thanks for looking into this.
https://github.com/llvm/llvm-project/pull/147283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/147283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/147283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> Looking up global variables is not completely ideal (can be slow and look up
> unrelated things). Would index_obj.GetValueAs**Signed**() == -1 work by any
> chance?
Actually after some more investigating it turns out the test was just flawed. A
default-constructed variant
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147283
>From be3eb2431b0649ce2730a4cf832dc474e262f49e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 12:40:37 +0100
Subject: [PATCH 1/3] [lldb][test] Fix libstdc++ std::variant formatter for
empt
asavonic wrote:
> Python code formatter, darker found issues in your code.
Fixed.
https://github.com/llvm/llvm-project/pull/147289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/asavonic updated
https://github.com/llvm/llvm-project/pull/147289
>From a01eb1943afb03d1dc9439e9ae8f3a01b8c15398 Mon Sep 17 00:00:00 2001
From: Andrew Savonichev
Date: Mon, 7 Jul 2025 17:33:50 +0900
Subject: [PATCH] [lldb] Clear ModuleList shared modules in SBDebugger::Clear
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/python_api/debugger/TestDebuggerAPI.py
``
View th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Andrew Savonichev (asavonic)
Changes
Shared modules are stored in a global `ModuleList` cache, and it is
intentionally leaked to avoid doing cleanup when lldb exits.
However, when lldb is used as a library, we need a way to manage opened m
https://github.com/asavonic created
https://github.com/llvm/llvm-project/pull/147289
Shared modules are stored in a global `ModuleList` cache, and it is
intentionally leaked to avoid doing cleanup when lldb exits.
However, when lldb is used as a library, we need a way to manage opened modules
https://github.com/labath commented:
Looking up global variables is not completely ideal (can be slow and look up
unrelated things). Would index_obj.GetValueAs**Signed**() == -1 work by any
chance?
https://github.com/llvm/llvm-project/pull/147283
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Instead of using the byte-size to make a guess at what the `std::variant_npos`
value is, just look it up in debug-info.
Unblocks https://github.com/llvm/llvm-project/pull/147253
---
Full diff: https://git
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147141
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-07T12:48:15+01:00
New Revision: e14e98290e71abe5d34b1d4724fde1b85b350547
URL:
https://github.com/llvm/llvm-project/commit/e14e98290e71abe5d34b1d4724fde1b85b350547
DIFF:
https://github.com/llvm/llvm-project/commit/e14e98290e71abe5d34b1d4724fde1b85b350547.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147283
>From be3eb2431b0649ce2730a4cf832dc474e262f49e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 12:40:37 +0100
Subject: [PATCH 1/2] [lldb][test] Fix libstdc++ std::variant formatter for
empt
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/147283
Instead of using the byte-size to make a guess at what the `std::variant_npos`
value is, just look it up in debug-info.
Unblocks https://github.com/llvm/llvm-project/pull/147253
>From be3eb2431b0649ce2730a4
@@ -447,7 +447,7 @@ llvm::json::Value CreateCompileUnit(lldb::SBCompileUnit
&unit);
llvm::json::Object CreateRunInTerminalReverseRequest(
llvm::StringRef program, const std::vector &args,
const llvm::StringMap &env, llvm::StringRef cwd,
-llvm::StringRef comm_file,
@@ -890,7 +890,7 @@ def request_launch(
args: Optional[list[str]] = None,
cwd: Optional[str] = None,
env: Optional[dict[str, str]] = None,
-stopOnEntry=False,
+stopOnEntry: Union[bool, str] = False,
da-viper wrote:
I ass
@@ -23,7 +23,7 @@ namespace lldb_dap {
/// Launch request; value of command field is 'launch'.
Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const
{
// Validate that we have a well formed launch request.
- if (!arguments.launchCommands.empty() &&
1 - 100 of 163 matches
Mail list logo
