================ @@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &, DisassembledInstruction &, llvm::json::Path); llvm::json::Value toJSON(const DisassembledInstruction &); +struct Module { + /// Unique identifier for the module. + std::string id; + + /// A name of the module. + std::string name; + + /// Logical full path to the module. The exact definition is implementation + /// defined, but usually this would be a full path to the on-disk file for the + /// module. + std::string path; + + /// True if the module is optimized. + std::optional<bool> isOptimized; + + /// True if the module is considered 'user code' by a debugger that supports + /// 'Just My Code'. + std::optional<bool> isUserCode; ---------------- ashgti wrote:
I don't think there is a meaningful distinct between `null` and `false` here, can this be `bool isOptional = false;` and only add it to the `toJSON` if its `true`? https://github.com/llvm/llvm-project/pull/146966 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits