================
@@ -23,7 +23,7 @@ namespace lldb_dap {
 /// Launch request; value of command field is 'launch'.
 Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const 
{
   // Validate that we have a well formed launch request.
-  if (!arguments.launchCommands.empty() && arguments.runInTerminal)
+  if (!arguments.launchCommands.empty() && arguments.terminal)
----------------
da-viper wrote:

```suggestion
  if (!arguments.launchCommands.empty() && arguments.terminal != 
Protocol::eConsole)
```
explicitly check if it not console.

https://github.com/llvm/llvm-project/pull/146950
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to