athierry-oct wrote:
@jimingham Thanks for the explanation!
@labath I've added some unit tests, let me know if you need something else
https://github.com/llvm/llvm-project/pull/144919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
https://github.com/athierry-oct updated
https://github.com/llvm/llvm-project/pull/144919
>From 89fb97755c2edc1f6b4858bccdd8285292a67a59 Mon Sep 17 00:00:00 2001
From: Adrien Thierry
Date: Thu, 3 Jul 2025 10:13:28 -0400
Subject: [PATCH] [lldb] Transfer events from previous listener when hijackin
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
The test lldb-unit::HostTests.exe/MainLoopTest/NoSpuriousPipeReads is flaky on
Windows.
Please fix it.
https://lab.llvm.org/buildbot/#/builders/211/builds/231
https://lab.llvm.org/buildbot/#/builders/197/builds/6659
https://github.com/llvm/llvm-project/pull/145621
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147031
>From afa00be16641075f71bb7ce15e568ecb3b126719 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 3 Jul 2025 15:41:44 +0100
Subject: [PATCH 1/4] [lldb][Formatter] Consolidate libstdc++ and libc++
unique_
@@ -1,7 +1,5 @@
CXX_SOURCES := main.cpp
-USE_LIBCPP := 1
-
# We need debug info tuning for lldb in order to emit the preferred name for
# std::string. See https://reviews.llvm.org/D145803.
CXXFLAGS_EXTRAS := -std=c++14 -glldb
Michael137 wrote:
```suggestion
@@ -1,7 +1,5 @@
CXX_SOURCES := main.cpp
-USE_LIBCPP := 1
-
# We need debug info tuning for lldb in order to emit the preferred name for
# std::string. See https://reviews.llvm.org/D145803.
CXXFLAGS_EXTRAS := -std=c++14 -glldb
Michael137 wrote:
We can probab
Michael137 wrote:
> Looks good modulo the failure in the libstdc++ version. The type name comes
> out different, presumably because libstdc++ doesn't contain the magic to
> print the template as std::string.
>
> Testing string name printing is not really relevant for the unique_ptr
> formatte
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147031
>From afa00be16641075f71bb7ce15e568ecb3b126719 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 3 Jul 2025 15:41:44 +0100
Subject: [PATCH 1/3] [lldb][Formatter] Consolidate libstdc++ and libc++
unique_
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/145033
>From ba8fcf4ef14e25b8a628b994988d6a67bdbea7df Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 19 Jun 2025 10:43:48 +
Subject: [PATCH 1/3] [lldb][AArch64] Add HWCAP3 to register field detectio
DavidSpickett wrote:
> And by searching that error message I found:
Hacking that to be DWARF64 gets more tests passing:
```
Total Discovered Tests: 33363
Skipped : 1 (0.00%)
Unsupported : 518 (1.55%)
Passed : 32696 (98.00%)
Expectedly Failed:31 (0.09%)
DavidSpickett wrote:
> Could use a test case.
But I too still want a targeted test case for this. Especially given that no
one is going to be running a DWARF64 buildbot any time soon.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits
DavidSpickett wrote:
DWARF64, with this PR branch:
```
Total Discovered Tests: 33363
Skipped : 1 (0.00%)
Unsupported : 518 (1.55%)
Passed : 32716 (98.06%)
Expectedly Failed:31 (0.09%)
Unresolved : 3 (0.01%)
Failed :94 (0.28%)
`
DavidSpickett wrote:
This is the relevant part of the standard, correct?
```
7.5.5 Classes and Forms
18 • stroffsetsptr
19 This is an offset into the .debug_str_offsets section
20 (DW_FORM_sec_offset). It consists of an offset from the beginning of the
21 .debug_str_offsets section to the begin
kuilpd wrote:
@labath @cmtice @jimingham @asl
This is a draft with some potential changes I'd like to discuss regarding how
to handle the type system of constant literals.
I'm also trying to demonstrate how they interact further with other values in a
binary addition node. A lot of the code is
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-04T15:31:47+01:00
New Revision: 32946eb124e87a58a94b55ee0a64d1d2265fc58d
URL:
https://github.com/llvm/llvm-project/commit/32946eb124e87a58a94b55ee0a64d1d2265fc58d
DIFF:
https://github.com/llvm/llvm-project/commit/32946eb124e87a58a94b55ee0a64d1d2265fc58d.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
A draft to discuss scalar literal node implementation
---
Patch is 26.08 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/147064.diff
8 Files Affected:
- (modified)
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/147064
A draft to discuss scalar literal node implementation
>From cf1f908360399ac51770d9fb7e1dac03eceab0e9 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Thu, 3 Jul 2025 19:34:17 +0500
Subject: [PATCH] [LLDB] *WIP*
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1077,7 +1077,8 @@ uint32_t DWARFUnit::GetHeaderByteSize() const { return
m_header.getSize(); }
std::optional
DWARFUnit::GetStringOffsetSectionItem(uint32_t index) const {
- lldb::offset_t offset = GetStrOffsetsBase() + index * 4;
+ lldb::offset_t offset =
+ GetStrO
https://github.com/labath commented:
Could use a test case.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
HemangGadhavi wrote:
@labath @DavidSpickett
Related to PR https://github.com/llvm/llvm-project/issues/135208
Please have review once. DW_AT_str_offsets_base was missing to handle for
DWARF64.
https://github.com/llvm/llvm-project/pull/147054
___
ll
HemangGadhavi wrote:
@DhruvSrivastavaX FYI
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Hemang Gadhavi (HemangGadhavi)
Changes
This PR is updating the string table offset (DW_AT_str_offsets_base which is
introduces in `DWARF5`) based on the DWARF format, as per the DWARF
specification, For the 32-bit DWARF format, each offset
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/147054
This PR is updating the string table offset (DW_AT_str_offsets_base which is
introduces in `DWARF5`) based on the DWARF format, as per the DWARF
specification, For the 32-bit DWARF format, each offset is
https://github.com/labath commented:
Looks good, but you should add a unit test for the moving functionality. You
know, things like: queue, some events, hijack them, make sure they're received
at the new listener, and vice versa.
https://github.com/llvm/llvm-project/pull/144919
___
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/147033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
Looks good modulo the failure in the libstdc++ version. The type name comes out
different, presumably because libstdc++ doesn't contain the magic to print the
template as std::string.
Testing string name printing is not really relevant for the unique_ptr
f
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
For the `__shared_owners_` we need to add `+1` to the count, but for
`__shared_weak_owners_` the value reflects the exact number of weak references.
---
Full diff: https://github.com/llvm/llvm-project/pull
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/147033
For the `__shared_owners_` we need to add `+1` to the count, but for
`__shared_weak_owners_` the value reflects the exact number of weak references.
>From 6700e8ba954d0ce29b8703ec35a992e93bf1dfdc Mon Sep 17
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
The libc++ test was a subset of the tests in libstdc++. This test moves the
libc++ test into `generic` and somne additional test-cases from `libstdc++`
(specifically the recursive unique_ptr case). It turn
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/147031
The libc++ test was a subset of the tests in libstdc++. This test moves the
libc++ test into `generic` and somne additional test-cases from `libstdc++`
(specifically the recursive unique_ptr case). It turns
kuilpd wrote:
Alright, thank you!
https://github.com/llvm/llvm-project/pull/146094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-04T09:32:21+01:00
New Revision: d74c9ef8370c9310452859ff876a2a5d8b8f7ad5
URL:
https://github.com/llvm/llvm-project/commit/d74c9ef8370c9310452859ff876a2a5d8b8f7ad5
DIFF:
https://github.com/llvm/llvm-project/commit/d74c9ef8370c9310452859ff876a2a5d8b8f7ad5.diff
labath wrote:
> > the request will be expression="char*foo", which won't evaluate correctly
> > in lldb.
>
> We could search starting from the back for the first occurrence of either "&"
> or "*". I think `llvm::StringRef::find_last_of()` does this.
That's rather specific to C. In Swift for i
labath wrote:
It cannot. However, the MCP connection is done locally (on the machine running
lldb). You could argue `@skipIfRemote` is still a good thing because remote
testing is not useful here (you could use the protocol to drive a remote debug
session, but for most purposes the two session
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/146909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> Looks good. Just noting I'm kind of surprised that these pointers have a
> weak_count of 1. I see it's a preexisting issue, and it may make sense if you
> know the implementation, but as a user, I'm surprised.
Yea the counts confused me a bit. I'll have a look at that separ
Author: Michael Buch
Date: 2025-07-04T09:18:24+01:00
New Revision: a89e232058a29260eb9bfe77b862715ce875f962
URL:
https://github.com/llvm/llvm-project/commit/a89e232058a29260eb9bfe77b862715ce875f962
DIFF:
https://github.com/llvm/llvm-project/commit/a89e232058a29260eb9bfe77b862715ce875f962.diff
labath wrote:
> This removes the need to pass flags (which is not a design decision I like
> but I didn't see many alternatives). @labath any opposition to putting
> everything in mem64?
I don't have an opinion on that. I'm not currently involved in minidumps.
What I am not excited about is t
https://github.com/DavidSpickett commented:
I agree with the change, FixAnyAddress uses whatever is the least destructive
fix.
Jonas should look over the core file bit, I don't know much about MachO.
https://github.com/llvm/llvm-project/pull/147011
_
@@ -44,6 +43,8 @@ def test_armv7_corefile(self):
self.assertTrue(exception.IsValid())
self.assertEqual(exception.GetValueAsUnsigned(), 0x3F5C)
+self.expect("x/4bx $sp-1", substrs=["0x000d", "0xff 0x00 0x01
0x02"])
DavidSpickett
https://github.com/labath approved this pull request.
Looks good. Just noting I'm kind of surprised that these pointers have a
weak_count of 1. I see it's a preexisting issue, and it may make sense if you
know the implementation, but as a user, I'm surprised.
https://github.com/llvm/llvm-proje
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
DavidSpickett wrote:
That's fine with me.
https://github.com/llvm/llvm-project/pull/138032
___
jasonmolenda wrote:
FTR armv7 has one of the few FixCodeAddress methods that actually clears the
low bits, because the low bit is sometimes used to indicate arm/thumb processor
state of functions.
https://github.com/llvm/llvm-project/pull/147011
___
jasonmolenda wrote:
I didn't have a solid way to test this except rely on the arm-ubuntu bot, so I
enhanced a random armv7 mach-o corefile creator tool I wrote ages ago to add a
memory segment, and try to read from an odd address to confirm that it behaves
correctly, but this test will only ru
jasonmolenda wrote:
I can't imagine which 32-bit arm hater made this kind of change originally.
https://github.com/llvm/llvm-project/pull/147011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Commands that take an address expression/address through the
OptionArgParser::ToAddress method, which has filtered this user-specified
address through one of the Process Fix methods to clear non-address
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/147011
>From bf1838f4676bab0f7c998d3dbb03b6b593103335 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 4 Jul 2025 00:11:30 -0700
Subject: [PATCH] [lldb] Pass address expression command args through
FixAnyA
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/147011
Commands that take an address expression/address through the
OptionArgParser::ToAddress method, which has filtered this user-specified
address through one of the Process Fix methods to clear non-addressabl
52 matches
Mail list logo
