https://github.com/labath commented:

Looks good modulo the failure in the libstdc++ version. The type name comes out 
different, presumably because libstdc++ doesn't contain the magic to print the 
template as std::string.

Testing string name printing is not really relevant for the unique_ptr 
formatter, so I'd delete the check from there. Testing that 
`SomeTemplate<std::string>` prints the right way is useful, but would be better 
of in the test for preferred name printing (if we don't do that already).

https://github.com/llvm/llvm-project/pull/147031
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to