https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/146356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-07-01T08:47:45+02:00
New Revision: 72b40f7c6437f63ea4d3ee5bbf45887f49cb0e20
URL:
https://github.com/llvm/llvm-project/commit/72b40f7c6437f63ea4d3ee5bbf45887f49cb0e20
DIFF:
https://github.com/llvm/llvm-project/commit/72b40f7c6437f63ea4d3ee5bbf45887f49cb0e20.diff
@@ -0,0 +1,86 @@
+//===--
DWARF64UnitTest.cpp=---===//
HemangGadhavi wrote:
Thanks @JDevlieghere
Updated
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH 1/4] [lldb][DWARF64] Enable support for DWARF64 format
han
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 0c0825263c3423a724a9d9253368332ebe0e7568 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
Author: Jason Molenda
Date: 2025-06-30T21:27:53-07:00
New Revision: e94c6091c93a72e9b81cf8d6394495d043b409d4
URL:
https://github.com/llvm/llvm-project/commit/e94c6091c93a72e9b81cf8d6394495d043b409d4
DIFF:
https://github.com/llvm/llvm-project/commit/e94c6091c93a72e9b81cf8d6394495d043b409d4.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/146460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/146460
>From a9b23cc16ca7b3a20ccc7c63e64f840fcbf7da9d Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 30 Jun 2025 20:26:40 -0700
Subject: [PATCH 1/2] [lldb][Mach-O] Fix several bugs in x86_64 Mach-O corefi
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/146460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -184,46 +184,32 @@ class RegisterContextDarwin_x86_64_Mach : public
RegisterContextDarwin_x86_64 {
SetError(GPRRegSet, Read, -1);
SetError(FPURegSet, Read, -1);
SetError(EXCRegSet, Read, -1);
-bool done = false;
-while (!done) {
+while (offset < da
chelcassanova wrote:
> If framework-header-fix.py already puts the header in the framework, why
> might we want to wholesale copy it into the framework beforehand?
I don't think the script and build infrastructure was actually putting
everything in the framework itself, just the staging area i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Avoid some of the work to disable/enable the statusline when the terminal
dimensions change.
---
Full diff: https://github.com/llvm/llvm-project/pull/146435.diff
2 Files Affected:
- (modified) ll
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/146435
Avoid some of the work to disable/enable the statusline when the terminal
dimensions change.
>From 73bffa08fe1b2946a81056636b505f93d0b787a8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 30 J
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
A build step needs to copy headers from the framework staging area to the
framework itself. This commit modifies the LLDB framework CMake module to do
this.
---
Full diff: https://github.com/llvm/
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/146425
A build step needs to copy headers from the framework staging area to the
framework itself. This commit modifies the LLDB framework CMake module to do
this.
>From b08afa816f4555e2075bd3637217e43b7ba86fa9
Author: Jonas Devlieghere
Date: 2025-06-30T13:50:32-07:00
New Revision: eb904e857af19abc2ea32ea3be455d96af6902f1
URL:
https://github.com/llvm/llvm-project/commit/eb904e857af19abc2ea32ea3be455d96af6902f1
DIFF:
https://github.com/llvm/llvm-project/commit/eb904e857af19abc2ea32ea3be455d96af6902f1.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/146132
>From e601025c14fb609635dc6a9adea5b1ae8b8e4540 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 27 Jun 2025 11:08:08 -0700
Subject: [PATCH 1/4] [lldb] Correctly restore the cursor column after re
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/145954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-06-30T14:25:11-04:00
New Revision: 5548f4d5ef6ab7192fe454a497af6f2cfe403339
URL:
https://github.com/llvm/llvm-project/commit/5548f4d5ef6ab7192fe454a497af6f2cfe403339
DIFF:
https://github.com/llvm/llvm-project/commit/5548f4d5ef6ab7192fe454a497af6f2cfe403339.diff
LOG
@@ -0,0 +1,86 @@
+//===--
DWARF64UnitTest.cpp=---===//
JDevlieghere wrote:
```suggestion
//===-- DWARF64UnitTest.cpp===//
```
https://github.com/llvm/llvm-project/pull/1
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/6] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
oontvoo wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/145954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/145954
>From f4092ed5fda4214bfd2c72f288a6c686315bdc3b Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Jun 2025 15:18:44 -0400
Subject: [PATCH 1/4] [LLDB][NFC] Refactor code extracting timestamp from
StructuredD
@@ -148,23 +161,12 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/146132
>From e601025c14fb609635dc6a9adea5b1ae8b8e4540 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 27 Jun 2025 11:08:08 -0700
Subject: [PATCH 1/3] [lldb] Correctly restore the cursor column after re
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/146356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/6] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/statusline/TestStatusline.py
``
V
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/146132
>From e601025c14fb609635dc6a9adea5b1ae8b8e4540 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 27 Jun 2025 11:08:08 -0700
Subject: [PATCH 1/2] [lldb] Correctly restore the cursor column after re
chelcassanova wrote:
`home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/RPC/Generator/Tests/Output/CheckRPCGenToolByproducts.test.script:
line 1: fg: no job control` This means that the test does not recognize the
`lldb-rpc-gen` binary. It was working before an
https://github.com/adrian-prantl approved this pull request.
LGTM with Michael's comments addressed.
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/adrian-prantl commented:
LGTM with under/overflow checks added.
https://github.com/llvm/llvm-project/pull/144238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/5] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/145621
>From 79c10b6f6630b3ceaa85af45956aeafdf372b5be Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 25 Jun 2025 18:03:39 -0700
Subject: [PATCH 1/8] [lldb] Adding file and pipe support to
lldb_private::MainLoo
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/4] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
JDevlieghere wrote:
> This looks good. Any chance of a test case? This sounds like something
> pexpect should manage to handle.
I'm somewhat skeptical of the value, but I can add a test case to check for the
escape codes to make sure the new Editline code is called.
https://github.com/llvm/l
JDevlieghere wrote:
> Yeah, that would definitely be bad, but I feel like it should be avoidable. I
> take it that's a side effect of implementing resize by disabling and
> re-enabling the status line. However, does it have to be that way? What if
> resize was a separate operation that just in
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/145621
>From 79c10b6f6630b3ceaa85af45956aeafdf372b5be Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 25 Jun 2025 18:03:39 -0700
Subject: [PATCH 1/7] [lldb] Adding file and pipe support to
lldb_private::MainLoo
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/145621
>From 79c10b6f6630b3ceaa85af45956aeafdf372b5be Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 25 Jun 2025 18:03:39 -0700
Subject: [PATCH 1/6] [lldb] Adding file and pipe support to
lldb_private::MainLoo
@@ -31,6 +34,122 @@ static DWORD
ToTimeout(std::optional point) {
return ceil(dur).count();
}
+namespace {
+
+class PipeEvent : public MainLoopWindows::IOEvent {
+public:
+ explicit PipeEvent(HANDLE handle)
+ : IOEvent((IOObject::WaitableHandle)CreateEventW(
+
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/145935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-06-30T09:01:15-07:00
New Revision: 16dc6f64ded3f47a6c03098e021ae943714a7663
URL:
https://github.com/llvm/llvm-project/commit/16dc6f64ded3f47a6c03098e021ae943714a7663
DIFF:
https://github.com/llvm/llvm-project/commit/16dc6f64ded3f47a6c03098e021ae943714a7663.d
Author: James Y Knight
Date: 2025-06-30T11:54:36-04:00
New Revision: 25e5010a302f2c93397c56d7c07168e075a15a44
URL:
https://github.com/llvm/llvm-project/commit/25e5010a302f2c93397c56d7c07168e075a15a44
DIFF:
https://github.com/llvm/llvm-project/commit/25e5010a302f2c93397c56d7c07168e075a15a44.diff
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/145935
>From 2b6a7e22481761b244e98dff00f905cf32a7d696 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 26 Jun 2025 10:31:09 -0700
Subject: [PATCH 1/3] [lldb] Document MCP support in LLDB
---
lldb/docs
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/146356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/145954
>From f4092ed5fda4214bfd2c72f288a6c686315bdc3b Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Jun 2025 15:18:44 -0400
Subject: [PATCH 1/3] [LLDB][NFC] Refactor code extracting timestamp from
StructuredD
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
@@ -7,20 +7,10 @@
//===--===//
#include "DWARFDataExtractor.h"
-#include "llvm/ADT/StringRef.h"
labath wrote:
yeah, a bit of drive-by header gardening :P
https://github.com/llvm/llvm-projec
@@ -7,20 +7,10 @@
//===--===//
#include "DWARFDataExtractor.h"
-#include "llvm/ADT/StringRef.h"
Michael137 wrote:
How come this changed? Is this `clangd`?
https://github.com/llvm/llvm-proje
@@ -7,20 +7,10 @@
//===--===//
#include "DWARFDataExtractor.h"
-#include "llvm/ADT/StringRef.h"
Michael137 wrote:
Makes sense to include `ArrayRef` though since it's used in this source file
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/146356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -187,6 +187,9 @@ class PlatformDarwin : public PlatformPOSIX {
std::vector &options,
XcodeSDK::Type sdk_type);
+ static llvm::Expected
+ ResolveSDKPathFromDebugInfo(lldb_private::Tar
@@ -1152,6 +1150,46 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
}
}
+llvm::Expected
+lldb_private::PlatformDarwin::ResolveSDKPathFromDebugInfo(
+lldb_private::Target *target) {
+
+ ModuleSP exe_module_sp = target->GetExecutableModule();
+ if (!
@@ -1152,6 +1150,46 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
}
}
+llvm::Expected
+lldb_private::PlatformDarwin::ResolveSDKPathFromDebugInfo(
+lldb_private::Target *target) {
+
+ ModuleSP exe_module_sp = target->GetExecutableModule();
+ if (!
@@ -1152,6 +1150,46 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
}
}
+llvm::Expected
+lldb_private::PlatformDarwin::ResolveSDKPathFromDebugInfo(
+lldb_private::Target *target) {
+
+ ModuleSP exe_module_sp = target->GetExecutableModule();
+ if (!
@@ -1152,6 +1150,46 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
}
}
+llvm::Expected
+lldb_private::PlatformDarwin::ResolveSDKPathFromDebugInfo(
+lldb_private::Target *target) {
+
+ ModuleSP exe_module_sp = target->GetExecutableModule();
+ if (!
https://github.com/Michael137 approved this pull request.
LGTM, just some final stylistic comments
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1128,17 +1128,8 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
FileSpec sysroot_spec;
- if (target) {
-if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
They are left over from our previous attempt at DWARF64. The new attempt is not
using them, and they also don't have equivalents in the llvm DWARFDataExtractor
class.
---
Full diff: https://github.com/llvm/ll
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/146356
They are left over from our previous attempt at DWARF64. The new attempt is not
using them, and they also don't have equivalents in the llvm DWARFDataExtractor
class.
>From b2ad70820e53be64e5908c84d8b828369dce9
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/3] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
Author: dlav-sc
Date: 2025-06-30T16:27:44+03:00
New Revision: d7e23bef6ad497cd5a100126957c381e053dda9b
URL:
https://github.com/llvm/llvm-project/commit/d7e23bef6ad497cd5a100126957c381e053dda9b
DIFF:
https://github.com/llvm/llvm-project/commit/d7e23bef6ad497cd5a100126957c381e053dda9b.diff
LOG:
https://github.com/dlav-sc closed
https://github.com/llvm/llvm-project/pull/146072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/146072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
@@ -288,7 +284,9 @@ bool DWARFFormValue::SkipValue(dw_form_t form,
case DW_FORM_sec_offset:
case DW_FORM_strp:
case DW_FORM_line_strp:
- *offset_ptr += 4;
+ assert(unit); // Unit must be valid
HemangGadhavi wrote:
Thanks @Michael137
Done
@@ -77,7 +77,9 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
case DW_FORM_strp:
case DW_FORM_line_strp:
case DW_FORM_sec_offset:
- m_value.uval = data.GetMaxU64(offset_ptr, 4);
+ assert(m_unit); // Unit must be valid
---
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH 1/3] [lldb][DWARF64] Enable support for DWARF64 format
han
@@ -288,7 +284,9 @@ bool DWARFFormValue::SkipValue(dw_form_t form,
case DW_FORM_sec_offset:
case DW_FORM_strp:
case DW_FORM_line_strp:
- *offset_ptr += 4;
+ assert(unit); // Unit must be valid
+ ref_addr_size = unit->GetFormParams().getDwarfOffsetByte
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
@@ -288,7 +284,9 @@ bool DWARFFormValue::SkipValue(dw_form_t form,
case DW_FORM_sec_offset:
case DW_FORM_strp:
case DW_FORM_line_strp:
- *offset_ptr += 4;
+ assert(unit); // Unit must be valid
Michael137 wrote:
```suggestion
assert(
DhruvSrivastavaX wrote:
@HemangGadhavi , Please check the code format failure and lets me have a check
before merging.
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -77,7 +77,9 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
case DW_FORM_strp:
case DW_FORM_line_strp:
case DW_FORM_sec_offset:
- m_value.uval = data.GetMaxU64(offset_ptr, 4);
+ assert(m_unit); // Unit must be valid
---
@@ -1128,17 +1128,8 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
FileSpec sysroot_spec;
- if (target) {
-if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
-
HemangGadhavi wrote:
@DhruvSrivastavaX can you please merge it
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1130,13 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/2] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
@@ -0,0 +1,96 @@
+//===--
DWARF64UnitTest.cpp=---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH 1/3] [lldb][DWARF64] Enable support for DWARF64 format
han
@@ -239,122 +240,24 @@
VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) {
bool lldb_private::formatters::LibStdcppStringSummaryProvider(
ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) {
- const bool scalar_is_load_addr =
@@ -0,0 +1,96 @@
+//===--
DWARF64UnitTest.cpp=---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1130,13 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/labath commented:
I think the tests are fine. @Michael137, @jimingham, do you have anything to
say about the implementation?
https://github.com/llvm/llvm-project/pull/143177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
configuration.libcxx_library_dir = args.libcxx_library_dir
configuration.cmake_build_type = args.cmake_build_type.lower()
+configuration.target_triple = args.target_triple
+
labath wrote:
Yeah
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/143177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/146094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Well, my logic was that it's better to return something than nothing,
For a simple variable query, it might be okay since you kind of see the full
name in the command output. However, for expressions like `a+b`, it's kind of
important to know which `a`s and `b`s are you adding
@@ -191,12 +191,28 @@ ASTNodeUP DILParser::ParsePrimaryExpression() {
return std::make_unique(loc, identifier);
}
+ uint32_t loc = CurToken().GetLocation();
+ std::string nested_name_specifier;
+
if (CurToken().Is(Token::l_paren)) {
-m_dil_lexer.Advance();
-
1 - 100 of 124 matches
Mail list logo