================ @@ -31,6 +34,122 @@ static DWORD ToTimeout(std::optional<MainLoopWindows::TimePoint> point) { return ceil<milliseconds>(dur).count(); } +namespace { + +class PipeEvent : public MainLoopWindows::IOEvent { +public: + explicit PipeEvent(HANDLE handle) + : IOEvent((IOObject::WaitableHandle)CreateEventW( + NULL, /*bManualReset=*/FALSE, + /*bInitialState=*/FALSE, NULL)), + m_handle(handle), m_ready(CreateEventW(NULL, /*bManualReset=*/FALSE, + /*bInitialState=*/FALSE, NULL)) { + assert(event && ready); + } + + ~PipeEvent() override { + if (m_monitor_thread.joinable()) { + m_stopped = true; + SetEvent(m_ready); + // Keep trying to cancel ReadFile() until the thread exits. + do { + CancelIoEx((HANDLE)m_handle, /*lpOverlapped=*/NULL); + } while (WaitForSingleObject(m_monitor_thread.native_handle(), 1) == + WAIT_TIMEOUT); + m_monitor_thread.join(); + } + CloseHandle((HANDLE)m_event); + CloseHandle(m_ready); + } + + void WillPoll() override { + if (!m_monitor_thread.joinable()) ---------------- ashgti wrote:
I had this at first but I needed to have an extra ivar for starting the signaling the thread to start in the 'WillPoll', otherwise if you registered a PipeEvent and didn't immediately run the loop it potentially prematurely get a read signal. I tried using the `m_ready` variable for triggering that, but it got complicated if an event fired between polling events because of when we call 'Disarm'. https://github.com/llvm/llvm-project/pull/145621 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits