[Lldb-commits] [lldb] [lldb] Delete unused DWARFDataExtractor methods (PR #146356)

[Pavel Labath via lldb-commits]

https://github.com/labath created 
https://github.com/llvm/llvm-project/pull/146356

They are left over from our previous attempt at DWARF64. The new attempt is not 
using them, and they also don't have equivalents in the llvm DWARFDataExtractor 
class.

>From b2ad70820e53be64e5908c84d8b828369dce9b41 Mon Sep 17 00:00:00 2001
From: Pavel Labath <pa...@labath.sk>
Date: Mon, 30 Jun 2025 16:18:38 +0200
Subject: [PATCH] [lldb] Delete unused DWARFDataExtractor methods

They are left over from our previous attempt at DWARF64. The new attempt
is not using them, and they also don't have equivalents in the llvm
DWARFDataExtractor class.
---
 .../Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp  | 12 +-----------
 .../Plugins/SymbolFile/DWARF/DWARFDataExtractor.h    |  8 --------
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp
index c5876502b8f29..a0b8acb585635 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp
@@ -7,20 +7,10 @@
 
//===----------------------------------------------------------------------===//
 
 #include "DWARFDataExtractor.h"
-#include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/ArrayRef.h"
 
 namespace lldb_private {
 
-uint64_t
-DWARFDataExtractor::GetDWARFInitialLength(lldb::offset_t *offset_ptr) const {
-  return GetU32(offset_ptr);
-}
-
-dw_offset_t
-DWARFDataExtractor::GetDWARFOffset(lldb::offset_t *offset_ptr) const {
-  return GetMaxU64(offset_ptr, GetDWARFSizeOfOffset());
-}
-
 llvm::DWARFDataExtractor DWARFDataExtractor::GetAsLLVMDWARF() const {
   return llvm::DWARFDataExtractor(llvm::ArrayRef(GetDataStart(), 
GetByteSize()),
                                   GetByteOrder() == lldb::eByteOrderLittle,
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h 
b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
index 41b8e9ad0217b..f6bcf9b2d27f7 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
@@ -9,7 +9,6 @@
 #ifndef LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
 #define LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
 
-#include "lldb/Core/dwarf.h"
 #include "lldb/Utility/DataExtractor.h"
 #include "llvm/DebugInfo/DWARF/DWARFDataExtractor.h"
 
@@ -23,13 +22,6 @@ class DWARFDataExtractor : public DataExtractor {
                      lldb::offset_t length)
       : DataExtractor(data, offset, length) {}
 
-  uint64_t GetDWARFInitialLength(lldb::offset_t *offset_ptr) const;
-
-  dw_offset_t GetDWARFOffset(lldb::offset_t *offset_ptr) const;
-
-  size_t GetDWARFSizeofInitialLength() const { return 4; }
-  size_t GetDWARFSizeOfOffset() const { return 4; }
-
   llvm::DWARFDataExtractor GetAsLLVMDWARF() const;
   llvm::DataExtractor GetAsLLVM() const;
 };

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits