https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/138580
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
This looks good now. Thanks. I'm surprised that something like `derb.x` doesn't
work -- both for "frame var" and in C++. You're not changing that, so it bears
no relation to this patch, but overall, but overall, I think it wouldn't be
*un*r
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/138487
>From 780371cf111c97e2bce5f030625ff557bb2f40b6 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Sun, 4 May 2025 23:43:28 -0700
Subject: [PATCH 1/2] [LLDB] Fix GetIndexOfChildMemberWithName to handle
anonymous
cmtice wrote:
> I'm not intimately familiar with this code, but I am somewhat suspicious of
> implementation.
>
> Adding the number of base classes to the result makes sense to me. What
> surprises me is that this should be done only for fields with anonymous
> types. Can you explain why shou
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138219
>From b7391070942219a691a691822477e2a7616be1ab Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 2 May 2025 09:59:01 -0700
Subject: [PATCH] [lldb-dap] Change the launch sequence
This PR changes h
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/138601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-05T17:29:40-07:00
New Revision: 1c1238d3615a7e1a99570d1e02de3b538d2e0669
URL:
https://github.com/llvm/llvm-project/commit/1c1238d3615a7e1a99570d1e02de3b538d2e0669
DIFF:
https://github.com/llvm/llvm-project/commit/1c1238d3615a7e1a99570d1e02de3b538d2e0669.d
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/138601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This mainly adds as design doc to help follow with the current PRs up for
upstreaming the `lldb-rpc-gen` tool and emitters.
---
Full diff: https://github.com/llvm/llvm-project/pull/138612.diff
1
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/138612
This mainly adds as design doc to help follow with the current PRs up for
upstreaming the `lldb-rpc-gen` tool and emitters.
Rate limit · GitHub
body {
backg
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-05T16:10:57-07:00
New Revision: 3e235a7c601d80d6e8a0392ebec859068659ec19
URL:
https://github.com/llvm/llvm-project/commit/3e235a7c601d80d6e8a0392ebec859068659ec19
DIFF:
https://github.com/llvm/llvm-project/commit/3e235a7c601d80d6e8a0392ebec859068659ec19.d
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/137751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> @Michael137 I looked into adding the diagnostic you asked about and while the
> implementation is relatively straightforward, I'm even more convinced that I
> don't think it belongs there because it's a semantic rather than a syntax
> error.
>
> We can detect a scope follo
JDevlieghere wrote:
@Michael137 I looked into adding the diagnostic you asked about and while the
implementation is relatively straightforward, I'm even more convinced that I
don't think it belongs there because it's a semantic rather than a syntax
error.
We can detect a scope followed by an
JDevlieghere wrote:
> @felipepiovezan Hopefully this should fix the problem in the macOS tests
> ([#137512
> (comment)](https://github.com/llvm/llvm-project/pull/137512#issuecomment-2846104161))
> though I don't know how to trigger these tests from the PR :|
Unfortunately there's no pre-commi
Author: Muhammad Omair Javaid
Date: 2025-05-06T03:37:54+05:00
New Revision: b86b5296cb649c06abbb6471d6f0f777b91a29c9
URL:
https://github.com/llvm/llvm-project/commit/b86b5296cb649c06abbb6471d6f0f777b91a29c9
DIFF:
https://github.com/llvm/llvm-project/commit/b86b5296cb649c06abbb6471d6f0f777b91a29
Author: Jonas Devlieghere
Date: 2025-05-05T15:15:58-07:00
New Revision: 3ceec268413860b466b14600ce67d8bbd09ff75c
URL:
https://github.com/llvm/llvm-project/commit/3ceec268413860b466b14600ce67d8bbd09ff75c
DIFF:
https://github.com/llvm/llvm-project/commit/3ceec268413860b466b14600ce67d8bbd09ff75c.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/138435
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
DAP::WaitForProcessToStop treats the process in eStateUnloaded as an error. The
process is in this state when it has just been created (before an attach or
launch) or when it's restarted. Neither sh
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/137383
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/138601
DAP::WaitForProcessToStop treats the process in eStateUnloaded as an error. The
process is in this state when it has just been created (before an attach or
launch) or when it's restarted. Neither should be
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138435
>From 50c11b4360cf8781c99ab207b70b8de291e5a36e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 2 Apr 2025 00:47:44 -0700
Subject: [PATCH] [lldb-dap] Give attach test binaries unique names
Give
JDevlieghere wrote:
This is still necessary, at least on Darwin, because `vAttachWait` only looks
at the basename.
https://github.com/llvm/llvm-project/pull/138435
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/136748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
I split this large patch up into 3 smaller ones:
This patch upstreams the `lldb-rpc-gen` tool itself as well as its common code:
https://github.com/llvm/llvm-project/pull/138031
This upstreams the server-side emitter:
https://github.com/llvm/llvm-project/pull/138032
This up
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/138580
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This is the first useful patch in the series related to enabling `PTRACE_SEIZE`
for processes Coredumping. In order to make the decision if we want to seize or
attach, we need to expose that in processinfo.
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/138580
This is the first useful patch in the series related to enabling `PTRACE_SEIZE`
for processes Coredumping. In order to make the decision if we want to seize or
attach, we need to expose that in processinfo.
We
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/138557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-05T13:34:29-07:00
New Revision: 9544943e2458597dc2cdcbed6de2a8d50da0d382
URL:
https://github.com/llvm/llvm-project/commit/9544943e2458597dc2cdcbed6de2a8d50da0d382
DIFF:
https://github.com/llvm/llvm-project/commit/9544943e2458597dc2cdcbed6de2a8d50da0d382.d
https://github.com/ashgti approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/138557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dmpots wrote:
ping @clayborg @JDevlieghere @jimingham. I updated the PR to include plugin
info in the stats. Please take a look when you get a chance. Thanks!
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commit
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
This reverts commit 1ba89ad2c6e405bd5ac0c44e2ee5aa5504c7aba1.
This was failing on the Green Dragon bot, which has an older OS than have on
hand, so I'll have to dig up one and see why it's failing there.
---
Full
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/138569
This reverts commit 1ba89ad2c6e405bd5ac0c44e2ee5aa5504c7aba1.
This was failing on the Green Dragon bot, which has an older OS than have on
hand, so I'll have to dig up one and see why it's failing there.
Author: jimingham
Date: 2025-05-05T12:45:17-07:00
New Revision: 1ff2953f5e393eb8634ea3c4ccc85221e76dfcb9
URL:
https://github.com/llvm/llvm-project/commit/1ff2953f5e393eb8634ea3c4ccc85221e76dfcb9
DIFF:
https://github.com/llvm/llvm-project/commit/1ff2953f5e393eb8634ea3c4ccc85221e76dfcb9.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/138569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138557
>From 8289d760034dc18315d116aaeddda9033ff1390a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 5 May 2025 10:18:12 -0700
Subject: [PATCH 1/2] [lldb-dap] Specify the executable path in the attach
@@ -161,7 +157,13 @@ void AttachRequestHandler::operator()(const
llvm::json::Object &request) const {
dap.target.ConnectRemote(listener, connect_url.c_str(), "gdb-remote",
error);
} else {
-// Attach by process name or id.
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/138206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2025-05-05T11:04:55-07:00
New Revision: c50cba6275271fba69be661b9ec0665b2be88dbc
URL:
https://github.com/llvm/llvm-project/commit/c50cba6275271fba69be661b9ec0665b2be88dbc
DIFF:
https://github.com/llvm/llvm-project/commit/c50cba6275271fba69be661b9ec0665b2be88dbc.diff
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138219
>From afd0475ea23ed79f074c3f4143b86e6efb557d37 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 2 May 2025 09:59:01 -0700
Subject: [PATCH] [lldb-dap] Change the launch sequence
This PR changes h
jimingham wrote:
> > Swift doesn't have pointers really. It does pass some things by value
> > (called structs) and others by reference (called classes), but it doesn't
> > let you know how. So this ambiguity between "pointer to object" and
> > "pointer to contiguous buffer of objects" doesn't
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Currently, we are only using the executable name when attaching. The
AttachRequestHandler isn't setting the path in the attach info, which means
that we rely on the target when attaching by name. Wh
JDevlieghere wrote:
https://github.com/llvm/llvm-project/pull/138557
https://github.com/llvm/llvm-project/pull/138435
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/138557
Currently, we are only using the executable name when attaching. The
AttachRequestHandler isn't setting the path in the attach info, which means
that we rely on the target when attaching by name. When wo g
kuilpd wrote:
> Swift doesn't have pointers really. It does pass some things by value (called
> structs) and others by reference (called classes), but it doesn't let you
> know how. So this ambiguity between "pointer to object" and "pointer to
> contiguous buffer of objects" doesn't come up.
JDevlieghere wrote:
> I see a comment in `TestDAP_attach.test_by_name` that mentions making the
> path more unique, so I'm wondering if something else has changed or if that
> previous attempt at making the name more unique was a little off the mark.
Excellent question. We are indeed only usin
jimingham wrote:
> One thing I'm not sure about here: will converting array type to a pointer,
> adding the index and then dereferencing work for Swift? I tried just doing
> `base->GetChildAtIndex(index)`, but it doesn't work when the base is a
> pointer and it also returns an error when index
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/138330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2025-05-05T09:55:32-07:00
New Revision: 1ba89ad2c6e405bd5ac0c44e2ee5aa5504c7aba1
URL:
https://github.com/llvm/llvm-project/commit/1ba89ad2c6e405bd5ac0c44e2ee5aa5504c7aba1
DIFF:
https://github.com/llvm/llvm-project/commit/1ba89ad2c6e405bd5ac0c44e2ee5aa5504c7aba1.diff
LOG
kuilpd wrote:
> I don't have an answer to that, but I do know that it's possible to index
> pointers in the current implementation. I suggest checking out how it
> achieves that and seeing if it can be translated to here.
Ah, I will look into this further, thanks.
https://github.com/llvm/llvm
labath wrote:
> One thing I'm not sure about here: will converting array type to a pointer,
> adding the index and then dereferencing work for Swift? I tried just doing
> `base->GetChildAtIndex(index)`, but it doesn't work when the base is a
> pointer and it also returns an error when index is
Jlalond wrote:
Updated the tests to skip on Windows. It would otherwise fail there.
https://github.com/llvm/llvm-project/pull/138206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138206
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
kuilpd wrote:
One thing I'm not sure about here: will converting array type to a pointer,
adding the index and then dereferencing work for Swift?
I tried just doing `base->GetChildAtIndex(index)`, but it doesn't work when the
base is a pointer and it also returns an error when index is out of b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
---
Patch is 27.37 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/138551.diff
13 Files Affected:
- (modified) lldb/docs/dil-expr-lang.ebnf (+9-3)
- (modified) l
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/138551
None
>From cfe7359bd16c1e87932e2ebb8bcdfc88130e9729 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Wed, 30 Apr 2025 22:03:50 +0500
Subject: [PATCH] [LLDB] Add array subscription and integer parsing to DIL
---
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/138174
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From 278179a35bacc7c70dd1724e7ef7a41e9cdd999a Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
Add `llvm::uninitiali
https://github.com/dmpots approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/138206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/138174
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/137688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ilia Kuklin
Date: 2025-05-05T20:53:04+05:00
New Revision: 0eff4108cb1e0a597ba70a4e1b8e1ce3ae0cfd46
URL:
https://github.com/llvm/llvm-project/commit/0eff4108cb1e0a597ba70a4e1b8e1ce3ae0cfd46
DIFF:
https://github.com/llvm/llvm-project/commit/0eff4108cb1e0a597ba70a4e1b8e1ce3ae0cfd46.diff
L
https://github.com/labath approved this pull request.
Yeah, yeah. If Jim says it's ok, that's good enough for me.
https://github.com/llvm/llvm-project/pull/137688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/ashgti approved this pull request.
Does attach normally only check the basename of the executable? Or is it
supposed to match the entire path?
I see a comment in `TestDAP_attach.test_by_name` that mentions making the path
more unique, so I'm wondering if something else has c
kuilpd wrote:
@labath
Is this okay to merge now?
https://github.com/llvm/llvm-project/pull/137688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/135843
>From 7cca4bf228ab2b882a1a6487eb24948cba9e5b12 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Wed, 16 Apr 2025 00:30:51 +0500
Subject: [PATCH 1/5] [lldb][TypeSystemClang] Add a function
`IsValidDereferenceType
@@ -88,7 +88,7 @@ def cleanup():
self.expect(
"frame variable *number_not_engaged",
error=True,
-substrs=["not a pointer or reference type"],
+substrs=["dereference failed: not a"],
kuilpd wrote:
I had a
@@ -800,16 +800,24 @@ Print the dynamic type of the result of an expression
(gdb) p someCPPObjectPtrOrReference
(Only works for C++ objects)
+LLDB does this automatically if determining the dynamic type does not require
+running the target (in C++, running the target is ne
@@ -800,16 +800,24 @@ Print the dynamic type of the result of an expression
(gdb) p someCPPObjectPtrOrReference
(Only works for C++ objects)
+LLDB does this automatically if determining the dynamic type does not require
+running the target (in C++, running the target is ne
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The setting and option value names were wrong. I'm assuming this changed over
time, but I haven't tried to figure out when.
---
Full diff: https://github.com/llvm/llvm-project/pull/138538.diff
1 Files Affect
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/138538
The setting and option value names were wrong. I'm assuming this changed over
time, but I haven't tried to figure out when.
Rate limit · GitHub
body {
background-c
@@ -88,7 +88,7 @@ def cleanup():
self.expect(
"frame variable *number_not_engaged",
error=True,
-substrs=["not a pointer or reference type"],
+substrs=["dereference failed: not a"],
labath wrote:
What's t
@@ -2794,37 +2794,26 @@ ValueObjectSP ValueObject::Dereference(Status &error) {
if (m_deref_valobj)
return m_deref_valobj->GetSP();
- const bool is_pointer_or_reference_type = IsPointerOrReferenceType();
- if (is_pointer_or_reference_type) {
-bool omit_empty_base_c
@@ -2854,14 +2842,22 @@ ValueObjectSP ValueObject::Dereference(Status &error) {
m_deref_valobj = new ValueObjectChild(
*this, child_compiler_type, child_name, child_byte_size,
child_byte_offset, child_bitfield_bit_size,
- child
https://github.com/santhoshe447 updated
https://github.com/llvm/llvm-project/pull/131820
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
https://github.com/slydiman approved this pull request.
Ok, let's see how it flies in the real world.
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
SuibianP wrote:
> Another PR looks abandoned
It is actually not (yet). I have been actively waiting for maintainers to drop
another review and have pinged & rebased several times over these three months.
https://github.com/llvm/llvm-project/pull/138160
_
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From f9675fbe23abe59c3cf56a6263b7a78ec20e42d4 Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
labath wrote:
> Move the Proc Status (not stat) code to the HOST class
I'd put this first (in which case it wouldn't be called "move" but "extend" or
"refactor"), for two reasons:
- it reduces the chance of ending up with two parsers
- I'm not very happy with the implementation you have here. I
labath wrote:
Correct. :)
https://github.com/llvm/llvm-project/pull/126935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
-
labath wrote:
I'm not intimately familiar with this code, but I am somewhat suspicious of
implementation.
Adding the number of base classes to the result makes sense to me. What
surprises me is that this should be done only for fields with anonymous types.
Can you explain why should the index
@@ -283,39 +283,42 @@ uint32_t Block::GetRangeIndexContainingAddress(const
Address &addr) {
return m_ranges.FindEntryIndexThatContains(file_addr - func_file_addr);
}
+static AddressRange ToAddressRange(const Address &func_addr,
+ const Bloc
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/137955
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
89 matches
Mail list logo
