llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
I encountered a `qMemoryRegionInfo not supported` error when capturing a
Minidump. This was surprising, and I started looking around I found @jasonmolenda's fix in #115963 and then realized I was not validate
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/125323
I encountered a `qMemoryRegionInfo not supported` error when capturing a
Minidump. This was surprising, and I started looking around I found
@jasonmolenda's fix in #115963 and then realized I was not validated
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/3] [lldb] Implement bidirectional access fo
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/2] [lldb] Implement bidirectional access fo
@@ -470,6 +470,18 @@ class Thread : public std::enable_shared_from_this,
virtual void ClearStackFrames();
+ /// Derived classes implementing SetBackingThread should use this to provide
+ /// bidirectional access to the Backing-Backed relationship.
+ void SetBackedThread(
https://github.com/jimingham approved this pull request.
LGTM, better to be consistent, and the pointer value is useful.
https://github.com/llvm/llvm-project/pull/125294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
jimingham wrote:
This looks good. I wonder if we ought to do something a little less ad hoc
about the cases where our command return objects are from HandleCommands, so
they won't necessarily have the result of a single command. In the case where
a UI is parsing these, it might very well nee
@@ -470,6 +470,18 @@ class Thread : public std::enable_shared_from_this,
virtual void ClearStackFrames();
+ /// Derived classes implementing SetBackingThread should use this to provide
+ /// bidirectional access to the Backing-Backed relationship.
+ void SetBackedThread(
JDevlieghere wrote:
Can you write or modify a test? I glanced over `TestWatchpointEvents.py` and it
looks like it's listening to the wrong bit (even thought the test is passing
with your change).
https://github.com/llvm/llvm-project/pull/125312
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
As suggested in #125006. Depending on which PR lands first, I'll update
`TestCommandInterepterPrintCallback.py` to check that the `CommandReturnObject`
passed to the callback has the correct command
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/125132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/125132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125132
>From aa41718c6f8220d5369453e91e372e4f52c37c6a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 15:00:14 -0800
Subject: [PATCH] [lldb] Store the command in the CommandReturnObject
--
https://github.com/jimingham approved this pull request.
That seems obviously right, it doesn't make sense to require every process
plugin to be aware of backing threads, but it does seem quite reasonable for
generic code to be aware of them.
https://github.com/llvm/llvm-project/pull/125302
__
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/125312
>From 0bf7cf47b3373f3bd23802fcd41f6b831fff6adf Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Fri, 31 Jan 2025 22:38:04 +
Subject: [PATCH] LLDB: correct event when removing all watchpoints
Previously
https://github.com/puremourning edited
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ben Jackson (puremourning)
Changes
Previously we incorrectly emitted a "breakpoint changed" event when removing
all watchpoints (e.g. via SBTarget::DeleteAllWatchpoints()).
Correct it to emit the "watchpoint changed" event, as that's what
puremourning wrote:
https://github.com/llvm/llvm-project/pull/125312
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning created
https://github.com/llvm/llvm-project/pull/125312
Previously we incorrectly emitted a "breakpoint changed" event when removing
all watchpoints (e.g. via SBTarget::DeleteAllWatchpoints()).
Correct it to emit the "watchpoint changed" event, as that's what "
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
kuilpd wrote:
Alright, wi
puremourning wrote:
Looking again, of course you're right and the behaviour of RemoveAll and Remove
is inconsistent today, so I don't see a problem with fixing it.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-com
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Feel fr
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Ah true
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
kuilpd wrote:
It's used i
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
That's
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/125294
>From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Fri, 31 Jan 2025 13:05:14 -0800
Subject: [PATCH 1/3] [lldb] Show value for libcxx and libstdcxx summary and
remove
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
kuilpd wrote:
Yes, but I
puremourning wrote:
> Seeing as you are working on watchpoints here, I found that `void
> WatchpointList::RemoveAll(bool notify)` is sending the wrong event of
> `Target::eBroadcastBitBreakpointChanged` instead of sending
> `Target::eBroadcastBitWatchpointChanged`. Might be a good fix to get i
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/125294
>From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Fri, 31 Jan 2025 13:05:14 -0800
Subject: [PATCH 1/2] [lldb] Show value for libcxx and libstdcxx summary and
remove
clayborg wrote:
Seeing as you are working on watchpoints here, I found that `void
WatchpointList::RemoveAll(bool notify)` is sending the wrong event of
`Target::eBroadcastBitBreakpointChanged` instead of sending
`Target::eBroadcastBitWatchpointChanged`. Might be a good fix to get in to
ensure
@@ -72,12 +72,17 @@ class ThreadMemory : public lldb_private::Thread {
void ClearStackFrames() override;
- void ClearBackingThread() override { m_backing_thread_sp.reset(); }
+ void ClearBackingThread() override {
+if (m_backing_thread_sp)
+ m_backing_thread_sp->
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
Generally speaking, process plugins (e.g. ProcessGDBRemote) should not be aware
of OS plugin threads. However, ProcessGDBRemote attempts to check for the
existence of OS threads when calc
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This enables finding the backed thread from the backing thread without going
through the thread list, and it will be useful for subsequent commits.
---
Full diff: https://github.com/llvm/
felipepiovezan wrote:
Depends on https://github.com/llvm/llvm-project/pull/125300
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/125302
Generally speaking, process plugins (e.g. ProcessGDBRemote) should not be aware
of OS plugin threads. However, ProcessGDBRemote attempts to check for the
existence of OS threads when calculating stop inf
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/125300
This enables finding the backed thread from the backing thread without going
through the thread list, and it will be useful for subsequent commits.
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 6b3ba3f6dcf11d8b18ff72bc736b24ac75231626 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
puremourning wrote:
I think the issue is that... we just don't support read-only watchpoints on
intel because the [hardware doesn't support
it](https://en.wikipedia.org/wiki/X86_debug_register#cite_note-brkpt_type-19).
I guess I'll mark this test as "skip on x86"
https://github.com/llvm/llvm-
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/125125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-01-31T13:23:26-08:00
New Revision: 6deee0d5b36c8b4b83209759df8d4933e4922bc8
URL:
https://github.com/llvm/llvm-project/commit/6deee0d5b36c8b4b83209759df8d4933e4922bc8
DIFF:
https://github.com/llvm/llvm-project/commit/6deee0d5b36c8b4b83209759df8d4933e4922bc8.d
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
0d46657cb6bf04430ff8222e1974e49441767d47...bbecf2f990c1fdf8ed993c3bba4c68212ebb299c
lldb
Author: Adrian Prantl
Date: 2025-01-31T13:11:20-08:00
New Revision: 87b7f63a117c340a6d9ca47959335fd7ef6c7ad2
URL:
https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2
DIFF:
https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2.diff
@@ -172,7 +172,4 @@ def test_ref_and_ptr(self):
# The pointer should just show the right number of elements:
-ptrAddr = self.findVariable("ptr").GetValue()
-self.expect_expr(
-"ptr", result_type="std::span *",
result_summary=f"{ptrAddr} si
augusto2112 wrote:
Ok, fair point. I'll come up with a more robust solution.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
This is a very common crash point. I suspect that in most of the cases it's
because we flub whether something is a load or a host address, but I still
don't want to add other mistakes we could make here.
https://github.com/llvm/llvm-project/pull/125143
__
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This has two changes:
1. Set show value for libcxx and libstdcxx summary provider. This will print
the pointer value for both pointer type and reference type.
2. Remove pointer value printing in libcxx container
jimingham wrote:
I think it's worth making it as hard as possible to get the length you're
supposed to read from that buffer right.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
adrian-prantl wrote:
I'm going to revert this for now, let me know if you need help understanding
the failure cause!
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/125294
This has two changes:
1. Set show value for libcxx and libstdcxx summary provider. This will print
the pointer value for both pointer type and reference type.
2. Remove pointer value printing in libcxx containe
adrian-prantl wrote:
This is breaking macOS bots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/19569/
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
dzhidzhoev wrote:
@omjavaid
Apparently, these changes break lldb-remote-linux-win buildbot with the
following error:
```
FAILED:
tools/lldb/source/Plugins/Process/Windows/Common/CMakeFiles/lldbPluginProcessWindowsCommon.dir/NativeRegisterContextWindows_WoW64.cpp.obj
ccache
C:\PROGRA~1\MICR
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/118986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/122694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/5] [lldb] Use llvm::Error instead of CommandReturnObje
augusto2112 wrote:
> Maybe I'm missing something. In the host case, m_address is set to invalid,
> but m_value has the address in it and is a host address, so then we get to:
>
> // m_address could be invalid but we could still have a local buffer //
> containing the dynamic value. if ((m_addr
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Unless
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Apologi
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
kuilpd wrote:
> > Iterati
jimingham wrote:
Maybe I'm missing something. In the host case, m_address is set to invalid,
but m_value has the address in it and is a host address, so then we get to:
// m_address could be invalid but we could still have a local buffer
// containing the dynamic value.
if ((m_address.
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/4] [lldb] Use llvm::Error instead of CommandReturnObje
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/125270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-01-31T11:57:20-08:00
New Revision: 2a2d6e66ce3a87f4f5168df717782d777063f7b8
URL:
https://github.com/llvm/llvm-project/commit/2a2d6e66ce3a87f4f5168df717782d777063f7b8
DIFF:
https://github.com/llvm/llvm-project/commit/2a2d6e66ce3a87f4f5168df717782d777063f7b8.d
Author: Jonas Devlieghere
Date: 2025-01-31T11:57:49-08:00
New Revision: dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6
URL:
https://github.com/llvm/llvm-project/commit/dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6
DIFF:
https://github.com/llvm/llvm-project/commit/dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6.d
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
> Mostl
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 01/12] [lldb] Analyze enum promotion type during parsing
---
clang/
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
kuilpd wrote:
Well... I t
https://github.com/jimingham approved this pull request.
I'm happy that you can make ResolveCommand fail on commands that aren't valid!
These tests clearly thought they were making up a legal command string, so this
change expresses better what the test intends anyway.
https://github.com/llvm
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125270
>From a33e43e56e8a58c1d53c566c0b9da7791254d68e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 31 Jan 2025 11:10:40 -0800
Subject: [PATCH 1/2] [lldb] Use validation combination of options in
Te
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1b0becf739ace0e04c57b50ab701b5e3d009ccbb...a33e43e56e8a58c1d53c566c0b9da7791254d68e
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Name and line number are part of different option groups and are not compatible.
```
(lldb) breakpoint set -n foo -l 10
error: invalid combination of options for the given command
```
The help outpu
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/125270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/125270
Name and line number are part of different option groups and are not compatible.
(lldb) breakpoint set -n foo -l 10
error: invalid combination of options for the given command
The help output for `brea
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/4] [lldb] Use llvm::Error instead of CommandReturnObje
augusto2112 wrote:
> I worry a bit about the fact that in the host case, GetValueAsData is going
> to end up calling:
>
> ```
> memcpy(dst, reinterpret_cast(address), byte_size);
> ```
>
> where address is the host data buffer and byte_size is the size of the new
> dynamic type. But in the
https://github.com/felipepiovezan approved this pull request.
after staring at this long enough, I think this is fine, since the uint->int
conversion is done by apint
https://github.com/llvm/llvm-project/pull/125244
___
lldb-commits mailing list
lldb-
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125006
>From d9c0b0e1e6c18b6710c5b15843e23a96ca0a9dc8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 28 Jan 2025 17:08:52 -0800
Subject: [PATCH 1/4] [lldb] Support CommandInterpreter print callbacks
jimingham wrote:
We have a bunch of other structured output that we could start decorating this
way. For instance if `image list` produced a a JSON-ified version of itself
(maybe only when there was a callback present) and had a way to "get JSON-ified
result" then it could render that list i
JDevlieghere wrote:
Jim & I have been discussing this offline. Thanks for adding the additional
context to the PR!
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
Author: Dave Lee
Date: 2025-01-31T09:29:22-08:00
New Revision: 1b0becf739ace0e04c57b50ab701b5e3d009ccbb
URL:
https://github.com/llvm/llvm-project/commit/1b0becf739ace0e04c57b50ab701b5e3d009ccbb
DIFF:
https://github.com/llvm/llvm-project/commit/1b0becf739ace0e04c57b50ab701b5e3d009ccbb.diff
LOG:
jimingham wrote:
There are other ways you could extend this that would be very fun. For
instance, we could make any command that conses up its result just by calling
the ValueObjectPrinter on some ValueObject to also stuff that ValueObject to
the command return. Then we could add
SBCommandR
jimingham wrote:
> > Yes, part of the requirement is that the output isn't printed by lldb
> > itself, although the implementer is still in control with the return value.
>
> Okay. I was afraid of that. :)
>
> The code looks good, though I must admit that the functionality seems a bit..
> ran
DavidSpickett wrote:
Windows on Arm passed, Arm and AArch64 Linux passed. No complaints so far.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
jimingham wrote:
> On Jan 31, 2025, at 2:21 AM, Pavel Labath ***@***.***> wrote:
>
>
> @labath commented on this pull request.
>
> Apart from the (mainly stylistic) inline comments, the biggest problem I see
> is that the definition of an identifier is still too narrow. The restriction
> o
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
The `DWARFASTParserClang` reads enum values as `int64_t`s regardless of the
enumerators signedness. Then we pass it to
`AddEnumerationValueToEnumerationType` and only then do we create an `APSInt`
from it
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125244
The `DWARFASTParserClang` reads enum values as `int64_t`s regardless of the
enumerators signedness. Then we pass it to
`AddEnumerationValueToEnumerationType` and only then do we create an `APSInt`
from it.
@@ -8541,12 +8541,10 @@ clang::EnumConstantDecl
*TypeSystemClang::AddEnumerationValueToEnumerationType(
clang::EnumConstantDecl *TypeSystemClang::AddEnumerationValueToEnumerationType(
const CompilerType &enum_type, const Declaration &decl, const char *name,
-int64_t e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This reverts commit a774de807e56c1147d4630bfec3110c11d41776e.
This is the same changes as last time, plus:
* We load the binary into the target object so that on Windows, we can resolve
the locations
DavidSpickett wrote:
Back in again after fixing Windows testing -
https://github.com/llvm/llvm-project/pull/125242.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125242
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-31T15:56:33Z
New Revision: 7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b
URL:
https://github.com/llvm/llvm-project/commit/7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b
DIFF:
https://github.com/llvm/llvm-project/commit/7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b.diff
LOG
DavidSpickett wrote:
Pull request just in case we have to discuss this more, going to merge right
now.
https://github.com/llvm/llvm-project/pull/125242
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/125242
This reverts commit a774de807e56c1147d4630bfec3110c11d41776e.
This is the same changes as last time, plus:
* We load the binary into the target object so that on Windows, we can resolve
the locations of t
Author: Michael Buch
Date: 2025-01-31T13:09:46Z
New Revision: ae570d5d77e806784064ee819211868e745d0fbe
URL:
https://github.com/llvm/llvm-project/commit/ae570d5d77e806784064ee819211868e745d0fbe
DIFF:
https://github.com/llvm/llvm-project/commit/ae570d5d77e806784064ee819211868e745d0fbe.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
> Yes, part of the requirement is that the output isn't printed by lldb itself,
> although the implementer is still in control with the return value.
Okay. I was afraid of that. :)
The code looks good, though I must admit that the functionality seems a bit.
@@ -743,3 +743,15 @@ void SBCommand::SetFlags(uint32_t flags) {
if (IsValid())
m_opaque_sp->GetFlags().Set(flags);
}
+
+void SBCommandInterpreter::SetPrintCallback(
+lldb::SBCommandPrintCallback callback, void *baton) {
+ LLDB_INSTRUMENT_VA(this, callback, baton);
+
@@ -17,6 +17,7 @@
namespace lldb_private {
class CommandPluginInterfaceImplementation;
+class CommandPrintCallbackBaton;
labath wrote:
I think these could go away too...
https://github.com/llvm/llvm-project/pull/125006
___
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-01-31T12:38:07Z
New Revision: 8bd728180cadbab9fe11cd853670e488827ee302
URL:
https://github.com/llvm/llvm-project/commit/8bd728180cadbab9fe11cd853670e488827ee302
DIFF:
https://github.com/llvm/llvm-project/commit/8bd728180cadbab9fe11cd853670e488827ee302.diff
LOG:
1 - 100 of 142 matches
Mail list logo
