https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/125323
I encountered a `qMemoryRegionInfo not supported` error when capturing a
Minidump. This was surprising, and I started looking around I found
@jasonmolenda's fix in #115963 and then realized I was not validated anything
from the custom ranges.
>From 973117aaa1d1bffe5a10a8c87edafec91dcd51bd Mon Sep 17 00:00:00 2001
From: Jacob Lalonde <jalalo...@fb.com>
Date: Fri, 31 Jan 2025 17:37:46 -0800
Subject: [PATCH] Have custom ranges go through the same safety checks as
everything else, to avoid empty ranges, or ranges with no permissions
---
lldb/source/Target/Process.cpp | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 89731f798deda88..428f8519b72fd51 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -6677,11 +6677,8 @@ static void GetUserSpecifiedCoreFileSaveRanges(Process
&process,
for (const auto &range : regions) {
auto entry = option_ranges.FindEntryThatContains(range.GetRange());
- if (entry) {
- ranges.Append(range.GetRange().GetRangeBase(),
- range.GetRange().GetByteSize(),
- CreateCoreFileMemoryRange(range));
- }
+ if (entry)
+ AddRegion(range, true, ranges);
}
}
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
