Author: Jonas Devlieghere Date: 2025-01-31T11:57:49-08:00 New Revision: dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6
URL: https://github.com/llvm/llvm-project/commit/dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6 DIFF: https://github.com/llvm/llvm-project/commit/dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6.diff LOG: [lldb] Use validation combination of options in TestAbbreviations (#125270) Name and line number are part of different option groups and are not compatible. ``` (lldb) breakpoint set -n foo -l 10 error: invalid combination of options for the given command ``` The help output for `breakpoint set` confirms this. This patch updates the test to use two compatible options. With the improved error reporting from #125125 this becomes an issue. Added: Modified: lldb/test/API/functionalities/abbreviation/TestAbbreviations.py Removed: ################################################################################ diff --git a/lldb/test/API/functionalities/abbreviation/TestAbbreviations.py b/lldb/test/API/functionalities/abbreviation/TestAbbreviations.py index a8cbffbb7ba4a5..b4e770af0e392c 100644 --- a/lldb/test/API/functionalities/abbreviation/TestAbbreviations.py +++ b/lldb/test/API/functionalities/abbreviation/TestAbbreviations.py @@ -45,10 +45,12 @@ def test_command_abbreviations_and_aliases(self): # Make sure an unabbreviated command is not mangled. command_interpreter.ResolveCommand( - "breakpoint set --name main --line 123", result + "breakpoint set --name main --ignore-count 123", result ) self.assertTrue(result.Succeeded()) - self.assertEqual("breakpoint set --name main --line 123", result.GetOutput()) + self.assertEqual( + "breakpoint set --name main --ignore-count 123", result.GetOutput() + ) # Create some aliases. self.runCmd("com a alias com al") @@ -72,10 +74,10 @@ def test_command_abbreviations_and_aliases(self): "process launch -s -o /dev/tty0 -e /dev/tty0", result.GetOutput() ) - self.runCmd("alias xyzzy breakpoint set -n %1 -l %2") + self.runCmd("alias xyzzy breakpoint set -n %1 -i %2") command_interpreter.ResolveCommand("xyzzy main 123", result) self.assertTrue(result.Succeeded()) - self.assertEqual("breakpoint set -n main -l 123", result.GetOutput().strip()) + self.assertEqual("breakpoint set -n main -i 123", result.GetOutput().strip()) # And again, without enough parameters. command_interpreter.ResolveCommand("xyzzy main", result) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
