Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/122289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/122289
>From 59abbcc54700d5a8ba31ecd3b37431ffe86f7d70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Thu, 9 Jan 2025 16:01:59 +0100
Subject: [PATC
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/122289
>From 59abbcc54700d5a8ba31ecd3b37431ffe86f7d70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Thu, 9 Jan 2025 16:01:59 +0100
Subject: [PATC
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/120814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: GeorgeHuyubo
Date: 2025-01-10T18:13:46-08:00
New Revision: 9b528ed38038e39c441927b1fd0220654c253a3c
URL:
https://github.com/llvm/llvm-project/commit/9b528ed38038e39c441927b1fd0220654c253a3c
DIFF:
https://github.com/llvm/llvm-project/commit/9b528ed38038e39c441927b1fd0220654c253a3c.diff
@@ -141,6 +142,25 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
+static llvm::StringRef getFileName(const ModuleSpec &module_spec,
+ std::string url_path) {
+ // Check if the URL path
@@ -141,6 +142,25 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
+static llvm::StringRef getFileName(const ModuleSpec &module_spec,
+ std::string url_path) {
+ // Check if the URL path
@@ -141,6 +142,25 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
+static llvm::StringRef getFileName(const ModuleSpec &module_spec,
+ std::string url_path) {
+ // Check if the URL path
@@ -154,21 +174,29 @@ GetFileForModule(const ModuleSpec &module_spec,
// Grab LLDB's Debuginfod overrides from the
// plugin.symbol-locator.debuginfod.* settings.
PluginProperties &plugin_props = GetGlobalPluginProperties();
- llvm::Expected cache_path_or_err = plugin_pr
https://github.com/clayborg approved this pull request.
Just fix removing {} from single line if statements.
https://github.com/llvm/llvm-project/pull/120814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/120814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -56,7 +57,7 @@ class SaveCoreOptions {
std::optional m_file;
std::optional m_style;
lldb::ProcessSP m_process_sp;
- std::unordered_set m_threads_to_save;
+ std::unordered_map m_threads_to_save;
Jlalond wrote:
Yeah we can, good call out.
https://git
@@ -56,7 +57,7 @@ class SaveCoreOptions {
std::optional m_file;
std::optional m_style;
lldb::ProcessSP m_process_sp;
- std::unordered_set m_threads_to_save;
+ std::unordered_map m_threads_to_save;
clayborg wrote:
You can remove this change right? You c
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/122541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/5] Make the thread list for SBSaveCoreOptions iterable
---
ll
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/4] Make the thread list for SBSaveCoreOptions iterable
---
ll
Jlalond wrote:
@clayborg and I chatted offline. The need for indexable access wasn't as
important as exposing an enumeration of threads. So we instead return a copy of
the thread list in an SBThreadCollection.
https://github.com/llvm/llvm-project/pull/122541
___
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/3] Make the thread list for SBSaveCoreOptions iterable
---
ll
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 91892e8fa3830ed6590eda0bc62e2a2ea8df8872
d848e954f969fcbb1d09b8dcca328dc1854337a8 --e
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/3] Make the thread list for SBSaveCoreOptions iterable
---
ll
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/119764
>From b41b19c7b9bf5a784914e662b7485ac96c2ccdc4 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 12 Dec 2024 13:20:37 -0800
Subject: [PATCH 1/2] The _code field in an NSError is signed, not unsigned.
---
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 commented:
LLDB changes LGTM
https://github.com/llvm/llvm-project/pull/122289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -47,6 +46,9 @@ class SaveCoreOptions {
void AddMemoryRegionToSave(const lldb_private::MemoryRegionInfo ®ion);
+ std::optional GetThreadAtIndex(uint32_t idx) const;
Jlalond wrote:
We can, I'm personally willing to trade the complexity for the performanc
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/119764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/119764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere approved this pull request.
LGTM but please give @Michael137 a chance to take a look as this is his area of
expertise.
https://github.com/llvm/llvm-project/pull/122289
___
https://github.com/JDevlieghere commented:
Please add a test to `ArchSpecTest.cpp`.
https://github.com/llvm/llvm-project/pull/122533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/2] Make the thread list for SBSaveCoreOptions iterable
---
ll
@@ -47,6 +46,9 @@ class SaveCoreOptions {
void AddMemoryRegionToSave(const lldb_private::MemoryRegionInfo ®ion);
+ std::optional GetThreadAtIndex(uint32_t idx) const;
clayborg wrote:
We don't need optional if `lldb::ThreadSP` is what is returned, just ret
@@ -111,6 +111,21 @@ class LLDB_API SBSaveCoreOptions {
/// style specific regions.
SBError AddMemoryRegionToSave(const SBMemoryRegionInfo ®ion);
+ /// Get the number of Threads to be saved
+ ///
+ /// \returns
+ /// The count of Threads to be saved.
+ uint32_t Get
@@ -87,12 +87,33 @@ Status SaveCoreOptions::AddThread(lldb::ThreadSP thread_sp)
{
m_process_sp = thread_sp->GetProcess();
}
- m_threads_to_save.insert(thread_sp->GetID());
+ m_threads_to_save.insert({thread_sp->GetID(), thread_sp});
+ m_thread_indexes.push_back(threa
@@ -100,6 +100,19 @@ SBSaveCoreOptions::AddMemoryRegionToSave(const
SBMemoryRegionInfo ®ion) {
return SBError();
}
+uint32_t lldb::SBSaveCoreOptions::GetNumThreads() const {
+ LLDB_INSTRUMENT_VA(this);
+ return m_opaque_up->GetNumThreads();
+}
+
+SBThread SBSaveCoreOption
@@ -111,6 +111,21 @@ class LLDB_API SBSaveCoreOptions {
/// style specific regions.
SBError AddMemoryRegionToSave(const SBMemoryRegionInfo ®ion);
+ /// Get the number of Threads to be saved
+ ///
+ /// \returns
+ /// The count of Threads to be saved.
+ uint32_t Get
@@ -56,8 +58,10 @@ class SaveCoreOptions {
std::optional m_file;
std::optional m_style;
lldb::ProcessSP m_process_sp;
- std::unordered_set m_threads_to_save;
+ std::unordered_map m_threads_to_save;
clayborg wrote:
Not sure if we need this complexity of
@@ -87,12 +87,33 @@ Status SaveCoreOptions::AddThread(lldb::ThreadSP thread_sp)
{
m_process_sp = thread_sp->GetProcess();
}
- m_threads_to_save.insert(thread_sp->GetID());
+ m_threads_to_save.insert({thread_sp->GetID(), thread_sp});
+ m_thread_indexes.push_back(threa
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/122541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This patch adds the ability to get a thread at a give index, based on insertion
order, for SBSaveCore Options. This is primarily to benefit scripts using
SBSaveCore, and remove the need to have both options
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/122541
This patch adds the ability to get a thread at a give index, based on insertion
order, for SBSaveCore Options. This is primarily to benefit scripts using
SBSaveCore, and remove the need to have both options and
https://github.com/brad0 updated
https://github.com/llvm/llvm-project/pull/122534
>From ed0cceef34f81d4a2544aa6aa8b51afa0fc92959 Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Thu, 2 Jan 2025 06:50:38 -0500
Subject: [PATCH] [lldb][OpenBSD] Fixes for process handling
---
lldb/source/Host/open
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This fixes a typo when creating a target from the crashlog script and that we
were not able to find a valid architecture from the crash report.
rdar://137344016
---
Full diff: https://github.com/l
https://github.com/chelcassanova approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/122514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/122514
This fixes a typo when creating a target from the crashlog script and that we
were not able to find a valid architecture from the crash report.
rdar://137344016
>From 4b25769382f81fd03553703624e8b8e48d83a
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope {
/// The section offset based address for this function.
Function(CompileUnit *comp_unit, lldb::user_id_t func_uid,
lldb::user_id_t func_type_uid, const Mangled &mangled,
-
@@ -2393,10 +2393,29 @@ Function *DWARFASTParserClang::ParseFunctionFromDWARF(
assert(func_type == nullptr || func_type != DIE_IS_BEING_PARSED);
const user_id_t func_user_id = die.GetID();
+
+// The base address of the scope for any of the debugging information
+
zwuis wrote:
Do we need a test case about explicit object member function? i.e.
```cpp
template int get(this triple);
template<> int get<0>(this triple t) { return /* ... */; }
```
https://github.com/llvm/llvm-project/pull/122265
___
lldb-commits maili
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope {
/// The section offset based address for this function.
Function(CompileUnit *comp_unit, lldb::user_id_t func_uid,
lldb::user_id_t func_type_uid, const Mangled &mangled,
-
@@ -3,17 +3,30 @@
# int baz();
# int bar() { return 47; }
# int foo(int flag) { return flag ? bar() : baz(); }
-# The function bar has been placed "in the middle" of foo.
+# The function bar has been placed "in the middle" of foo, and the function
+# entry point is deliberately
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope {
/// The section offset based address for this function.
Function(CompileUnit *comp_unit, lldb::user_id_t func_uid,
lldb::user_id_t func_type_uid, const Mangled &mangled,
-
Author: Pavel Labath
Date: 2025-01-10T13:21:58+01:00
New Revision: f44ed64864642b008f0c757a5ff37c150ce47d48
URL:
https://github.com/llvm/llvm-project/commit/f44ed64864642b008f0c757a5ff37c150ce47d48
DIFF:
https://github.com/llvm/llvm-project/commit/f44ed64864642b008f0c757a5ff37c150ce47d48.diff
DhruvSrivastavaX wrote:
Okay great. Thanks for explaining that!
I'll make sure that the final story reads well. (Especially if we go from X to
!X 🙂 )
And its always a plus to add footnotes to the post-merge discussion in such
cases.
https://github.com/llvm/llvm-project/pull/122301
__
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/122440
>From be424b1e32f0bc69d01bd582e1de51b66b920b25 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 10 Jan 2025 10:44:53 +0100
Subject: [PATCH 1/2] [lldb] Use the first address range as the function
address
T
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 66a88f62cd56e55b5fa0ddb1bdffa549f7565f8f
be424b1e32f0bc69d01bd582e1de51b66b920b25 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is the behavior expected by DWARF. It also requires some fixups to
algorithms which were storing the addresses of some objects (Blocks and
Variables) relative to the beginning of the function.
There are
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/122440
This is the behavior expected by DWARF. It also requires some fixups to
algorithms which were storing the addresses of some objects (Blocks and
Variables) relative to the beginning of the function.
There are pl
DavidSpickett wrote:
You can never 100% trust anything that isn't the code (and even then, be
careful), but it is nice when the descriptions are at least helpful.
https://github.com/llvm/llvm-project/pull/122301
___
lldb-commits mailing list
lldb-comm
DavidSpickett wrote:
This is actually a common point of confusion, the LLVM repo is setup to create
the final commit message from the PR description, not the commit(s) message(s)
in the PR itself. I guess because A: the PR description is easier to edit and
B: we always squash before merging, s
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/122420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
> In future, please remember to remove anything from the commit message that
> was purely for the review process, or generally no longer applies to the code
> being landed. GitHub gives you a chance to do this just before the PR is
> merged.
>
> In this case it just me
DavidSpickett wrote:
In future, please remember to remove anything from the commit message that was
purely for the review process, or generally no longer applies to the code being
landed. GitHub gives you a chance to do this just before the PR is merged.
In this case it just meant I got an ext
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/115836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-01-10T09:56:55+01:00
New Revision: 66a88f62cd56e55b5fa0ddb1bdffa549f7565f8f
URL:
https://github.com/llvm/llvm-project/commit/66a88f62cd56e55b5fa0ddb1bdffa549f7565f8f
DIFF:
https://github.com/llvm/llvm-project/commit/66a88f62cd56e55b5fa0ddb1bdffa549f7565f8f.diff
labath wrote:
The reason I picked this name is to match Symbol::GetAddress.
https://github.com/llvm/llvm-project/pull/115836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Yes, that's the general idea. Just add a comment about why this is being done.
If this ends up failing in some configuration, there are plenty of other (more
indirect) ways of pulling in this symbol that we can try.
https://github.com/llvm/
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/122273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-01-10T09:23:52+01:00
New Revision: 05dfbc146d87866f0ef22dc88f729b5b9fdfe1a0
URL:
https://github.com/llvm/llvm-project/commit/05dfbc146d87866f0ef22dc88f729b5b9fdfe1a0
DIFF:
https://github.com/llvm/llvm-project/commit/05dfbc146d87866f0ef22dc88f729b5b9fdfe1a0.diff
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/122420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
66 matches
Mail list logo
