Author: Pavel Labath Date: 2025-01-10T09:23:52+01:00 New Revision: 05dfbc146d87866f0ef22dc88f729b5b9fdfe1a0
URL: https://github.com/llvm/llvm-project/commit/05dfbc146d87866f0ef22dc88f729b5b9fdfe1a0 DIFF: https://github.com/llvm/llvm-project/commit/05dfbc146d87866f0ef22dc88f729b5b9fdfe1a0.diff LOG: [lldb] Regularize DWARFDIE::Get{TypeLookup,Decl}Context names (#122273) The functions call GetName for everything except variables, where they call GetPubname instead. The difference is that the latter prefers to return the linkage name, if it is available. This doesn't seem particularly useful given that the linkage name already kind of contains the context of the variable, and I doubt that anything depends on it as these functions are currently called on type and subprogram DIEs -- not variables. This makes it easier to simplify/deduplicate these functions later. Added: Modified: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp index 96b13efe583513..4b864b549f8ce6 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp @@ -412,7 +412,7 @@ static void GetDeclContextImpl(DWARFDIE die, push_ctx(CompilerContextKind::Function, die.GetName()); break; case DW_TAG_variable: - push_ctx(CompilerContextKind::Variable, die.GetPubname()); + push_ctx(CompilerContextKind::Variable, die.GetName()); break; case DW_TAG_typedef: push_ctx(CompilerContextKind::Typedef, die.GetName()); @@ -457,7 +457,7 @@ static void GetTypeLookupContextImpl(DWARFDIE die, push_ctx(CompilerContextKind::Enum, die.GetName()); break; case DW_TAG_variable: - push_ctx(CompilerContextKind::Variable, die.GetPubname()); + push_ctx(CompilerContextKind::Variable, die.GetName()); break; case DW_TAG_typedef: push_ctx(CompilerContextKind::Typedef, die.GetName()); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
