DavidSpickett wrote: This is actually a common point of confusion, the LLVM repo is setup to create the final commit message from the PR description, not the commit(s) message(s) in the PR itself. I guess because A: the PR description is easier to edit and B: we always squash before merging, so the combination of the commit messages rarely makes any sense.
So when you merge, GitHub starts with the PR description, then lets you edit from there, but it doesn't write back any changes to the PR description. So you can leave it as is if you want to. The main thing to think about is: would anything here mislead a future reader? And for this PR no, it's just a few extra GitHub pings. But for example if you posted a PR to do X but were persuaded by reviewers to do !X, it will save confusion later if you update the descriptions. And if you do push some misleading commit message (we all do it sometimes) you can always leave comments on the PR. We do that for reverts and post commit review also. https://github.com/llvm/llvm-project/pull/122301 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
