@@ -3265,18 +3275,25 @@ Status Process::PrivateResume() {
// (suspended/running/stepping). Threads should also check their resume
// signal in lldb::Thread::GetResumeSignal() to see if they are supposed to
// start back up with a signal.
-if (m_thread_list.WillR
@@ -1363,9 +1375,51 @@ Status ProcessGDBRemote::DoResume() {
}
}
+if (direction == RunDirection::eRunReverse && continue_packet_error) {
+ if (num_continue_C_tids > 0 || num_continue_S_tids > 0) {
+LLDB_LOGF(log,
+ "ProcessGDBRemote:
@@ -236,11 +236,18 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
return error;
}
-Status ProcessWindows::DoResume() {
+Status ProcessWindows::DoResume(RunDirection direction) {
Log *log = GetLog(WindowsLog::Process);
llvm::sys::ScopedLock lock(m_mutex);
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/119934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-12-13T16:09:31-08:00
New Revision: f22cff7675f7f64aa52204f4426f5047cc75fbb9
URL:
https://github.com/llvm/llvm-project/commit/f22cff7675f7f64aa52204f4426f5047cc75fbb9
DIFF:
https://github.com/llvm/llvm-project/commit/f22cff7675f7f64aa52204f4426f5047cc75fbb9.diff
https://github.com/kastiglione approved this pull request.
https://github.com/llvm/llvm-project/pull/119934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/119934.diff
3 Files Affected:
- (modified) lldb/source/DataFormatters/FormatterSection.cpp (+7)
- (modified)
lldb/test/API/functionalities/
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/119934
None
>From 373a93b56b415003bff8ca0ae9de85c820c87036 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 13 Dec 2024 15:00:19 -0800
Subject: [PATCH] [lldb] Support zero-padding in formatter sections
-
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/119914
>From f6fdfaf4be339a6412019113462b05cbce66c753 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:54:07 -0800
Subject: [PATCH 1/2] [lldb] Use the terminal height for paging editline
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
attrs.is_forward_declaration = true;
}
+ DWARFDIE def_die;
+ if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) {
+def_die = dwarf->FindDefinitionDIE(die
ZequanWu wrote:
> Since there's no good way to tell whether a forward declaration is an
> Objective-C type, the only solution I can really see here is to eagerly fetch
> the definition for Objective-C types.
That makes sense.
https://github.com/llvm/llvm-project/pull/119860
__
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/119914
>From f6fdfaf4be339a6412019113462b05cbce66c753 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:54:07 -0800
Subject: [PATCH 1/2] [lldb] Use the terminal height for paging editline
DavidSpickett wrote:
Formatting existing comments is fine to include here.
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -919,7 +937,11 @@ Debugger::Debugger(lldb::LogOutputCallback log_callback,
void *baton)
m_collection_sp->GetPropertyAtIndexAsOptionValueUInt64(
ePropertyTerminalWidth);
term_width->SetMinimumValue(10);
- term_width->SetMaximumValue(1024);
adrian-prantl wrote:
> Yeah, I don’t disagree with that - and we’re at C++17 now already. Anyway,
> requiring 10.12 from 2016 seems reasonable to me.
Especially since nobody needs to run LLDB locally in order to do debugging. If
you really want to debug with the very latest LLDB on a 10 year o
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/119914
Currently, we arbitrarily paginate editline completions to 40 elements. On
large terminals, that leaves some real-estate unused. On small terminals, it's
pretty annoying to not see the first completions. W
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/119914
>From f6fdfaf4be339a6412019113462b05cbce66c753 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:54:07 -0800
Subject: [PATCH] [lldb] Use the terminal height for paging editline
com
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Currently, we arbitrarily paginate editline completions to 40 elements. On
large terminals, that leaves some real-estate unused. On small terminals, it's
pretty annoying to not see the first complet
mstorsjo wrote:
> When we decided to allow C++11 usage in lldb I think we opted into requiring
> platforms that have relatively complete support for the C++11 additions. I
> don't think it makes sense to try to limit the use of C++11 to some "minimal
> supported subset".
Yeah, I don’t disagre
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
attrs.is_forward_declaration = true;
}
+ DWARFDIE def_die;
+ if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) {
+def_die = dwarf->FindDefinitionDIE(die
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
attrs.is_forward_declaration = true;
}
+ DWARFDIE def_die;
+ if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) {
adrian-prantl wrote:
Woul
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
attrs.is_forward_declaration = true;
}
+ DWARFDIE def_die;
+ if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) {
adrian-prantl wrote:
You'
jimingham wrote:
When we decided to allow C++11 usage in lldb I think we opted into requiring
platforms that have relatively complete support for the C++11 additions. I
don't think it makes sense to try to limit the use of C++11 to some "commonly
supported subset".
https://github.com/llvm/
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -81,9 +79,44 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 1/9] Added XCOFF Header Parsing
---
.../ObjectFile/
Author: Adrian Prantl
Date: 2024-12-13T09:09:57-08:00
New Revision: 3fcc302af34f648fb7a56557b6a504fcbf49a115
URL:
https://github.com/llvm/llvm-project/commit/3fcc302af34f648fb7a56557b6a504fcbf49a115
DIFF:
https://github.com/llvm/llvm-project/commit/3fcc302af34f648fb7a56557b6a504fcbf49a115.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/119757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/119757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 1/8] Added XCOFF Header Parsing
---
.../ObjectFile/
DhruvSrivastavaX wrote:
Yes, I was trying to resolve a couple of conflicts in a better way, since the
branch had diverged quite some time back.
Thanks for the squash and merge!
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mail
DavidSpickett wrote:
@DhruvSrivastavaX I realised I can do the squash when I merge it. I was
confused by seeing so many commits here but the final changes are correct
anyway.
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing l
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dhruv Srivastava
Date: 2024-12-13T16:54:54Z
New Revision: fb02c33605bd988e9c6bb3a18cd7f0c3b1f20d5c
URL:
https://github.com/llvm/llvm-project/commit/fb02c33605bd988e9c6bb3a18cd7f0c3b1f20d5c
DIFF:
https://github.com/llvm/llvm-project/commit/fb02c33605bd988e9c6bb3a18cd7f0c3b1f20d5c.diff
L
DhruvSrivastavaX wrote:
Let me give it a try manually
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Not a problem, I probably just got a bit excited 😛
Fixed it now.
For the rebase, I am unable to select the update with rebase option for some
reason(??)
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailin
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/119892
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 01/12] Added XCOFF Header Parsing
---
.../ObjectFil
DavidSpickett wrote:
Please rebase this so it is just one commit to merge into `main`, and limit it
just to the clang-format changes.
(if I implied it should include the new comments, my apologies)
https://github.com/llvm/llvm-project/pull/119892
___
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/119892
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 01/11] Added XCOFF Header Parsing
---
.../ObjectFil
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/119892
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
@@ -10,16 +10,14 @@
#ifndef LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
#define LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
-#include
-
-#include
-
#include "lldb/Symbol/ObjectFile.h"
#include "lldb/Utility/ArchSpec.h"
#include "lldb/Utility/FileSpec
@@ -13,7 +13,7 @@ FileHeader:
MagicNumber: 0x1F7
NumberOfSections: 1
CreationTime:0
- Flags: 0x
+ Flags: 0x0002
DavidSpickett wrote:
Ok thanks.
I don't see any test files with comments here, they mostly use the
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -10,16 +10,14 @@
#ifndef LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
#define LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
-#include
-
-#include
-
#include "lldb/Symbol/ObjectFile.h"
#include "lldb/Utility/ArchSpec.h"
#include "lldb/Utility/FileSpec
@@ -13,7 +13,7 @@ FileHeader:
MagicNumber: 0x1F7
NumberOfSections: 1
CreationTime:0
- Flags: 0x
+ Flags: 0x0002
DhruvSrivastavaX wrote:
Yes, that is the exact reason for this change. A 2 here implies that it is
@@ -27,6 +30,31 @@
using namespace lldb_private;
+namespace {
+struct HostInfoPosixFields {
+ llvm::once_flag m_os_version_once_flag;
+ llvm::VersionTuple m_os_version;
+};
+} // namespace
+
+llvm::VersionTuple HostInfoPosix::GetOSVersion() {
+ static HostInfoPosixFields *
@@ -27,6 +30,31 @@
using namespace lldb_private;
+namespace {
+struct HostInfoPosixFields {
+ llvm::once_flag m_os_version_once_flag;
+ llvm::VersionTuple m_os_version;
+};
+} // namespace
+
+llvm::VersionTuple HostInfoPosix::GetOSVersion() {
+ static HostInfoPosixFields *
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
At a glance, this seems like what Pavel (and maybe me, I forget :) ) asked for.
Assuming you have a Linux system to test on, please get this to a reviewable
point. Remove commented code, all that stuff. If the tests still pass, you
should be fine.
T
@@ -10,16 +10,14 @@
#ifndef LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
#define LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
-#include
-
-#include
-
#include "lldb/Symbol/ObjectFile.h"
#include "lldb/Utility/ArchSpec.h"
#include "lldb/Utility/FileSpec
@@ -13,7 +13,7 @@ FileHeader:
MagicNumber: 0x1F7
NumberOfSections: 1
CreationTime:0
- Flags: 0x
+ Flags: 0x0002
DavidSpickett wrote:
Not sure if we're allowed comments in this YAML. But could you at least confir
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -35,6 +29,10 @@
#include "llvm/BinaryFormat/XCOFF.h"
#include "llvm/Object/XCOFFObjectFile.h"
#include "llvm/Support/MemoryBuffer.h"
+#include
+#include
+#include
+#include
DavidSpickett wrote:
Did clang-format do this? If so please put up a PR with jus
https://github.com/DavidSpickett commented:
No big objections just small things.
If you make a clang-format PR add me as a reviewer, I'll get it merged quickly
so you can rebase this.
Seems like the sticking point is create vs. createXCOFFObjectFile and I'll
leave that to you and Pavel to sor
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,119 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DavidSpickett commented:
I don't know if you have worked on LLVM before but regardless, thank you for
making use of the nice error handling patterns we have. Even if sometimes
they're a bit too much.
I don't have any major problems with this, just some style points and a cou
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 1/8] Added XCOFF Header Parsing
---
.../ObjectFile/
@@ -52,13 +52,23 @@ set(LLDB_DEFAULT_TEST_DSYMUTIL
"${LLVM_TOOLS_BINARY_DIR}/dsymutil${CMAKE_EXECUTA
if(LLDB_TEST_MAKE)
set(LLDB_DEFAULT_TEST_MAKE ${LLDB_TEST_MAKE})
else()
- find_program(LLDB_DEFAULT_TEST_MAKE make gmake)
+ # Prefer gmake as it will be a version of GNU ma
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/119573
>From 42fe1cb8dcb131110f18eef23625e3910f795401 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 13 Dec 2024 13:55:23 +
Subject: [PATCH] [lldb][test] Prefer gmake to make and warn for potentiall
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/119573
>From d04d592f825f3f0684a7971d79d58f90044d8e62 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 13 Dec 2024 13:55:23 +
Subject: [PATCH] [lldb][test] Prefer gmake to make and warn for potentiall
https://github.com/labath approved this pull request.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -52,13 +52,23 @@ set(LLDB_DEFAULT_TEST_DSYMUTIL
"${LLVM_TOOLS_BINARY_DIR}/dsymutil${CMAKE_EXECUTA
if(LLDB_TEST_MAKE)
set(LLDB_DEFAULT_TEST_MAKE ${LLDB_TEST_MAKE})
else()
- find_program(LLDB_DEFAULT_TEST_MAKE make gmake)
+ # Prefer gmake as it will be a version of GNU ma
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
DavidSpickett wrote:
Pad with more `-` so that the line is the same length as the next `//===---`
line.
https://github.com/llvm/llvm-project/pull/118160
__
DavidSpickett wrote:
I've updated it as suggested. The non-GUN check isn't great but as long as it
isn't spamming the build logs it should be ok.
FreeBSD make's --version is just an empty string (odd, but ok) and all the GNU
makes I tried all start with "GNU Make".
https://github.com/llvm/llv
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/119377
>From 92fb3703c697d376d95217a48e9c32b920006bd0 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 10 Dec 2024 13:36:29 +0100
Subject: [PATCH 1/2] [lldb] Add ability to rate-limit progress reports
For high-fr
@@ -208,6 +209,110 @@ TEST_F(ProgressReportTest,
TestReportDestructionWithPartialProgress) {
EXPECT_EQ(data->GetMessage(), "Infinite progress: Report 2");
}
+TEST_F(ProgressReportTest, TestFiniteOverflow) {
+ ListenerSP listener_sp = CreateListenerFor(lldb::eBroadcastBitPr
Author: Pavel Labath
Date: 2024-12-13T14:29:59+01:00
New Revision: fb8df8cb658278ceba9ef4b96e0b448aed32c1f6
URL:
https://github.com/llvm/llvm-project/commit/fb8df8cb658278ceba9ef4b96e0b448aed32c1f6
DIFF:
https://github.com/llvm/llvm-project/commit/fb8df8cb658278ceba9ef4b96e0b448aed32c1f6.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/116620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
That's great. Thanks for checking this out.
Closing this patch in favor of https://github.com/llvm/llvm-project/pull/119377.
https://github.com/llvm/llvm-project/pull/118953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/118953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> But yes, It would be great to get inputs from you regarding adding the new
> tests on which I can build on as I proceed.
For this code, I don't think you need to build new tests. We just need to
figure out what it takes to get the existing ones (test/API/tools/lldb-server/)
ru
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/116620
>From 5cca8f301abde9333715e97d671afc23d75b9acd Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 18 Nov 2024 14:33:40 +0100
Subject: [PATCH 1/2] [lldb/DWARF]
s/DWARFRangeList/llvm::DWARFAddressRangeVector
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch essentially reverts the definition DIE delay changes (in
https://github.com/llvm/llvm-project/pull/98361/files) for Objective-C.
The problem we've been seeing is as follows:
1. An Objetive-C cla
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
attrs.is_forward_declaration = true;
}
+ DWARFDIE def_die;
+ if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) {
Michael137 wrote:
This is
1 - 100 of 113 matches
Mail list logo
