llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/112315.diff
1 Files Affected:
- (modified) lldb/source/Commands/CommandObjectMultiword.cpp (+1-10)
``diff
diff --git a/lldb/source/
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/112315
None
>From 70d0a4b3ce6445dd182225df09aecf450b4073ec Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Mon, 14 Oct 2024 23:11:09 -0700
Subject: [PATCH] [lldb] Avoid repeated map lookups (NFC)
---
lldb/so
@@ -1159,7 +1159,9 @@ class ARMOperand : public MCParsedAsmOperand {
if (!isImm()) return false;
const MCConstantExpr *CE = dyn_cast(getImm());
if (!CE) return false;
davemgreen wrote:
Can this check that CE->getActiveBits() > 32?
https://github.c
@@ -0,0 +1,87 @@
+//===-- RegisterContextPOSIXCore_loongarch64.cpp
+//--===//
SixWeining wrote:
format
https://github.com/llvm/llvm-project/pull/112296
___
lldb-commits mailing list
lldb-com
@@ -0,0 +1,62 @@
+//===-- RegisterContextPOSIXCore_loongarch64.h --*- C++
+//-*-===//
SixWeining wrote:
ditto
https://github.com/llvm/llvm-project/pull/112296
___
lldb-commits mailing list
lldb-comm
https://github.com/SixWeining edited
https://github.com/llvm/llvm-project/pull/112296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/SixWeining commented:
@wangleiat may take a look.
https://github.com/llvm/llvm-project/pull/112296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/112301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
shushanhf wrote:
> @shushanhf
@SixWeining
https://github.com/llvm/llvm-project/pull/112296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lawn123 wrote:
@shushanhf
https://github.com/llvm/llvm-project/pull/112296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Liu An (lawn123)
Changes
When using the lldb command 'target create -- core' on the LoongArch64
architecture, this part of the code is required.
---
Full diff: https://github.com/llvm/llvm-project/pull/112296.diff
4 Files Affected:
- (m
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/lawn123 created
https://github.com/llvm/llvm-project/pull/112296
When using the lldb command 'target create -- core' on the LoongArch64
architecture, this part of the code is required.
>From ba485de763a08f6ff3c7468c1a1bfbbfb25ac48f Mon Sep 17 00:00:00 2001
From: Liu An
Date
https://github.com/vvereschaka closed
https://github.com/llvm/llvm-project/pull/111977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vladislav Dzhidzhoev
Date: 2024-10-14T17:35:55-07:00
New Revision: 1cb83147801a4b4bac193e1aa94a05853ab09c68
URL:
https://github.com/llvm/llvm-project/commit/1cb83147801a4b4bac193e1aa94a05853ab09c68
DIFF:
https://github.com/llvm/llvm-project/commit/1cb83147801a4b4bac193e1aa94a05853ab09c6
vvereschaka wrote:
@dzhidzhoev is sick. I'll merge this MR for him.
https://github.com/llvm/llvm-project/pull/111977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/112260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-14T17:06:02-07:00
New Revision: 8225938a73406f26e599c7a55fa019422fe18369
URL:
https://github.com/llvm/llvm-project/commit/8225938a73406f26e599c7a55fa019422fe18369
DIFF:
https://github.com/llvm/llvm-project/commit/8225938a73406f26e599c7a55fa019422fe18369.d
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/112260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/111891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
This does require us to walk the stack backwards instead of just taking the
`0th` frame
https://github.com/llvm/llvm-project/pull/111601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
Author: Jonas Devlieghere
Date: 2024-10-14T16:57:33-07:00
New Revision: 6539481c8e7a840a41f6835426ddfbcdc234c831
URL:
https://github.com/llvm/llvm-project/commit/6539481c8e7a840a41f6835426ddfbcdc234c831
DIFF:
https://github.com/llvm/llvm-project/commit/6539481c8e7a840a41f6835426ddfbcdc234c831.d
oontvoo wrote:
Can I merge this? Or would anyone else like to have another look/comments?
Thanks!
https://github.com/llvm/llvm-project/pull/111891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
Author: Adrian Prantl
Date: 2024-10-14T16:29:26-07:00
New Revision: 9eddc8b9bf4e4e0b01e2ecc90a71c4b3b4e9c8af
URL:
https://github.com/llvm/llvm-project/commit/9eddc8b9bf4e4e0b01e2ecc90a71c4b3b4e9c8af
DIFF:
https://github.com/llvm/llvm-project/commit/9eddc8b9bf4e4e0b01e2ecc90a71c4b3b4e9c8af.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112109
>From 23e1eeafd84d0f14803da52f89723a3ae257dbb8 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 11 Oct 2024 19:27:37 -0700
Subject: [PATCH] [lldb] Expose structured command diagnostics via the SBAPI
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/112260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -642,26 +652,86 @@ ModuleSP DynamicLoaderDarwin::GetDYLDModule() {
void DynamicLoaderDarwin::ClearDYLDModule() { m_dyld_module_wp.reset(); }
+template
+static std::vector parallel_map(
+llvm::ThreadPoolInterface &threadPool, InputIterator first,
+InputIterator las
adrian-prantl wrote:
> @adrian-prantl do you want the system log to include the dropped errors in
> `Status`. If so we'll need to promote that to use `LLDB_LOG_ERROR` instead.
No, I expect that to be too much traffic in the beginning at least.
https://github.com/llvm/llvm-project/pull/111911
_
@@ -642,26 +652,86 @@ ModuleSP DynamicLoaderDarwin::GetDYLDModule() {
void DynamicLoaderDarwin::ClearDYLDModule() { m_dyld_module_wp.reset(); }
+template
+static std::vector parallel_map(
+llvm::ThreadPoolInterface &threadPool, InputIterator first,
+InputIterator las
Author: Shubham Sandeep Rastogi
Date: 2024-10-14T15:27:05-07:00
New Revision: d8de2391eb014fb3f750f4c38abc101edc1e2cc2
URL:
https://github.com/llvm/llvm-project/commit/d8de2391eb014fb3f750f4c38abc101edc1e2cc2
DIFF:
https://github.com/llvm/llvm-project/commit/d8de2391eb014fb3f750f4c38abc101edc1e
rastogishubham wrote:
Hi this patch broke Unwind/trap_frame_sym_ctx.test in greendragon, you can see
the link to the failing build here:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/6724/consoleFull#-1880437047d6fdb6cb-f376-4f2e-8bce-d31c7304698b
I will be reverting this ch
https://github.com/slydiman approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/98694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Depends on:
- https://github.com/llvm/llvm-project/pull/112260
- https://github.com/llvm/llvm-project/pull/112262
Remaining issues:
- IRDynamicChecks.cpp:333:72: warning: 'InsertPosition' is deprecated: Use
BasicBlock::iterators for insertion instead [-Wdeprecated-declar
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/112276
Currently all of LLDB is being compiled with -Wno-deprecated-declarations.
That's not desirable, especially as part of the LLVM monorepo, as we miss
deprecation warnings from LLVM and clang.
According to
https://github.com/DmT021 edited
https://github.com/llvm/llvm-project/pull/110646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -642,26 +652,86 @@ ModuleSP DynamicLoaderDarwin::GetDYLDModule() {
void DynamicLoaderDarwin::ClearDYLDModule() { m_dyld_module_wp.reset(); }
+template
+static std::vector parallel_map(
+llvm::ThreadPoolInterface &threadPool, InputIterator first,
+InputIterator las
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/112262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-14T14:30:32-07:00
New Revision: 9cc6e6f71c117c3c47f3eee253c8a429118c11e5
URL:
https://github.com/llvm/llvm-project/commit/9cc6e6f71c117c3c47f3eee253c8a429118c11e5
DIFF:
https://github.com/llvm/llvm-project/commit/9cc6e6f71c117c3c47f3eee253c8a429118c11e5.d
jasonmolenda wrote:
@DmT021 I will, can you edit the Description in this PR for the commit message
that will be recorded?
https://github.com/llvm/llvm-project/pull/110646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/jasonmolenda approved this pull request.
LGTM, honestly i'm not sure we even use `ListApplications` in debugserver any
longer, but this looks correct.
https://github.com/llvm/llvm-project/pull/112262
___
lldb-commits mailing list
ll
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/112262
>From 325d131bd24947a9be1f50a22ca9600c19c8dc84 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 14 Oct 2024 14:19:24 -0700
Subject: [PATCH] [lldb] Use CFPropertyListCreateData in debugserver (NFC
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
CFPropertyListCreateXMLData has been deprecated since macOS 10.10. Use
CFPropertyListCreateData instead.
---
Full diff: https://github.com/llvm/llvm-project/pull/112262.diff
4 Files Affected:
- (
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/112262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/112262
CFPropertyListCreateXMLData has been deprecated since macOS 10.10. Use
CFPropertyListCreateData instead.
>From 9048d3a65e9478d5b25338bef656f69c2fc65969 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Dat
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Remove support for ASL (Apple System Log) which has been deprecated since macOS
10.12. Fixes the following warnings:
warning: 'asl_new' is deprecated: first deprecated in macOS 10.12 - os_log(3)
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/112260
Remove support for ASL (Apple System Log) which has been deprecated since macOS
10.12. Fixes the following warnings:
warning: 'asl_new' is deprecated: first deprecated in macOS 10.12 - os_log(3)
has rep
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/111601
>From 2d693e8208ea99fc57b1137668ee0e12777ab767 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 8 Oct 2024 15:52:45 -0700
Subject: [PATCH 1/7] Create new extension for save core to save a thread and N
po
keith wrote:
Oh yea great point. I guess another way to put that is if I copy the exact same
invocation and run it directly it works, so that differing is unexpected.
https://github.com/llvm/llvm-project/pull/112107
___
lldb-commits mailing list
lldb
DmT021 wrote:
@jasonmolenda All the tests are green but I don't have the merge button. Can
you merge it, please?
https://github.com/llvm/llvm-project/pull/110646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
rocallahan wrote:
> I'd say that this is failing because macos generates slightly different
> packet sequences, and the test is not expecting those.
Makes sense. But given Mac tests don't run against PRs, and I don't have a Mac,
how am I supposed to debug this?
https://github.com/llvm/llvm-pr
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
zeroomega wrote:
> In fact, I ran into that on Friday myself. I checked `LLDB_INCLUDE_TESTS=Off`
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/111977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with the other comments addressed.
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
kastiglione wrote:
> so they know they have to escape it depending on their use case
in the example shown, `"some arg?"` is quoted, which normally escapes a glob.
Do we really need to force an additional level of escaping on users? Hopefully
not but I can see that this is tricky.
https://gith
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) {
}
}
-llvm::StringRef
-CommandReturnObject::GetInlineDiagnosticString(unsigned indent) {
- RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics);
+std::string CommandReturnObject::Get
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
@@ -136,6 +136,8 @@ class LLDB_API SBWatchpoint;
class LLDB_API SBWatchpointOptions;
class LLDB_API SBUnixSignals;
+typedef SourceLanguageName SBSourceLanguageName;
bulbazord wrote:
I'm not sure a typedef is enough here. It ends up being little more than
syn
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/111929
>From 5744d94fa7aaa8e8a800f929dfaf6baeb5670e03 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 14 Oct 2024 10:41:36 -0700
Subject: [PATCH] [lldb] Move SBLanguages.h out of API tree
This patch
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) {
}
}
-llvm::StringRef
-CommandReturnObject::GetInlineDiagnosticString(unsigned indent) {
- RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics);
+std::string CommandReturnObject::Get
@@ -3187,11 +3185,12 @@ void
CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler,
io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) ||
io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) {
// Display any inline diagnostics first.
-
@@ -2636,20 +2636,18 @@ void CommandInterpreter::HandleCommands(const
StringList &commands,
}
if (!success || !tmp_result.Succeeded()) {
- llvm::StringRef error_msg = tmp_result.GetErrorString();
+ std::string error_msg = tmp_result.GetErrorString();
JDevlieghere wrote:
Let me try to provide a bit more context. Darwin has the concept of a
[sysdiagnose](https://it-training.apple.com/tutorials/support/sup075/). It's
essentially an archive with diagnostic files, including crashlogs and a dump of
the last few minutes of the system log. On our
shafik wrote:
This crash is due to this set of changes:
https://github.com/llvm/llvm-project/issues/11
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -45,13 +45,14 @@ class LLDB_API SBCommandReturnObject {
const char *GetOutput();
const char *GetError();
+ SBStructuredData GetErrorData();
#ifndef SWIG
LLDB_DEPRECATED_FIXME("Use PutOutput(SBFile) or PutOutput(FileSP)",
"PutOutput(SBFile
medismailben wrote:
ditto (line returns)
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -184,53 +184,26 @@ def test_source_locations_from_objc_modules(self):
# the first argument are probably stable enough that this test can
check for them.
self.assertIn("void NSLog(NSString *format",
value.GetError().GetCString())
-def test_command_expr_
@@ -485,35 +485,8 @@ bool
CommandObjectExpression::EvaluateExpression(llvm::StringRef expr,
result.SetStatus(eReturnStatusSuccessFinishResult);
} else {
-// Retrieve the diagnostics.
-std::vector details;
-llvm::consumeError(llvm::handleE
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitrii Galimzianov (DmT021)
Changes
This is another approach to the goal described in [this
PR](https://github.com/llvm/llvm-project/pull/110439). This PR is provided just
for convenience.
---
Patch is 23.83 KiB, truncated to 20.00 KiB
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/111409
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-10-14T18:56:37+02:00
New Revision: a89e01634fe2e6ce0b967ead24280b6693b523dc
URL:
https://github.com/llvm/llvm-project/commit/a89e01634fe2e6ce0b967ead24280b6693b523dc
DIFF:
https://github.com/llvm/llvm-project/commit/a89e01634fe2e6ce0b967ead24280b6693b523dc.diff
labath wrote:
Yeah, I plan to look into Function::GetAddressRange and see how we can make it
do something reasonable for these kinds of functions (probably by having it
return a list of ranges). That will likely involve looking at the users of that
API as well, although I'm less than enthusias
keith wrote:
hmm good point. I wonder if the fix here should be around surfacing the error
to users then, so they know they have to escape it depending on their use case
https://github.com/llvm/llvm-project/pull/112107
___
lldb-commits mailing list
ll
https://github.com/DmT021 updated
https://github.com/llvm/llvm-project/pull/110646
>From 64a4d69d1bb3f32c4b303d6f45b45cdf513183c2 Mon Sep 17 00:00:00 2001
From: Dmitrii Galimzianov
Date: Sun, 29 Sep 2024 22:24:19 +0200
Subject: [PATCH 1/2] DynamicLoaderDarwin load images in parallel
---
.../D
https://github.com/DmT021 ready_for_review
https://github.com/llvm/llvm-project/pull/110646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -70,6 +70,8 @@ class CommandObjectMultiword : public CommandObject {
return m_subcommand_dict;
}
+ std::string GetTopSubcommands(int count);
jimingham wrote:
Sure, that's fine too.
https://github.com/llvm/llvm-project/pull/111891
__
jasonmolenda wrote:
Sounds good, I agree. I marked
https://github.com/llvm/llvm-project/pull/110646 as approved, please merge at
your convenience. Thanks again for spotting this opportunity for
multithreading and seeing it through!
https://github.com/llvm/llvm-project/pull/110439
__
https://github.com/jasonmolenda approved this pull request.
Most of the review and discussion happened in the "non-preload" version of the
PR ( https://github.com/llvm/llvm-project/pull/110439 ), but I agree with
Dmitrii that this is the best approach to merge, this is approved. Very nice
job
https://github.com/jimingham commented:
LGTM
https://github.com/llvm/llvm-project/pull/112062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
The best I can reconstruct, these were GetData because of the StreamString API
name. That's not a good reason, and after all they do return strings, so this
makes sense.
https://github.com/llvm/llvm-project/pull/112062
___
lldb-comm
@@ -194,28 +194,54 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
@@ -194,28 +194,54 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
@@ -70,6 +70,8 @@ class CommandObjectMultiword : public CommandObject {
return m_subcommand_dict;
}
+ std::string GetTopSubcommands(int count);
oontvoo wrote:
P.S: Actually, didn't end up renaming it Jim's suggestion, but to something
else, hopefully
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/111891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DmT021 wrote:
> I think that's where the real perf difference you were measuring kicked in
> (you showed a 10.5 second versus 13.4 second time difference for preload
> versus parallel in the beginning), do I have that right?
That's right.
> Do you prefer the non-preload approach?
No, I thin
DavidSpickett wrote:
> Log errors to the system log if they would otherwise get dropped
Dropped because of what exactly, because the user did not enable a channel that
would include them? How does one enable collection of these with the current
lldb?
> @DavidSpickett, do you have any thoughts
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/111891
>From 4493bf07c8b18dac39a2a421f97fa34cd15a6031 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 10 Oct 2024 14:48:08 -0400
Subject: [PATCH 1/4] [LLDB]Provide clearer error message for invalid commands.
Somet
@@ -0,0 +1,8 @@
+# UNSUPPORTED: system-windows
+#
+# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out
+# RUN: not %lldb -b -o 'breakpoint foo' %t.out -o exit 2>&1 | FileCheck %s
--check-prefix BP-MSG
+# RUN: not %lldb -b -o 'watchpoint set foo' %t.out -o exit 2>&1 | FileCheck %
@@ -194,28 +194,54 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
dtcxzyw wrote:
`APInt::getAllOnes` will assert if `BitWidth == 0`.
```
[--] 6 tests from APFloatTest
[ RUN ] APFloatTest.MinimumNumber
[ OK ] APFloatTest.MinimumNumber (0 ms)
[ RUN ] APFloatTest.Float8E8M0FNUValues
ADTTests:
/home/dtcxzyw/WorkSpace/Projects/compilers/llvm
labath wrote:
> Should it work?
It should, and I suspect (I haven't seen the error msg, do you have a link?)
that the problem isn't in this part of the code. If I had to guess, I'd say
that this is failing because macos generates slightly different packet
sequences, and the test is not expect
labath wrote:
> Regarding limiting the output, I'm happy to draw the line at
> `LLDB_LOG_ERRORV`. The system log is pretty cheap on our platform and I
> assumed it's the same on Linux, so personally I would hope it doesn't deter
> anyone from using `LLDB_LOG_ERROR`.
>From the looks of things,
@@ -171,7 +171,7 @@ bool HexagonGenExtract::convert(Instruction *In) {
// this value.
if (!LogicalSR && (SR > SL))
return false;
-APInt A = APInt(BW, ~0ULL).lshr(SR).shl(SL);
+APInt A = APInt(BW, ~0ULL, true).lshr(SR).shl(SL);
RKSimon wrot
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/112052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-14T15:02:02+01:00
New Revision: 3dedcab6d9b660a690d8fe5ddad3d43276a82708
URL:
https://github.com/llvm/llvm-project/commit/3dedcab6d9b660a690d8fe5ddad3d43276a82708
DIFF:
https://github.com/llvm/llvm-project/commit/3dedcab6d9b660a690d8fe5ddad3d43276a82708.d
DavidSpickett wrote:
Merging to fix our Windows bot.
https://github.com/llvm/llvm-project/pull/112052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/112052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dtcxzyw commented:
Middle-end/CodeGen/RISC-V changes LGTM.
https://github.com/llvm/llvm-project/pull/80309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 114 matches
Mail list logo
