https://github.com/jasonmolenda approved this pull request.

Most of the review and discussion happened in the "non-preload" version of the 
PR ( https://github.com/llvm/llvm-project/pull/110439 ), but I agree with 
Dmitrii that this is the best approach to merge, this is approved.  Very nice 
job spotting a prime opportunity for multithreading, thanks for doing the work 
to implement it.  I think for native macOS debugging (with all binaries in the 
same shared cache as lldb's) we're seeing some less than optimal results so 
we've got a bottleneck that I'll try to look into, I suspect maybe related to 
how we find binaries in our shared cache.  This is still a speedup or 
not-slower result in every use case I tried.

https://github.com/llvm/llvm-project/pull/110646
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to