[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-09-21 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: @clayborg @jimingham Can I please have some love? I don't want to keep telling users "you should be using GDB" and I've done a significant amount of work here. https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From a7876a20b5caa53dace056c84a1b7f1e798088f0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/4] [lldb-dap] Implement value locations for function

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/5] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,67 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class LibCxxInternalsRecognizerTestCase(TestBase): +NO_DEBUG_INFO_TESTCASE = True + +@add_test_categories(["libc++"]) +

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-21 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread A. Jiang via lldb-commits
@@ -0,0 +1,67 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class LibCxxInternalsRecognizerTestCase(TestBase): +NO_DEBUG_INFO_TESTCASE = True + +@add_test_categories(["libc++"]) +

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (#73393) (PR #109531)

2024-09-21 Thread Gregory Ling via lldb-commits
glingy wrote: Created by mistake, current main works fine. https://github.com/llvm/llvm-project/pull/109531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (#73393) (PR #109531)

2024-09-21 Thread Gregory Ling via lldb-commits
https://github.com/glingy closed https://github.com/llvm/llvm-project/pull/109531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (#73393) (PR #109531)

2024-09-21 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (#73393) (PR #109531)

2024-09-21 Thread Gregory Ling via lldb-commits
https://github.com/glingy created https://github.com/llvm/llvm-project/pull/109531 None >From 1d39760e03c78d7c5ef68d947f560dc00900078d Mon Sep 17 00:00:00 2001 From: Gregory Ling <17791817+gli...@users.noreply.github.com> Date: Sat, 21 Sep 2024 10:47:05 -0500 Subject: [PATCH] Change error colum

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/4] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > We really should add a "disable" to the frame recognizers Merged #109219 > I wonder if a heuristic for the callback case could be: mark all but the > first libc++ entry point as an implementation detail. Would this be even more > aggressive? Also, the implementation of t

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 65c57066e099fe7f1357485cd6c4fb068bc82323 d31e3c541cab88c1b7589120a6eed88c667e1191 --e

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/3] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes The `enable` prefix is a filler word which adds no additional information. Rename the setting to `displayExtendedBacktrace` Given that this setitng was only introduced a month ago, and that there

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109521 The `enable` prefix is a filler word which adds no additional information. Rename the setting to `displayExtendedBacktrace` Given that this setitng was only introduced a month ago, and that there has not