@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jasonmolenda wrote:
David, no need to test this latest fix unless you'd like to - I'll make sure it
compiles on an aarch64 ubuntu VM but the fix is obvious once we were looking at
the right place, and explains the behavior you saw earlier, I'm pretty
confident. I need to figure out the debugi
Author: Jason Molenda
Date: 2024-08-07T17:35:17-07:00
New Revision: cf56e265e4b74799aee72a04b634fcc261078084
URL:
https://github.com/llvm/llvm-project/commit/cf56e265e4b74799aee72a04b634fcc261078084
DIFF:
https://github.com/llvm/llvm-project/commit/cf56e265e4b74799aee72a04b634fcc261078084.diff
jasonmolenda wrote:
> // Mark the thread as stopped at breakpoint.
> thread.SetStoppedByBreakpoint();
> FixupBreakpointPCAsNeeded(thread);
>
> if (m_threads_stepping_with_breakpoint.find(thread.GetID()) !=
> m_threads_stepping_with_breakpoint.end())
> thread.SetStoppedByTrace()
clayborg wrote:
To extend on Pavel's modification of my idea:
```
class ScriptedPlatform:
def extends_platform_name(self):
'''Get the name of the internal platform this class extends.'''
return "iPhoneOS.platform"
```
Then every function would have 3 variants:
```
def pre_XXX(...):
def
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
Michael137 wrote:
Don't think we really want to support this for non-native environments tbh
https://github.com/llv
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/101934
>From e5a9e2187bf1b5db2c45bb3efafb57b90aab309b Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 7 Aug 2024 16:33:02 -0700
Subject: [PATCH] [lldb/Interpreter] Fix ambiguous partial command resolu
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
ian-twilightcoder wrote:
But you didn't pick up the environment check
https://github.com/llvm/llvm-project/pull/102
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/102309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-08-07T23:59:58+01:00
New Revision: 1cbcf74083e92021472ec9644b88418f377ce550
URL:
https://github.com/llvm/llvm-project/commit/1cbcf74083e92021472ec9644b88418f377ce550
DIFF:
https://github.com/llvm/llvm-project/commit/1cbcf74083e92021472ec9644b88418f377ce550.diff
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
Michael137 wrote:
I already accounted for the version check changes
https://github.com/llvm/llvm-project/pull/1023
Michael137 wrote:
> This really isn't the right approach. `BuiltinHeadersInSystemModules` isn't
> the only important default that the driver sets up. Can we change the
> invocation setup to use clang::createInvocation or
> clang::CompilerInvocation::CreateFromArgs or clang::BuildCompilation? O
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/85260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> > I'd also love to hear other people opinion on extending platforms through
> > ScriptedPlatform (cc @labath @jimingham @JDevlieghere )
>
> I think that having the ability to forward operations to existing platform
> instances would be very useful. If you look at PlatformQem
royitaqi wrote:
> No, I wanted to make sure that scenario worked and that it had a test (since
> we want it to keep working). Looks like you did show that it works, but I
> didn't see a test for that scenario so that it will keep working. Did I miss
> that?
Thanks for confirming the scenario.
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 396343f17b1182ff8ed698beac3f9b93b1d9dabd
6011b7ebfaa3717086251dc61cd0ba32a6b0c3fd --e
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/102223
>From c629defe38a510ffdd23122b2e9cfac68933cf34 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Fri, 2 Aug 2024 06:35:45 -0700
Subject: [PATCH 1/5] [lldb] Allow realpathing support files when resolving
file/line b
Author: Michael Buch
Date: 2024-08-07T23:09:45+01:00
New Revision: c178fea62d3999acd42f3ddfcc8bd436b574cfed
URL:
https://github.com/llvm/llvm-project/commit/c178fea62d3999acd42f3ddfcc8bd436b574cfed
DIFF:
https://github.com/llvm/llvm-project/commit/c178fea62d3999acd42f3ddfcc8bd436b574cfed.diff
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-08-07T15:05:31-07:00
New Revision: aeb1989bb585e216a13fddeaf28887bdf8623075
URL:
https://github.com/llvm/llvm-project/commit/aeb1989bb585e216a13fddeaf28887bdf8623075
DIFF:
https://github.com/llvm/llvm-project/commit/aeb1989bb585e216a13fddeaf28887bdf8623075.d
chelcassanova wrote:
> LGTM! Are these the only callbacks that need to be fully qualified ?
Yes they are, if new callback function pointers are added in the future that
use SB types in their parameter list or as their return type then ideally those
should also be fully namespaced.
https://git
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM! Are these the only callbacks that need to be fully qualified ?
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This commit fully namespaces callback function pointer parameters that are SB
types in `SBDefines` and `lldb-types`.
---
Full diff: https://github.com/llvm/llvm-project/pull/102375.diff
2 Files A
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/102375
This commit fully namespaces callback function pointer parameters that are SB
types in `SBDefines` and `lldb-types`.
>From 6525ca91f6ef49b06613ec6e947f54d3faf73efe Mon Sep 17 00:00:00 2001
From: Chelsea C
jimingham wrote:
> @jimingham
>
> > Have you checked to make sure this also works when there is a source-path
> > mapping in place for the files that also differ by realpath vrs. symlink in
> > the part past the part the source-path mapping substitutes? That might
> > "just work" but it also
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -192,6 +192,10 @@ TargetStats::ToJSON(Target &target,
}
target_metrics_json.try_emplace("sourceMapDeduceCount",
m_source_map_deduce_count);
+ target_metrics_json.try_emplace("sourceRealpathAttemptCount",
jimingham wrote
https://github.com/jimingham deleted
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -192,6 +192,10 @@ TargetStats::ToJSON(Target &target,
}
target_metrics_json.try_emplace("sourceMapDeduceCount",
m_source_map_deduce_count);
+ target_metrics_json.try_emplace("sourceRealpathAttemptCount",
jimingham wrote
jimingham wrote:
It does seem worthwhile to have a test explicitly testing this ordering that
exists among the tests for the command interpreter, rather than having it be a
side-effect test in an unrelated test case.
Other than that, this is fine.
https://github.com/llvm/llvm-project/pull/101
mizvekov wrote:
> We keep track of propagated and inferred nullability annotations in a [side
> data
> structure](https://github.com/google/crubit/blob/main/nullability/type_nullability.h#L185).
> Our approach allows us to save on memory by not actually re-instantiating
> everything with new
Jlalond wrote:
> I saw the msan failure when integrating LLVM into our internal codebase, it
> is a msan-build lldb.
>
> The second error `AssertionError: launching (4) != stopped (5)` occurred in a
> non-msan-build lldb from the upstream repository. And I ran `llvm-lit -sv
> lldb/test/API/fu
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/101237
>From f0cd3ef613b2da145b14a3d79d6810cc19e9b198 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 30 Jul 2024 13:37:44 -0700
Subject: [PATCH 1/7] Impove ObjectFileELF's .dynamic parsing and usage.
This pat
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-08-07T11:21:27-07:00
New Revision: 585523750e2bbe374d1cb3bf4ff9d53de29b9593
URL:
https://github.com/llvm/llvm-project/commit/585523750e2bbe374d1cb3bf4ff9d53de29b9593
DIFF:
https://github.com/llvm/llvm-project/commit/585523750e2bbe374d1cb3bf4ff9d53de29b9593.
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
ian-twilightcoder wrote:
This function got changed in https://github.com/llvm/llvm-project/pull/102239
https://gith
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ian-twilightcoder wrote:
This really isn't the right approach. `BuiltinHeadersInSystemModules` isn't the
only important default that the driver sets up. Can we change the invocation
setup to use clang::createInvocation or
clang::CompilerInvocation::CreateFromArgs or clang::BuildCompilation? Or
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/101929
>From 424d331c65b35992475e4b5fda6b72e12a2e2bbd Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 7 Aug 2024 11:11:27 -0700
Subject: [PATCH] [lldb/API] Fix SBStructuredData support any JSON type
Jlalond wrote:
@labath Implemented almost all of your feedback, once again I appreciate the in
depth review. The only functional thing I did not change was the assertion in
the iterator constructor that the first element is readable.
https://github.com/llvm/llvm-project/pull/101272
___
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -336,3 +336,89 @@ TEST(MinidumpYAML, ExceptionStream_ExtraParameter) {
0xab, 0xad, 0xca, 0xfe}),
*ExpectedContext);
}
+
+TEST(MinidumpYAML, MemoryRegion_64bit) {
+ SmallString<0> Storage;
+ auto ExpectedFile = toBinary(Storage, R"
@@ -132,6 +140,95 @@ class MinidumpFile : public Binary {
size_t Stride;
};
+ /// Class the provides an iterator over the memory64 memory ranges. Only the
+ /// the first descriptor is validated as readable beforehand.
+ class Memory64Iterator {
+ public:
+static
@@ -132,6 +140,95 @@ class MinidumpFile : public Binary {
size_t Stride;
};
+ /// Class the provides an iterator over the memory64 memory ranges. Only the
+ /// the first descriptor is validated as readable beforehand.
+ class Memory64Iterator {
+ public:
+static
@@ -788,7 +808,13 @@ Type::GetTypeScopeAndBasename(llvm::StringRef name) {
switch (pos.value()) {
case ':':
if (prev_is_colon && template_depth == 0) {
-result.scope.push_back(name.slice(name_begin, pos.index() - 1));
+llvm::StringRef scope_name =
@@ -440,12 +440,6 @@ static void GetTypeLookupContextImpl(DWARFDIE die,
continue;
}
-// If there is no name, then there is no need to look anything up for this
-// DIE.
-const char *name = die.GetName();
-if (!name || !name[0])
- return;
-
--
https://github.com/clayborg commented:
This patch relies on "(anonymous namespace)" being removed from the compiler
contexts to work. What is the user types any of:
```
(lldb) type lookup "(anonymous namespace)::A"
(lldb) script lldb.target.FindFirstType("(anonymous namespace)::A");
(lldb) scrip
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/102111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,6 +134,20 @@ bool TypeQuery::ContextMatches(
if (ctx == ctx_end)
return false; // Pattern too long.
+if (ctx->kind == CompilerContextKind::Namespace && ctx->name.IsEmpty()) {
clayborg wrote:
Do we need to check for `"(anonymous namespace
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101283
>From 6b2a41ba3d71270e81e24a42d3b4f5dc2f96b939 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 05:41:21 +0400
Subject: [PATCH 1/3] [lldb] Updated lldb-server to spawn the child process and
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/102309
>From 3dfbfc759f61827f010f4a65241c8464c5815484 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 7 Aug 2024 12:46:24 +0100
Subject: [PATCH 1/3] [lldb][ClangExpressionParser] Set
BuiltinHeadersInSystemMo
slydiman wrote:
@labath I have added the class SharedSocket. I have implemented all the
recommendations.
Note we have the buildbot for cross tests (Windows x64/Linux x64 host and Linux
Aarch64 target).
So everything is tested. Hope 1191 API tests run with this lldb-server are
enough.
https://
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101283
>From 6b2a41ba3d71270e81e24a42d3b4f5dc2f96b939 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 05:41:21 +0400
Subject: [PATCH 1/3] [lldb] Updated lldb-server to spawn the child process and
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/102309
>From 3dfbfc759f61827f010f4a65241c8464c5815484 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 7 Aug 2024 12:46:24 +0100
Subject: [PATCH 1/2] [lldb][ClangExpressionParser] Set
BuiltinHeadersInSystemMo
https://github.com/adrian-prantl approved this pull request.
Thanks, this LGTM, next step should be to replace the use of
`include_directories` with `DW_AT_APPLE_sdk`.
https://github.com/llvm/llvm-project/pull/102309
___
lldb-commits mailing list
lldb
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi closed
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: royitaqi
Date: 2024-08-07T07:58:34-07:00
New Revision: 12fa4b17dcededbd14abfc3ae72f1b798349e847
URL:
https://github.com/llvm/llvm-project/commit/12fa4b17dcededbd14abfc3ae72f1b798349e847
DIFF:
https://github.com/llvm/llvm-project/commit/12fa4b17dcededbd14abfc3ae72f1b798349e847.diff
LOG:
oontvoo wrote:
> I've made one pass over the PR. I think this would be easier to review if it
> was split into multiple patches:
>
> * core llvm infrastructure
> * core lldb infrastructure
> * ~one patch per event type
>
> I think the biggest hurdle will be finding someone to approve the ad
gribozavr wrote:
## On resugaring bodies of function template instantiations
> I just don't think that can be something we can always enable, as that would
> make some examples of source code take exponentially more time and memory to
> compile.
We keep track of propagated and inferred nullab
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
labath wrote:
Also, if any of this code is not tested (outside of running the entire test
suite in the remote mode) we should add a dedicated test for it. A quick search
found at least one (test/API/tools/lldb-server/TestGdbRemoteCompletion.py) test
which would appear to exercise this, but may
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/102309
>From 3dfbfc759f61827f010f4a65241c8464c5815484 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 7 Aug 2024 12:46:24 +0100
Subject: [PATCH] [lldb][ClangExpressionParser] Set
BuiltinHeadersInSystemModule
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch changes the way we initialize `BuiltinHeadersInSystemModules` which
is one of the flags controlling Clang's behaviour when the Darwin module is
split into more fine-grained modules. The ClangExp
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/102309
This patch changes the way we initialize `BuiltinHeadersInSystemModules` which
is one of the flags controlling Clang's behaviour when the Darwin module is
split into more fine-grained modules. The ClangExpre
@@ -114,6 +126,175 @@ static Status save_socket_id_to_file(const std::string
&socket_id,
return status;
}
+static void client_handle(GDBRemoteCommunicationServerPlatform &platform,
+ const lldb_private::Args &args) {
+ if (!platform.IsConnected())
https://github.com/labath commented:
I actually quite like this. I think we should further merge the platform
specific code into one place (which, among other things, will reduce the total
number of ifdefs to ~one, and put all of the socket handling code next to each
other), but apart from tha
@@ -60,6 +71,7 @@ static struct option g_long_options[] = {
{"max-gdbserver-port", required_argument, nullptr, 'M'},
{"socket-file", required_argument, nullptr, 'f'},
{"server", no_argument, &g_server, 1},
+{"fd", required_argument, nullptr, 'd'},
--
@@ -114,6 +126,175 @@ static Status save_socket_id_to_file(const std::string
&socket_id,
return status;
}
+static void client_handle(GDBRemoteCommunicationServerPlatform &platform,
+ const lldb_private::Args &args) {
+ if (!platform.IsConnected())
@@ -114,6 +126,175 @@ static Status save_socket_id_to_file(const std::string
&socket_id,
return status;
}
+static void client_handle(GDBRemoteCommunicationServerPlatform &platform,
+ const lldb_private::Args &args) {
+ if (!platform.IsConnected())
@@ -254,6 +445,65 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ if (fd != kInvalidFD) {
+// Child process will handle the connection and exit.
+Log *log = GetLog(LLD
@@ -114,6 +126,175 @@ static Status save_socket_id_to_file(const std::string
&socket_id,
return status;
}
+static void client_handle(GDBRemoteCommunicationServerPlatform &platform,
+ const lldb_private::Args &args) {
+ if (!platform.IsConnected())
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,6 +47,14 @@ using namespace llvm;
// option descriptors for getopt_long_only()
+#ifdef _WIN32
+typedef pipe_t fd_t;
+#define kInvalidFD (LLDB_INVALID_PIPE)
labath wrote:
Lets make this a real constant (not a macro).
https://github.com/llvm/llvm-proje
Author: Michael Buch
Date: 2024-08-07T13:39:52+01:00
New Revision: f05efd034c0993c7aa606bfbaaf575d94d75b43f
URL:
https://github.com/llvm/llvm-project/commit/f05efd034c0993c7aa606bfbaaf575d94d75b43f
DIFF:
https://github.com/llvm/llvm-project/commit/f05efd034c0993c7aa606bfbaaf575d94d75b43f.diff
https://github.com/Michael137 approved this pull request.
Latest test additions LGTM, thanks!
https://github.com/llvm/llvm-project/pull/102111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/102296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-08-07T13:05:45+01:00
New Revision: 3ac5f5e1fc189d0cca169a409199fdaec13112d1
URL:
https://github.com/llvm/llvm-project/commit/3ac5f5e1fc189d0cca169a409199fdaec13112d1
DIFF:
https://github.com/llvm/llvm-project/commit/3ac5f5e1fc189d0cca169a409199fdaec13112d1.diff
labath wrote:
You're right -- I misremembered. I thought the DefinitionData is set when
completing the definition, but happens when the definition is started. In that
case, yes, the crash happened because the ast importer didn't copy over the
definition data, but then tried to access it when a
Michael137 wrote:
> > LGTM, thanks!
> > So the actual problem is that the ASTImporter will only copy over the
> > definition to the destination decl if the source decl
> > `isCompleteDefinition`. So then when we tried to add the typedef decl to
> > the `CXXRecordDecl` that the ASTImporter crea
@@ -111,4 +115,22 @@ TEST(Type, CompilerContextPattern) {
Matches(std::vector{make_class("C")}));
EXPECT_THAT((std::vector{make_namespace("NS"), make_class("C")}),
Not(Matches(std::vector{make_any_type("C")})));
+
+ EXPECT_THAT((std::vector{make_n
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/102111
>From c6936f3d5d0592babe9082e867b179af594c447b Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 6 Aug 2024 09:51:20 +0200
Subject: [PATCH 1/3] [lldb] Better matching of types in anonymous namespaces
This p
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/102296
>From 45c8f9534ec0ddc50c825fa7a3d048746b74360c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 7 Aug 2024 11:03:25 +0100
Subject: [PATCH 1/2] [lldb][TypeSystem] Pass ClangASTMetadata by-value when
cre
labath wrote:
> LGTM, thanks!
>
> So the actual problem is that the ASTImporter will only copy over the
> definition to the destination decl if the source decl `isCompleteDefinition`.
> So then when we tried to add the typedef decl to the `CXXRecordDecl` that the
> ASTImporter created for `A`
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/102296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -266,6 +269,11 @@ class TypeQuery {
bool GetIgnoreModules() const { return (m_options & e_ignore_modules) != 0; }
void SetIgnoreModules() { m_options &= ~e_ignore_modules; }
+ bool GetStrictNamespaces() const {
+return (m_options & e_strict_namespaces) != 0;
+ }
+
@@ -145,10 +159,16 @@ bool TypeQuery::ContextMatches(
++pat;
}
- // Skip over any remaining module entries if we were asked to do that.
- while (GetIgnoreModules() && ctx != ctx_end &&
- ctx->kind == CompilerContextKind::Module)
-++ctx;
+ // Skip over any
@@ -788,7 +808,10 @@ Type::GetTypeScopeAndBasename(llvm::StringRef name) {
switch (pos.value()) {
case ':':
if (prev_is_colon && template_depth == 0) {
-result.scope.push_back(name.slice(name_begin, pos.index() - 1));
+llvm::StringRef scope_name =
1 - 100 of 139 matches
Mail list logo
