oontvoo wrote:
> I've made one pass over the PR. I think this would be easier to review if it > was split into multiple patches: > > * core llvm infrastructure > * core lldb infrastructure > * ~one patch per event type > > I think the biggest hurdle will be finding someone to approve the addition of > the new llvm library (I doubt it's going to be someone from the current > reviewer set). I wouldn't be surprised if this ends up needing its own RFC. Good point - so here's the plane: - I'll create a separate PR for the first bullet point (llvm core infra). - keep this PR as is - since branching is such a pain (and controversial) in llvm, you can "pretend" to not see the llvm/lib/ changes in this PR . hopefully the diff will disappear once the first PR goes in. https://github.com/llvm/llvm-project/pull/98528 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
