https://github.com/clayborg commented:
LGTM. Jim? You ok with this?
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,44 @@
+//===-- SBWatchpointOptions.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,67 @@
+//===-- SBWatchpointOptions.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/clayborg commented:
Overall looks pretty solid. Just need to nail down the headerdoc for the
"modify" accesors and clarify that it only works in combination with "write"
and probably change the old API from "bool read, bool write" to be "bool read,
bool modify" to clearly in
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/MaskRay approved this pull request.
LGTM, but @jh7370 usually wants to have an eye on such changes.
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -390,6 +390,21 @@ StringRef stem(StringRef path, Style style =
Style::native);
/// @result The extension of \a path.
StringRef extension(StringRef path, Style style = Style::native);
+/// Get the program's name
+///
+/// If the path ends with the string .exe, returns the s
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,7 +46,9 @@ def test_unaligned_watchpoint(self):
a_bytebuf_6 = frame.GetValueForVariablePath("a.bytebuf[6]")
a_bytebuf_6_addr = a_bytebuf_6.GetAddress().GetLoadAddress(target)
err = lldb.SBError()
-wp = target.WatchAddress(a_bytebuf_6_addr,
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,67 @@
+//===-- SBWatchpointOptions.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1326,23 +1326,35 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t
addr, size_t size,
SBError &error) {
LLDB_INSTRUMENT_VA(this, addr, size, read, write, error);
+ SBWatchpointOptions options;
+ options.SetWatchpointTy
@@ -0,0 +1,44 @@
+//===-- SBWatchpointOptions.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
walter-erquinigo wrote:
I've updated the PR following Greg's suggestions.
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/66548
>From 3bddb5d5f813d5eac165be1a73b9058f5ee0510d Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 15 Sep 2023 16:41:23 -0400
Subject: [PATCH] [LLDB] Add a setting for print hex variable values wi
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/66551
>From 31236a70c8d1736563a253dc3a2582366220cb8f Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 15 Sep 2023 16:50:35 -0400
Subject: [PATCH] [lldb-vscode] Show addresses next to dereferenced sum
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/66551
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,44 @@
+//===-- SBWatchpointOptions.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,67 @@
+//===-- SBWatchpointOptions.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,44 @@
+//===-- SBWatchpointOptions.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -53,7 +53,10 @@ def fuzz_obj(obj):
obj.GetByteOrder()
obj.GetTriple()
error = lldb.SBError()
-obj.WatchAddress(123, 8, True, True, error)
+wp_opts = lldb.SBWatchpointOptions()
+wp_opts.SetWatchpointTypeRead(True)
+wp_opts.SetWatchpointTypeModify(T
@@ -46,7 +46,9 @@ def test_unaligned_watchpoint(self):
a_bytebuf_6 = frame.GetValueForVariablePath("a.bytebuf[6]")
a_bytebuf_6_addr = a_bytebuf_6.GetAddress().GetLoadAddress(target)
err = lldb.SBError()
-wp = target.WatchAddress(a_bytebuf_6_addr,
@@ -1326,23 +1326,35 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t
addr, size_t size,
SBError &error) {
LLDB_INSTRUMENT_VA(this, addr, size, read, write, error);
+ SBWatchpointOptions options;
+ options.SetWatchpointTy
@@ -0,0 +1,44 @@
+//===-- SBWatchpointOptions.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
enableAutoVariableSummaries is a setting that enhances the summaries of
variables in the IDE. A shortcoming of this feature is that it wasn't showing
the addresses of pointers, which is valuable information. This fixes it by
adding it when
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/66551
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/66551
enableAutoVariableSummaries is a setting that enhances the summaries of
variables in the IDE. A shortcoming of this feature is that it wasn't showing
the addresses of pointers, which is valuable informa
walter-erquinigo wrote:
I like Greg's proposal of naming it
`show-hex-variable-values-with-leading-zeroes`. Seems very clear. I also like
the idea of making it a global target config, which would simplify the code.
https://github.com/llvm/llvm-project/pull/66548
___
clayborg wrote:
> @jimingham , that's a good catch. Probably I should rename this because I
> want this setting to affect only SBValueObject::GetValue(), which is want
> ends up being sent to IDEs as a common interface. Trying to control all
> places that print as hex value is a bit too much a
jimingham wrote:
That really should be
`show-leading-zeros-in-valueobject-variables-using-hex-format`, shouldn't it?
I think you can actually just document what it actually does in the help string
and then you shouldn't have to make the name overly pedantic. The one you
have already is pro
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/66308
>From 1efbce9f3b754f45372f0098163e70c2118b57d9 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 13 Sep 2023 17:38:31 -0700
Subject: [PATCH 1/2] [lldb] Add 'modify' type watchpoints, make it default
W
walter-erquinigo wrote:
@jimingham , that's a good catch. Probably I should rename this because I want
this setting to affect only SBValueObject::GetValue(), which is want ends up
being sent to IDEs as a common interface. Trying to control all places that
print as hex value is a bit too much a
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
There are other places we print hex numbers that don't go through the
DataExtractor. For instance, the "location" for a ValueObject is printed
directly, so this change wouldn't catch it. It's a little off-putting if you
set a global setting to "not print leading zeros" and t
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/66548
>From 99b2a5e3663263fd1a92e350a3254fafbe9724c5 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 15 Sep 2023 16:41:23 -0400
Subject: [PATCH] [LLDB] Add a setting for print hex values without lea
@@ -620,10 +620,17 @@ lldb::offset_t lldb_private::DumpDataExtractor(
case 2:
case 4:
case 8:
-s->Printf(wantsuppercase ? "0x%*.*" PRIX64 : "0x%*.*" PRIx64,
- (int)(2 * item_byte_size), (int)(2 * item_byte_size),
- DE.
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Nice! LGTM
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
As suggested by Greg in https://github.com/llvm/llvm-project/pull/66534, I'm
adding a setting at the Target level that controls whether to show leading
zeroes in hex ValueObject values.
This has the benefit of reducing the amount of charac
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/66548
As suggested by Greg in https://github.com/llvm/llvm-project/pull/66534, I'm
adding a setting at the Target level that controls whether to show leading
zeroes in hex ValueObject values.
This has the be
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/66534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I initially didn't want to mess with global configurations, but after a second
thought, I think your solution is better. I'll try that out
https://github.com/llvm/llvm-project/pull/66534
___
lldb-commits mailing list
lldb-commi
clayborg wrote:
Then no changes are needed for vs code files at all and we can test this with a
normal LLDB variable tests.
https://github.com/llvm/llvm-project/pull/66534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
clayborg wrote:
If you create a setting, be sure to make it a global setting (a bool in the
setting definition) so it can always be accessed via:
```
static TargetProperties &Target::GetGlobalProperties();
```
https://github.com/llvm/llvm-project/pull/66534
__
clayborg wrote:
I have verified that if I change DumpDataExtractor() you can easily do this:
```
case eFormatHex:
case eFormatHexUppercase: {
bool wantsuppercase = (item_format == eFormatHexUppercase);
switch (item_byte_size) {
case 1:
case 2:
case 4:
c
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -228,7 +228,24 @@ void SetValueForKey(lldb::SBValue &v, llvm::json::Object
&object,
strm << "";
} else {
auto tryDumpSummaryAndValue = [&strm](lldb::SBValue value) {
- llvm::StringRef val = value.GetValue();
+ std::string val;
+ // Whenever the valu
https://github.com/clayborg requested changes to this pull request.
I would rather we add a new setting in lldb that controls if we see hex values
with leading zeroes and allow users to set this. It will be _very_ easy to fix
this as all you need to do is fix lldb_private::DumpDataExtractor() a
jimingham wrote:
People can either look at the detailed JSON output or just go look at that path
to figure out what went wrong, so just S & E would be fine for now.
Jim
> On Sep 15, 2023, at 11:18 AM, Tom Yang ***@***.***> wrote:
>
>
> I think it would be easier to read the output if you ma
zhyty wrote:
> > > I think it would be easier to read the output if you made a separate
> > > column for "error". If you imagine a listing where there are 100 OSO's of
> > > which 10 are missing, the paths are going to jump over because of the
> > > "error: ..." at the beginning of those lines
Author: Jonas Devlieghere
Date: 2023-09-15T11:15:13-07:00
New Revision: c60ccfbb898148449946f82cbac6140f1e01cb12
URL:
https://github.com/llvm/llvm-project/commit/c60ccfbb898148449946f82cbac6140f1e01cb12
DIFF:
https://github.com/llvm/llvm-project/commit/c60ccfbb898148449946f82cbac6140f1e01cb12.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/66527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/66527
>From d67ae6c562f0367df98ce72f866c088cf433b62d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Sep 2023 09:31:22 -0700
Subject: [PATCH] [lldb] Revive internal data formatter documentation
Thi
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/66534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/66534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/66534
>From d8060f818b18b3fe64641d9683fa49ffca0b3736 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 15 Sep 2023 12:40:33 -0400
Subject: [PATCH] [lldb-vscode] Show value addresses in a short format
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
The variables pane on VSCode is very narrow by default, and lldb-vscode has
been using the default formatter for addresses, which uses 18 characters for
each address. That's a bit too much because it prints too many leading zeroes.
As a way
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/66534
The variables pane on VSCode is very narrow by default, and lldb-vscode has
been using the default formatter for addresses, which uses 18 characters for
each address. That's a bit too much because it pr
@@ -0,0 +1,436 @@
+Data Formatters
+===
+
+This page is an introduction to the design of the LLDB data formatters
+subsystem. The intended target audience are people interested in understanding
+or modifying the formatters themselves rather than writing a specific data
@@ -0,0 +1,436 @@
+Data Formatters
+===
+
+This page is an introduction to the design of the LLDB data formatters
+subsystem. The intended target audience are people interested in understanding
+or modifying the formatters themselves rather than writing a specific data
https://github.com/walter-erquinigo commented:
Awesome doc!
https://github.com/llvm/llvm-project/pull/66527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,436 @@
+Data Formatters
+===
+
+This page is an introduction to the design of the LLDB data formatters
+subsystem. The intended target audience are people interested in understanding
+or modifying the formatters themselves rather than writing a specific data
@@ -0,0 +1,436 @@
+Data Formatters
+===
+
+This page is an introduction to the design of the LLDB data formatters
+subsystem. The intended target audience are people interested in understanding
+or modifying the formatters themselves rather than writing a specific data
@@ -0,0 +1,436 @@
+Data Formatters
+===
+
+This page is an introduction to the design of the LLDB data formatters
+subsystem. The intended target audience are people interested in understanding
+or modifying the formatters themselves rather than writing a specific data
@@ -0,0 +1,436 @@
+Data Formatters
+===
+
+This page is an introduction to the design of the LLDB data formatters
+subsystem. The intended target audience are people interested in understanding
+or modifying the formatters themselves rather than writing a specific data
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/66527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
I just did a quick scan but this all seems still pretty accurate, and useful as
a middle-level description for people who need to work on the data formatter
system in lldb.
https://github.com/llvm/llvm-project/pull/66527
jimingham wrote:
> > I think it would be easier to read the output if you made a separate column
> > for "error". If you imagine a listing where there are 100 OSO's of which 10
> > are missing, the paths are going to jump over because of the "error: ..."
> > at the beginning of those lines mak
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
This is a (rough) port of architecture/varformats.html page that got lost
during the migration to RST in edb874b. I'm not sure how much of its content is
still relevant today. However, the page is pretty extensive and seems like it's
worth
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/66527
This is a (rough) port of architecture/varformats.html page that got lost
during the migration to RST in edb874b. I'm not sure how much of its content is
still relevant today. However, the page is pretty ex
clayborg wrote:
> I think it would be easier to read the output if you made a separate column
> for "error". If you imagine a listing where there are 100 OSO's of which 10
> are missing, the paths are going to jump over because of the "error: ..." at
> the beginning of those lines making it me
Author: walter erquinigo
Date: 2023-09-15T12:26:04-04:00
New Revision: 4a030f5b245b63fe09c29686c50d40796c987d96
URL:
https://github.com/llvm/llvm-project/commit/4a030f5b245b63fe09c29686c50d40796c987d96
DIFF:
https://github.com/llvm/llvm-project/commit/4a030f5b245b63fe09c29686c50d40796c987d96.di
https://github.com/jimingham commented:
I think it would be easier to read the output if you made a separate column for
"error". If you imagine a listing where there are 100 OSO's of which 10 are
missing, the paths are going to jump over because of the "error: ..." at the
beginning of those l
JDevlieghere wrote:
> Would skip review, but it's here on the off chance @JDevlieghere knows where
> the second link was supposed to go to.
The original HTML had the following links:
```
For a general user-level introduction to data formatters, you can look here.
More details on the architectu
Author: David Spickett
Date: 2023-09-15T16:39:49+01:00
New Revision: 1d75d426895b9d54509cfafa53d01bb5bd6266d0
URL:
https://github.com/llvm/llvm-project/commit/1d75d426895b9d54509cfafa53d01bb5bd6266d0
DIFF:
https://github.com/llvm/llvm-project/commit/1d75d426895b9d54509cfafa53d01bb5bd6266d0.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/66474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/66474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This look good
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159504/new/
https://reviews.llvm.org/D159504
_
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This is LGTM as you suggested pending child reviews.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159503/new/
https://reviews.llvm.org/D159
DavidSpickett added a comment.
I'll hold off landing any of the prior patches until this is reviewed, in case
I have to go back and move things.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159505/new/
https://reviews.llvm.org/D159505
__
DavidSpickett updated this revision to Diff 556856.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158506/new/
https://reviews.llvm.org/D158506
Files:
lldb/docs/index.rst
lldb/docs/use/aarch64-linux.rst
l
DavidSpickett updated this revision to Diff 556855.
DavidSpickett added a comment.
sme_regs -> sme_pseudo_regs and rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158500/new/
https://reviews.llvm.org/D158500
Files:
lldb/source/Plugins/Proc
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
DavidSpickett updated this revision to Diff 556854.
DavidSpickett added a comment.
Rebase, use new sme_pseudo_regs naming.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154927/new/
https://reviews.llvm.org/D154927
Files:
lldb/source/Plugins/Proc
DavidSpickett updated this revision to Diff 556853.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159505/new/
https://reviews.llvm.org/D159505
Files:
lldb/test/API/commands/register/register/aarch64_dynamic
DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:839
+
+void GDBRemoteDynamicRegisterInfo::UpdateARM64SMERegistersInfos(uint64_t svg) {
+ for (auto ® : m_regs) {
DavidSpickett updated this revision to Diff 556852.
DavidSpickett added a comment.
Combine reconfigure into one function. The tricky thing is we have to read
svg and vg up front because we can't read registers while we're messing
with register offsets.
Otherwise, the result is a bit clearer and i
DavidSpickett updated this revision to Diff 556851.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159503/new/
https://reviews.llvm.org/D159503
Files:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLi
DavidSpickett added a comment.
Note that GetSMEOffset refers to the whole register set which does include ZA,
so no change of name there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159503/new/
https://reviews.llvm.org/D159503
_
DavidSpickett marked 2 inline comments as done.
DavidSpickett added a comment.
Will apply the rename in core files as well later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159503/new/
https://reviews.llvm.org/D159503
__
DavidSpickett updated this revision to Diff 556844.
DavidSpickett added a comment.
- sme_regs -> sme_pseudo_regs, also changed the accesor method names.
- clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159503/new/
https://reviews.llvm.o
omjavaid added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:839
+
+void GDBRemoteDynamicRegisterInfo::UpdateARM64SMERegistersInfos(uint64_t svg) {
+ for (auto ® : m_regs) {
can we combine UpdateARM64SVERegiste
omjavaid added a comment.
This looks find just couple of nits inline.
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:354
+
+ // ZA is part of the SME set but uses a seperate member buffer for
storage.
+ // Therefore its effective
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This is LGTM. Thanks for your patience.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159502/new/
https://reviews.llvm.org/D159502
https://github.com/gchatelet closed
https://github.com/llvm/llvm-project/pull/65750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 118 matches
Mail list logo
