clayborg wrote: > @jimingham , that's a good catch. Probably I should rename this because I > want this setting to affect only SBValueObject::GetValue(), which is want > ends up being sent to IDEs as a common interface. Trying to control all > places that print as hex value is a bit too much and it'll be hard to enforce > in the long term. Any particular suggestion? Because I can't really come up > with a good name better than `show-leading-zeroes-in-valueobject-values`.
I think the setting name is ok as is. No one outside of LLDB developers have any idea what "valueobject" means. Also this setting is "show-hex-values-with-leading-zeroes" which does mention "values" so it can be ok for not all hex values emitted that are not values to have leading zeroes. The location is not a "value" technically and we might want some values coming out with leading zeroes like any command that dumps out table style output like "image dymp symtab" and other areas. Maybe we can name this setting: ``` show-hex-variable-values-with-leading-zeroes ``` The confirm this is for variable values only and not a system wide thing? If we switch the setting to be global in the target settings we can get the global target settings without needing to check the exe_scope. Thoughts? https://github.com/llvm/llvm-project/pull/66548 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
