[Lldb-commits] [lldb] 2f9cd63 - [LLDB] Fix IOHandlerEditline::GetCurrentLines()

Author: walter erquinigo Date: 2023-09-01T20:52:00-04:00 New Revision: 2f9cd6377f3d972ed8cf814225a02a353d6cc545 URL: https://github.com/llvm/llvm-project/commit/2f9cd6377f3d972ed8cf814225a02a353d6cc545 DIFF: https://github.com/llvm/llvm-project/commit/2f9cd6377f3d972ed8cf814225a02a353d6cc545.di

lldb-commits@lists.llvm.org

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM 🚀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159387/new/ https://reviews.llvm.org/D159387 _

lldb-commits@lists.llvm.org

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGa69f78b080ef: [lldb] Add syntax color highlighting for disassembly (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D159164?vs=555489&id=13

[Lldb-commits] [lldb] a69f78b - [lldb] Add syntax color highlighting for disassembly

Author: Jonas Devlieghere Date: 2023-09-01T14:47:45-07:00 New Revision: a69f78b080ef7efd2854ba199248713d956ea40c URL: https://github.com/llvm/llvm-project/commit/a69f78b080ef7efd2854ba199248713d956ea40c DIFF: https://github.com/llvm/llvm-project/commit/a69f78b080ef7efd2854ba199248713d956ea40c.d

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

clayborg added inline comments. Comment at: lldb/source/Core/Disassembler.cpp:662-663 // consistent column spacing in these cases, unfortunately. - if (m_opcode_name.length() >= opcode_column_width) { -opcode_column_width = m_opcode_name.length() + 1; + if (opcode_name.l

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Thanks Greg! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

clayborg added a comment. Just one last inline comment where we can't use the colorized string to calculate the column width and this is good to go. Comment at: lldb/source/Core/Disassembler.cpp:662-663 // consistent column spacing in these cases, unfortunately. - if (m_op

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555489. JDevlieghere marked 9 inline comments as done. JDevlieghere added a comment. Use the execution context to enable colors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/l

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Disassembler.h:158 bool show_bytes, bool show_control_flow_kind, -const ExecutionContext *exe_ctx, +bool show_color, const ExecutionContext *exe_ctx,

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere added a comment. @clayborg let me know if you're happy with this. To answer your previous question, I'm not planning anymore changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 ___

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555442. JDevlieghere added a comment. As I was adding another test I realized an issue with the previous approach due to the fact that we cache the result. The solution is to cache both the plain and the marked up result, and have the different accessor

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

clayborg added a comment. lgtm. Is there any more things you want to add to this patch test wise, or is this complete? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1801 +FileSpecList dwo_paths; +FileSpec spec_to_get_name(dwo_name); +llvm::StringRef filename_only = spec_to_get_name.GetFilename(); Rename to "dwo_na

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

bulbazord accepted this revision. bulbazord added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ https://reviews.llvm.org/D159315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555417. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Test `GetMnemonic` and `GetComment`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/lldb/Cor

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

clayborg added a comment. Yes, this simplifies the patch a lot. Looks good after we check the mnemonic and comment for no color when used through the SBInstruction APIs. Comment at: lldb/test/API/python_api/disassemble-raw-data/TestDisassembleRawData.py:69 +ci.Han

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks great. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ https://reviews.llvm.org/D159315 ___ lldb-commits

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

mib updated this revision to Diff 555397. mib added a reviewer: hawkinsw. mib added a comment. Address @hawkinsw feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ https://reviews.llvm.org/D159315 Files: lldb/bindings/python/CMakeLists.txt lldb/examples/python/tem

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

mib added a comment. In D159315#4633227 , @hawkinsw wrote: > I hope that some comments are helpful! The documentation that you added is > tremendously helpful -- I know how documentation is sometimes a thankless > task, so I will say what everyone is th

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:503 +enum SavedRegistersKind : uint32_t { + GPR, + SVE, // Used for SVE and SSVE. Consider renaming this to RegisterSetName or RegisterSetType

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:539 Status error; - uint32_t reg_data_byte_size = GetGPRBufferSize(); + uint32_t reg_data_byte_size = sizeof(SavedRegistersKind) + GetGPRBufferSize(); erro

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 555353. DavidSpickett added a comment. Rebase after changes to WriteAllRegisterValues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157883/new/ https://reviews.llvm.org/D157883 Files: lldb/include/lld

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. So hopefully it is more readable in both in the sense that Readall/writeall is almost declarative. The details are all in the helpers so you can't forget one of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 555347. DavidSpickett added a comment. So this is almost the opposite of what you asked for, but I made WriteAllRegisterValues similar to ReadAll by giving it it's own convenient wrapper function. Which ensures you don't forget to set a valid bool, or

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 555343. DavidSpickett added a comment. Correct SVE reconfigure on non-SVE machines. It used to return if there was no vg, which is correct, not sure why I changed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:573 - ::memcpy(dst, GetGPRBuffer(), GetGPRBufferSize()); - dst += GetGPRBufferSize(); + dst = AddSavedRegisters(dst, SavedRegistersKind::GPR, GetGPRBuffer

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett updated this revision to Diff 555333. DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Use *.dwo in commands since I'm not sure the DWO name will be the same everywhere. The specific name isn't important, we know there's only going to be one. Repositor

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755 + dwo_file.AppendPathComponent(dwo_name); + found = FileSystem::Instance().Exists(dwo_file); +} else {

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

DavidSpickett abandoned this revision. DavidSpickett added a comment. Squashed into previous review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158182/new/ https://reviews.llvm.org/D158182 ___ lldb-co

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett updated this revision to Diff 555330. DavidSpickett added a comment. In the interests of my own sanity I've squashed the subsequent review into this one and applied the suggestions from both. Also I changed the tests to look for a global so we don't have to update the line number a

[Lldb-commits] [PATCH] D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157845/new/ https://reviews.llvm.org/D157845

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:573 - ::memcpy(dst, GetGPRBuffer(), GetGPRBufferSize()); - dst += GetGPRBufferSize(); + dst = AddSavedRegisters(dst, SavedRegistersKind::GPR, GetGPRBuffer(), +

[Lldb-commits] [lldb] 4d1cf54 - [lldb] Fix build with MSVC by using LLVM_PRETTY_FUNCTION

Author: David Spickett Date: 2023-09-01T07:40:35Z New Revision: 4d1cf5403fc05a738f2d548429dbd51cb2300765 URL: https://github.com/llvm/llvm-project/commit/4d1cf5403fc05a738f2d548429dbd51cb2300765 DIFF: https://github.com/llvm/llvm-project/commit/4d1cf5403fc05a738f2d548429dbd51cb2300765.diff LOG