clayborg added a comment.
Yes, this simplifies the patch a lot. Looks good after we check the mnemonic
and comment for no color when used through the SBInstruction APIs.
================
Comment at:
lldb/test/API/python_api/disassemble-raw-data/TestDisassembleRawData.py:69
+ ci.HandleCommand("settings set use-color true", res)
+ self.assertEqual(inst.GetOperands(target), "w0, #0x63")
+ ci.HandleCommand("settings set use-color false", res)
----------------
Can we check both:
```
inst.GetMnemonic(target)
inst.GetComment(target)
```
here too to make sure no colorization gets added?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159164/new/
https://reviews.llvm.org/D159164
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
