[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. Given the AddressMaskType enum, I wonder if instead of `FixCodeAddress`, `FixDataAddress`, and `FixAddress`, there should be one `SBProcess::FixAddress(lldb::AddressMaskType type, lldb::addr_t address)` and it would be used with `eMaskTypeCode`, `eMaskTypeData`, or

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Support recursive record types in CTF. We are now more lazy when creating LLDB types. When encountering a record type

[Lldb-commits] [PATCH] D156367: [BSDArchive] NULL check the child object file ptr before accessing its member

kusmour added a comment. In D156367#4539916 , @bulbazord wrote: > Hey, I think this may have broken the green dragon bots. Could you take a > look and fix forward or revert? Thanks > > https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/3262/ (Y

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 544982. ashgti added a comment. Adding new tests to cover the behavior of the disassemble request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 Files: lldb/packag

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 544977. ashgti added a comment. Fixing a test and removing dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 Files: lldb/test/API/tools/lldb-vscode/coreFile

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added inline comments. Comment at: lldb/source/API/SBProcess.cpp:1260-1261 + return process_sp->GetHighmemDataAddressMask(); +case eMaskTypeAny: + return process_sp->GetDataAddressMask(); +} jasonmolenda wrote: > clayborg wrote: > >

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 544957. ashgti added a comment. Herald added a subscriber: JDevlieghere. Minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 Files: lldb/tools/lldb-vscode/JSO

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of creating psuedo source files for each stack frame this change adopts the new DAP “disassemble” request, allowing c

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

ashgti updated this revision to Diff 544946. ashgti edited the summary of this revision. ashgti added a comment. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156465/new/ https://reviews.llvm.org/D156465 Files: lldb/tools/

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:445 + lldb::addr_t FixDataAddress(lldb::addr_t addr); + lldb::addr_t FixAnyAddress(lldb::addr_t addr); + clayborg wrote: > What does this function do? Does it try to auto detect c

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

clayborg added a comment. Looks much better, just a few questions in comments. Comment at: lldb/include/lldb/API/SBProcess.h:425 + /// code/data masks. Each of these can be set, or + /// most commonly, eMaskTypeall can be set, when all masks are + /// identical.

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda updated this revision to Diff 544936. jasonmolenda added a comment. Update the patch to express the mask getter/setters in terms of a type enum, after discussions with Greg and David. I still need to write a test for this API but I'm liking where this is now. Repository: rG LLV

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size() == nelems); JDevlieghere wrote

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size(

[Lldb-commits] [lldb] 4520cc0 - [lldb] Fix TestBSDArchives failure

Author: Wanyi Ye Date: 2023-07-27T17:30:16-04:00 New Revision: 4520cc066b2ffe5ac261e3aca887cba3f113b1ff URL: https://github.com/llvm/llvm-project/commit/4520cc066b2ffe5ac261e3aca887cba3f113b1ff DIFF: https://github.com/llvm/llvm-project/commit/4520cc066b2ffe5ac261e3aca887cba3f113b1ff.diff LOG:

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size() == nelems); did you omit this

[Lldb-commits] [PATCH] D156490: [lldb] Fix CTF parsing of large structs

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM modulo spelling nit Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.h:257 static constexpr uint8_t g_ctf_version = 4; + static constexpr uint32_t

[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

JDevlieghere updated this revision to Diff 544925. JDevlieghere added a comment. Address @bulbazord's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156483/new/ https://reviews.llvm.org/D156483 Files: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h lldb/source/Plugins/Symbol

[Lldb-commits] [PATCH] D156490: [lldb] Fix CTF parsing of large structs

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Fix CTF parsing of large structs. If the size of a struct exceeds a certain threshold, the offset is encoded using tw

[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

bulbazord added a comment. Looks like a straightforward follow-up to D156447 . One small nit but otherwise looks good. Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:530 + CompilerType forward_compiler_type = m_ast->CreateRe

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Although I'm not super knowledgable about CTF, this kind of refactor makes sense. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156447/new/ https://reviews.llvm.org/D1564

[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Add support for CTF forward declarations. https://reviews.llvm.org/D156483 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere updated this revision to Diff 544880. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156447/new/ https://reviews.llvm.org/D156447 Files: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h lldb/source/Plugins/SymbolFile/CTF/SymbolF

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:101 + struct Value { +Value(llvm::StringRef name, uint32_t value) : name(name), value(value){}; +llvm::StringRef name; ---

[Lldb-commits] [PATCH] D156367: [BSDArchive] NULL check the child object file ptr before accessing its member

bulbazord added a comment. Herald added a subscriber: JDevlieghere. Hey, I think this may have broken the green dragon bots. Could you take a look and fix forward or revert? Thanks https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/3262/ (You can ignore the `import-std-module` tests,

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Apple platforms when debugging with libBacktraceRecording.dylib backtraces are stored as part of the thread stack. This ch

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:1 +//===-- CTFType.h ---*- C++ -*-===// +// Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:9-10

[Lldb-commits] [PATCH] D156367: [BSDArchive] NULL check the child object file ptr before accessing its member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b9eed9c64f3: [BSDArchive] NULL check the child object file ptr before accessing its member (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG L

[Lldb-commits] [lldb] 4b9eed9 - [BSDArchive] NULL check the child object file ptr before accessing its member

Author: Wanyi Ye Date: 2023-07-27T13:21:31-04:00 New Revision: 4b9eed9c64f3a01bc2d8e444a94101b696a3809c URL: https://github.com/llvm/llvm-project/commit/4b9eed9c64f3a01bc2d8e444a94101b696a3809c DIFF: https://github.com/llvm/llvm-project/commit/4b9eed9c64f3a01bc2d8e444a94101b696a3809c.diff LOG:

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. In D155905#4537892 , @DavidSpickett wrote: >> but I could imagine some harvard architecture target that behaved >> differently (surely this is why Linux has two address masks) > > I'm not privy to the exact reasoning, but a

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 marked an inline comment as done. augusto2112 added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135 + << "note: object description requested, but type doesn't implement " + "a custom object description. Conside

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Separate parsing CTF and creating LLDB types. This is a prerequisite to parsing forward references and recursive type

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

DavidSpickett abandoned this revision. DavidSpickett added a comment. Turns out that for ZA support, we need to know the streaming vector length regardless of current mode. So SVG will be implemented as part of ZA support instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

DavidSpickett added a comment. And +1 to the enum. This mitigates the MacOS specific-ness of the high and low masks at this time, and makes expansion easier if we do manage to generalise them later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

DavidSpickett added a comment. > but I could imagine some harvard architecture target that behaved differently > (surely this is why Linux has two address masks) I'm not privy to the exact reasoning, but at least part of it comes from the architecture itself. You could have a target that enable

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

DavidSpickett added a comment. > I like it the above approach with more enums for the high and low code/data. > Not sure if eTypeAny makes sense in the GetAddressMask(eTypeAny) scenario It could be like the `FixAny` method, a fallback when you don't know either way. `eTypeAny` returns `FixAnyAd

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

DavidSpickett accepted this revision. DavidSpickett added a comment. > Also you can test it as long as you put the right skipif annotations on it as > it'll be architecture specific. Or use a corefile and just check that the > backend for that architecture is enabled. Given that: - We are a th