bulbazord added a comment. Looks like a straightforward follow-up to D156447 <https://reviews.llvm.org/D156447>. One small nit but otherwise looks good.
================ Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:530 + CompilerType forward_compiler_type = m_ast->CreateRecordType( + nullptr, OptionalClangModuleID(), eAccessPublic, ctf_forward.name.data(), + clang::TTK_Struct, eLanguageTypeC); ---------------- It takes a StringRef directly, no need to yoink out the pointer and re-create it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156483/new/ https://reviews.llvm.org/D156483 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
