[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

bulbazord added a comment. Making `m_lock_count`'s type into `std::atomic` makes sense to me, but I'm a little confused about why `Process::LoadOperatingSystemPlugin` is guarded by acquiring `m_thread_mutex`. My (admittedly limited) understanding of that is that it's a mutex that the Process ho

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib updated this revision to Diff 536514. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 Files: lldb/source/Plugins/ScriptInterpreter/Python/Script

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

JDevlieghere added a comment. Does this have to be a recursive mutex? Can we simplify this by using a `std::atomic` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 __

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

This revision was automatically updated to reflect the committed changes. Closed by commit rG624813a4f41c: Change the dyld notification function that lldb puts a breakpoint in (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] 624813a - Change the dyld notification function that lldb puts a breakpoint in

Author: Jason Molenda Date: 2023-06-30T18:29:46-07:00 New Revision: 624813a4f41c5945dc8f8d998173960ad75db731 URL: https://github.com/llvm/llvm-project/commit/624813a4f41c5945dc8f8d998173960ad75db731 DIFF: https://github.com/llvm/llvm-project/commit/624813a4f41c5945dc8f8d998173960ad75db731.diff

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda updated this revision to Diff 536492. jasonmolenda added a comment. Update patch to address Jim and Jonas' feedback, most importantly report a warning if we can't read one of the mach-o binary addresses that dyld is telling us are being added/removed. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

jasonmolenda added a comment. I have to agree with David, I don't see how the old code could overflow if DW_OP_deref_size's maximum size is the pointer size in the target, and we are reading it in to an 8-byte buffer, unless the target had addresses larger than 8 bytes, or the dwarf was malform

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rGb43375bb8195: [lldb] Add log indicating which kind of data formatter (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ ht

[Lldb-commits] [lldb] b43375b - [lldb] Add log indicating which kind of data formatter

Author: Dave Lee Date: 2023-06-30T16:51:14-07:00 New Revision: b43375bb8195bd451850f42b7b99548aa1ba43fd URL: https://github.com/llvm/llvm-project/commit/b43375bb8195bd451850f42b7b99548aa1ba43fd DIFF: https://github.com/llvm/llvm-project/commit/b43375bb8195bd451850f42b7b99548aa1ba43fd.diff LOG:

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix some data races when a python script (i.e. a Scripted Proc

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

jasonmolenda added a comment. Interesting. I remember reading in the recent arm arm docs about how there may be false watchpoint notifications when a processor is in SVE Streaming Mode and a write happens near a watchpoint, but I didn't realize that could happen outside of that context. I'm w

[Lldb-commits] [PATCH] D154204: [lldb][AArch64] Account for extra libc frames in PAC unwind test

jasonmolenda added a comment. Interesting, libc.so must have stripped the names of non-externally-visible functions, and libc_start_main calls one of them which calls main in turn. This change to the test case looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D154265: [lldb][NFC] Simplify GetLocation_DW_OP_addr function

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. this looks good to me. I'm a little overly paranoid about specifying when things are file addresses versus load addresses -- I'm sure that anyone working in this context would kno

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154268/new/ https://reviews.llvm.org/D154268 __

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

jasonmolenda added a comment. This looks like a good change to me. I don't have any comments over Alex's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

fdeazeve updated this revision to Diff 536450. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. fix typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154268/new/ https://reviews.llvm.org/D154268 Files: lldb/t

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D68678 added a test that ensure an Apple accelerator lookup is done efficiently. Since

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D154128 ___

[Lldb-commits] [PATCH] D154265: [lldb][NFC] Simplify GetLocation_DW_OP_addr function

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A very old commit (9422dd64f870dd33) changed the signature of this function in a number of ways. This patch aims to improv

[Lldb-commits] [PATCH] D153802: [lldb] Delete RewriteObjCClassReferences (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c37cbef5821: [lldb] Delete RewriteObjCClassReferences (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D153802?vs=534693&id=536439#toc Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] 2c37cbe - [lldb] Delete RewriteObjCClassReferences (NFC)

Author: Dave Lee Date: 2023-06-30T14:39:20-07:00 New Revision: 2c37cbef5821ae80a62c9eb7ecebd9ec25801c38 URL: https://github.com/llvm/llvm-project/commit/2c37cbef5821ae80a62c9eb7ecebd9ec25801c38 DIFF: https://github.com/llvm/llvm-project/commit/2c37cbef5821ae80a62c9eb7ecebd9ec25801c38.diff LOG:

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione updated this revision to Diff 536348. kastiglione added a comment. Remove __FUNCTION__ from FormatManager logs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D154128 Files: lldb/source/DataFormatte

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

JDevlieghere added a comment. We should still remove the redundant function name from the log messages themselves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D154128

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Our logging infrastructure already supports including the function name in the log message. That has always been the case for `LLDB_LOG` but `LLDB_LOGF` wasn't updated un

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

JDevlieghere added a comment. In D154128#4461033 , @augusto2112 wrote: > I've bumped into this problem before, so really like this change. It's a bit > sad that you'll only print the kind of data formatter once though, so someone > reading the logs mig

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione updated this revision to Diff 536305. kastiglione added a comment. Restore `static_cast()` because of `-Wformat-pedantic` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D154128 Files: lldb/source/D

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione updated this revision to Diff 536300. kastiglione added a comment. Include formatter kind ("format", "summary", "synthetic") to FormatManager logs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D15412

[Lldb-commits] [PATCH] D154208: [lldb][AArch64] Handle different default vector length in SVE testing

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test previously ran on QEMU or A64FX both of which can/d

[Lldb-commits] [PATCH] D154204: [lldb][AArch64] Account for extra libc frames in PAC unwind test

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Running this on Amazon Ubuntu the final backtrace is: (lldb) thread

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. During __do_global_dtors_aux glibc sets a flag that is right next to t

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfbe3a79e20f: [lldb] Check that qLaunchGDBServer packet does not return an error (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] dfbe3a7 - [lldb] Check that qLaunchGDBServer packet does not return an error

Author: David Spickett Date: 2023-06-30T09:12:30Z New Revision: dfbe3a79e20f1bc51a59ee858fabce792d59c9ae URL: https://github.com/llvm/llvm-project/commit/dfbe3a79e20f1bc51a59ee858fabce792d59c9ae DIFF: https://github.com/llvm/llvm-project/commit/dfbe3a79e20f1bc51a59ee858fabce792d59c9ae.diff LOG

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

DavidSpickett added a comment. Some random comments, I'll leave the real review to the VSCode experts. Comment at: lldb/tools/lldb-vscode/JSONUtils.h:239 +/// useful to ensure the same column provided by the setBreakpoints request +/// are returned to the IDE as a fallb

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

cor3ntin added a comment. It would be great if we could make progress on this for clang 17, I was told it's forcing some people to use other compilers. Are the recent changes to the itanium abi enough to complete this work? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/ne