jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
this looks good to me. I'm a little overly paranoid about specifying when things are file addresses versus load addresses -- I'm sure that anyone working in this context would know these are file addresses being returned, but I would probably say that in the prototype doc strings e.g. "Return the file address specified". That's more of a personal style thing than anything important tho. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154265/new/ https://reviews.llvm.org/D154265 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
