[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rG21dfaf60a763: Setting to control addressable bits in high memory (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151292/new/ https

[Lldb-commits] [lldb] 21dfaf6 - Setting to control addressable bits in high memory

Author: Jason Molenda Date: 2023-05-31T18:38:34-07:00 New Revision: 21dfaf60a763795e3834d67def48fc2ba5214e59 URL: https://github.com/llvm/llvm-project/commit/21dfaf60a763795e3834d67def48fc2ba5214e59 DIFF: https://github.com/llvm/llvm-project/commit/21dfaf60a763795e3834d67def48fc2ba5214e59.diff

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

jasonmolenda updated this revision to Diff 527251. jasonmolenda added a comment. Updated patch with Alex and Jonas' feedback incorporated. Most significantly, instead of making target.process.virtual-addressable-bits an array of uint values (between zero to two of them), I am leaving virtual-ad

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

bulbazord planned changes to this revision. bulbazord added a comment. In D151765#4385711 , @jingham wrote: > Why did you choose to have a separate FileSpecBuilder class, rather than > making FileSpec smarter about the structure of the path (e.g. have an

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

jingham added a comment. I'd also maybe call this the Target "Label" not the Name. We have a fairly strong use of Name for breakpoint names, and this doesn't have that character at all. Also, if they are Labels, I think it's legit for us to keep them unique, which I think is more sane than tr

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

bulbazord added a comment. In D151859#4385986 , @jingham wrote: > Make sure we do something sensible with "target select " if the user > has given the same name to two targets (or disallow doing that, one or the > other). In addition to this, what happ

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

jingham added a comment. Make sure we do something sensible with "target select " if the user has given the same name to two targets (or disallow doing that, one or the other). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151859/new/ https://revi

[Lldb-commits] [PATCH] D151861: Don't emit a bunch of spurious "Unknown platform 0" warnings from debugserver

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Ah good catch, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151861/new/ https://re

[Lldb-commits] [PATCH] D151861: Don't emit a bunch of spurious "Unknown platform 0" warnings from debugserver

jingham created this revision. jingham added a reviewer: jasonmolenda. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The code that was trying to get the platform string was passing the MachProcess::De

[Lldb-commits] [lldb] ed7be0d - lldb: Fix cross-cu-reference test to explicitly request that feature

Author: David Blaikie Date: 2023-06-01T00:35:39Z New Revision: ed7be0d4d17b5d1470587643cd5c55157414bb9c URL: https://github.com/llvm/llvm-project/commit/ed7be0d4d17b5d1470587643cd5c55157414bb9c DIFF: https://github.com/llvm/llvm-project/commit/ed7be0d4d17b5d1470587643cd5c55157414bb9c.diff LOG:

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

bulbazord added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:315 + llvm::StringRef name = m_name.GetOptionValue().GetCurrentValueAsRef(); + if (!name.empty()) nit: Comment at: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

mib added a comment. I still need to add some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151859/new/ https://reviews.llvm.org/D151859 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch add the ability for the user to set a name for a target. This can be

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:1373-1374 +arch = crashlog.process_arch +if not arch: +arch = platform.machine() +target = debugger.CreateTargetWithFileAndArch(None, arch) mib wrote

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:493 self.images = list() +self.crashlog = CrashLog(debugger, self.path, self.verbose) bulbazord wrote: > Any reason you moved this? It

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

bulbazord accepted this revision. bulbazord added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/crashlog.py:493 self.images = list() +self.crashlog = CrashLog(debugger, self.path, self.verbose) --

[Lldb-commits] [PATCH] D151844: [lldb/crashlog] Fix crash when loading non-symbolicated report

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:599-602 +if 'symbol' in json_frame: +symbol = json_frame['symbol'] +location = 0 +if "symbolLocation" in json_frame and json_frame["symbolLocation"

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

jingham added a comment. Why did you choose to have a separate FileSpecBuilder class, rather than making FileSpec smarter about the structure of the path (e.g. have an array of StringRef's into the paths for each component.) We could do the parse once the first time a path element was request

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the way we load a crash report into a scripted process by creating a e

[Lldb-commits] [PATCH] D151844: [lldb/crashlog] Fix crash when loading non-symbolicated report

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:599-602 +if 'symbol' in json_frame: +symbol = json_frame['symbol'] +location = 0 +if "symbolLocation" in json_frame and json_frame["symbolLoc

[Lldb-commits] [PATCH] D151844: [lldb/crashlog] Fix crash when loading non-symbolicated report

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should address the crashes when parsing a the crash report frame dictionary.

[Lldb-commits] [PATCH] D151843: Add EXC_SYSCALL to the allowable ignored exceptions for Darwin

jingham created this revision. jingham added reviewers: JDevlieghere, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. EXC_SYSCALL has the same problem as EXC_BAD_INSTRUCTION and EXC_BAD_ACCESS, the

[Lldb-commits] [lldb] 7de4352 - HostInfoMacOS: Add a utility function for finding an SDK-specific tool

Author: Adrian Prantl Date: 2023-05-31T14:46:35-07:00 New Revision: 7de43526e3cc07a02d01a0c4bf0670900495b938 URL: https://github.com/llvm/llvm-project/commit/7de43526e3cc07a02d01a0c4bf0670900495b938 DIFF: https://github.com/llvm/llvm-project/commit/7de43526e3cc07a02d01a0c4bf0670900495b938.diff

[Lldb-commits] [lldb] a5e9f2c - Factor out xcrun into a function (NFC)

Author: Adrian Prantl Date: 2023-05-31T14:46:35-07:00 New Revision: a5e9f2c81ebced1ea41060fc0d89b9233bc1b7be URL: https://github.com/llvm/llvm-project/commit/a5e9f2c81ebced1ea41060fc0d89b9233bc1b7be DIFF: https://github.com/llvm/llvm-project/commit/a5e9f2c81ebced1ea41060fc0d89b9233bc1b7be.diff

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord added a comment. In D151597#4384734 , @mib wrote: > TBH, it feels like a lot of - risky - changes just so > `IOHandlerGetControlSequence` can return a `llvm::StringRef` ? Is that really > necessary ? I assume you're referring to `IOHandlerDel

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c122d0ea1d: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1518

[Lldb-commits] [lldb] 57c122d - [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

Author: Dave Lee Date: 2023-05-31T11:02:44-07:00 New Revision: 57c122d0ea1db38116ea9128a2c273204248bc67 URL: https://github.com/llvm/llvm-project/commit/57c122d0ea1db38116ea9128a2c273204248bc67 DIFF: https://github.com/llvm/llvm-project/commit/57c122d0ea1db38116ea9128a2c273204248bc67.diff LOG:

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:434 ValueObjectSP root(GetSP()); - for (ConstString name : names) { + for (auto name : names) { root = root->GetChildMemberWithName(name, true); bulbazord wrote: > kastiglio

[Lldb-commits] [PATCH] D151591: HostInfoMacOS: Add a utility function for finding an SDK-specific tool

mib added inline comments. Comment at: lldb/unittests/Host/HostInfoTest.cpp:90 + EXPECT_FALSE(find_tool("MacOSX.sdk", "clang").empty()); + EXPECT_TRUE(find_tool("MacOSX.sdk", "CeciNestPasUnOutil").empty()); +} JDevlieghere wrote: > LOL ^^ CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

mib added a comment. TBH, it feels like a lot of - risky - changes just so `IOHandlerGetControlSequence` can return a `llvm::StringRef` ? Is that really necessary ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

bulbazord accepted this revision. bulbazord added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:434 ValueObjectSP root(GetSP()); - for (ConstString name : names) { + for (auto name : names) { root = root->GetChildMemberWithName(name, true); -

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

bulbazord accepted this revision. bulbazord added a comment. Very straightforward. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151810/new/ https://reviews.llvm.org/D151810 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Core/ValueObject.h:483 // this will always create the children if necessary - lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef names, - ConstString *name_of_error = n

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338 if (!did_find && m_synth_filter_up != nullptr) { uint32_t index = m_synth_filter_up->GetI

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:434 ValueObjectSP root(GetSP()); - for (ConstString name : names) { + for (auto name : names) { root = root->GetChildMemberWithName(name, true); ---

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151810/new/ https://reviews.llvm.org/D151810 ___

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/include/lldb/Core/ValueObject.h:483 // this will always create the children if necessary - lldb::ValueObjectSP GetChildAtNamePath(llvm::Arra

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following D151810 , this changes

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As with D151615

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change the type of the `name`

[Lldb-commits] [PATCH] D151384: [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7578672c96e1: [lldb] Override GetVariable in ValueObjectSynthetic (NFC) (authored by kastiglione). Repository: rG LLVM

[Lldb-commits] [lldb] 7578672 - [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

Author: Dave Lee Date: 2023-05-31T08:19:36-07:00 New Revision: 7578672c96e18feb5982192e595459b2a65867cf URL: https://github.com/llvm/llvm-project/commit/7578672c96e18feb5982192e595459b2a65867cf DIFF: https://github.com/llvm/llvm-project/commit/7578672c96e18feb5982192e595459b2a65867cf.diff LOG:

[Lldb-commits] [PATCH] D151384: [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

kastiglione added a comment. Jim approved offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151384/new/ https://reviews.llvm.org/D151384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D151615: [lldb] Take StringRef name in GetChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb463c34dd4c: [lldb] Take StringRef name in GetChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151615/new/

[Lldb-commits] [lldb] cb463c3 - [lldb] Take StringRef name in GetChildMemberWithName (NFC)

Author: Dave Lee Date: 2023-05-31T08:08:40-07:00 New Revision: cb463c34dd4c3ad2ac6c13f98edcf684a3fcbe38 URL: https://github.com/llvm/llvm-project/commit/cb463c34dd4c3ad2ac6c13f98edcf684a3fcbe38 DIFF: https://github.com/llvm/llvm-project/commit/cb463c34dd4c3ad2ac6c13f98edcf684a3fcbe38.diff LOG:

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

erichkeane added a comment. In D151683#4382408 , @philnik wrote: > In D151683#4380877 , @erichkeane > wrote: > >> What is the justification for this? > > What exactly are you asking for? Why I'd like to back port