[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

xen0n accepted this revision. xen0n added a comment. Also LGTM for the LoongArch bits. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138407/new/ https://reviews.llvm.org/D138407 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added a comment. > Regarding the public buildbot, I'm trying to set it up and maybe we can see > it in one or two weeks. FYI. D138672 is the review for adding LoongArch buildbot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

jasonmolenda added a comment. In D138612#3950102 , @jasonmolenda wrote: > > I didn't look into this patch enough to say whether this is a real failure, > or if the test assumes behavior that is only true with the accelerator tables > used in DWARF

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

jasonmolenda added a comment. In D138612#3950098 , @aeubanks wrote: > In D138612#3949869 , @jasonmolenda > wrote: > >> Hi Arthur, this change is causing a testsuite failure on Darwin systems - >> see https://gre

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. In D138612#3949869 , @jasonmolenda wrote: > Hi Arthur, this change is causing a testsuite failure on Darwin systems - see > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48671/ on the "LLDB > Incremental" bot - and

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

Ah, little misstatement below. My first thought was that promise_type was null, but when I stepped through here with a debugger, it was not. I didn't know how to dig in to a CompilerType object but there was some reason why this CreateValueObjectFromAddress failed to return an actual ValueObje

[Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

Hi Adrian, the green dragon Incremental CI bot has been failing the past couple of days after the changes for the coroutines formatter, most directly https://reviews.llvm.org/D132815 landed - TestCoroutineHandle.py results in a segfault on Darwin systems (both on the CI and on my mac desktop)

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

jasonmolenda added a comment. Hi Arthur, this change is causing a testsuite failure on Darwin systems - see https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48671/ on the "LLDB Incremental" bot - and I can reproduce this failure on my local mac. Would you like to revert this until you

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG33ac4fddc790: Change debugserver to spawn processes in their own pgrp (authored by jasonmolenda). Repository: rG LLVM G

[Lldb-commits] [lldb] 33ac4fd - Change debugserver to spawn processes in their own pgrp

Author: Jason Molenda Date: 2022-11-24T10:59:12-08:00 New Revision: 33ac4fddc7906ba712c50cd3a9b02ae041d751ab URL: https://github.com/llvm/llvm-project/commit/33ac4fddc7906ba712c50cd3a9b02ae041d751ab DIFF: https://github.com/llvm/llvm-project/commit/33ac4fddc7906ba712c50cd3a9b02ae041d751ab.diff

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c423b6cb2e: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE (authored by aeubanks). Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] c3c423b - [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

Author: Arthur Eubanks Date: 2022-11-24T08:39:46-08:00 New Revision: c3c423b6cb2e1c00483e951ce8cc4d935e31cd14 URL: https://github.com/llvm/llvm-project/commit/c3c423b6cb2e1c00483e951ce8cc4d935e31cd14 DIFF: https://github.com/llvm/llvm-project/commit/c3c423b6cb2e1c00483e951ce8cc4d935e31cd14.diff

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3948707 , @labath wrote: > I am puzzled by the OSO changes in the DIERef class. How do they tie in with > the increase in the offset size? It seems like it should at best be a > separate patch... That part was more

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

SixWeining accepted this revision. SixWeining added a comment. My comments are all addressed. LGTM from the LoongArch side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138407/new/ https://reviews.llvm.org/D138407 ___ lldb-commits mailing li

[Lldb-commits] [lldb] 73dba0e - Fix remaining build errors introduced in D90568 - 15e76eed0c7.

Author: Nathan James Date: 2022-11-24T14:01:08Z New Revision: 73dba0e3bdc66aff89a0313f1c528af6d7649607 URL: https://github.com/llvm/llvm-project/commit/73dba0e3bdc66aff89a0313f1c528af6d7649607 DIFF: https://github.com/llvm/llvm-project/commit/73dba0e3bdc66aff89a0313f1c528af6d7649607.diff LOG:

[Lldb-commits] [lldb] 0923628 - Fix build error introduced in D90568 - 15e76eed0c7

Author: Nathan James Date: 2022-11-24T13:42:53Z New Revision: 0923628d26d2c01decbd79804828a5e8df92c827 URL: https://github.com/llvm/llvm-project/commit/0923628d26d2c01decbd79804828a5e8df92c827 DIFF: https://github.com/llvm/llvm-project/commit/0923628d26d2c01decbd79804828a5e8df92c827.diff LOG:

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good from the LLDB side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138407/new/ https://reviews.llvm.org/D138407 __

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. I am puzzled by the OSO changes in the DIERef class. How do they tie in with the increase in the offset size? It seems like it should at best be a separate patch... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/

[Lldb-commits] [lldb] 42237d5 - [lldb] Fix PathMappingListTest for the Optional interface change

Author: Pavel Labath Date: 2022-11-24T11:11:05+01:00 New Revision: 42237d51abf00417f5a3164d843e245ad584f7c4 URL: https://github.com/llvm/llvm-project/commit/42237d51abf00417f5a3164d843e245ad584f7c4 DIFF: https://github.com/llvm/llvm-project/commit/42237d51abf00417f5a3164d843e245ad584f7c4.diff