Ah, little misstatement below. My first thought was that promise_type was null, but when I stepped through here with a debugger, it was not. I didn't know how to dig in to a CompilerType object but there was some reason why this CreateValueObjectFromAddress failed to return an actual ValueObject, and I assumed it's something to do with that CompilerType. But I didn't dig in far enough to understand what the issue in the type was.
> On Nov 24, 2022, at 1:20 PM, Jason Molenda <ja...@molenda.com> wrote: > > Hi Adrian, the green dragon Incremental CI bot has been failing the past > couple of days after the changes for the coroutines formatter, most directly > https://reviews.llvm.org/D132815 landed - TestCoroutineHandle.py results in > a segfault on Darwin systems (both on the CI and on my mac desktop) > consistently. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ > > It's crashing in formatters::StdlibCoroutineHandleSyntheticFrontEnd where > you're doing > > ``` > // Add the `promise` member. We intentionally add `promise` as a pointer type > // instead of a value type, and don't automatically dereference this pointer. > // We do so to avoid potential very deep recursion in case there is a cycle > in > // formed between `std::coroutine_handle`s and their promises. > lldb::ValueObjectSP promise = CreateValueObjectFromAddress( > "promise", frame_ptr_addr + 2 * ptr_size, exe_ctx, promise_type); > Status error; > lldb::ValueObjectSP promisePtr = promise->AddressOf(error); > ``` > > and the promise_type dose not have a CompilerType so promisePtr is nullptr > and we crash on the method call to AddressOf. I looked briefly, but this > isn't a part of lldb I know well and I'm not sure the nature of the problem. > > It's a long weekend in the US, so if you have a suggestion for addressing > this that'd be great, or I can roll back the changes necessary to get the bot > clean later today and we can look at this next week. > > Thanks! _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
