[Lldb-commits] [lldb] 3e03873 - [lldb][Test] Fix TestFrameFormatNameWithArgs.test on Windows/Linux

Author: Michael Buch Date: 2022-10-31T22:59:16-07:00 New Revision: 3e03873e363b5aa90e4488da63a6de0648d11aba URL: https://github.com/llvm/llvm-project/commit/3e03873e363b5aa90e4488da63a6de0648d11aba DIFF: https://github.com/llvm/llvm-project/commit/3e03873e363b5aa90e4488da63a6de0648d11aba.diff

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137137/new/ https://reviews.llvm.org/D137137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

mib updated this revision to Diff 472211. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137137/new/ https://reviews.llvm.org/D137137 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

Michael137 added a comment. In D136761#3897029 , @stella.stamenova wrote: > Looks like in addition to the Linux failure, this also broke the Windows LLDB > bot: > https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio Thanks for l

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Should this be controllable with a setting? I'm not sure I (always) want my editor to pop up when I save a transcript. Comment at: lldb/source/Interpreter/Comman

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch will automatically open LLDB's saved transcript file on the graphical editor

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 472185. jgorbe added a comment. - Removed `-R` short option to avoid confusion with regex. Updated doc, test case, and example. - Added some logic to make `--recognizer-function` and `--regex` mutually exclusive. Specifying both now results in an error being

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Thanks Egor! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan updated this revision to Diff 472171. egorzhdan added a comment. Preserve `CodeCompletionResult::ResultKind` and do the conversion to `CXCompletionResultKind` in `CIndexCodeCompletion.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. I'm looking at the option of using a non-printable character for the short flag, and at the same time make `--regex` and `--recognizer-function` mutually exclusive using option groups. One problem I see is that the command help gets pretty confusing. Using a non-printabl

[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aed0ce20fc6: [lldb] Emit diagnostic events in the diagnostic dump (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d01300aacf6: [lldb] Add a "diagnostics dump" command (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] 8aed0ce - [lldb] Emit diagnostic events in the diagnostic dump

Author: Jonas Devlieghere Date: 2022-10-31T14:40:41-07:00 New Revision: 8aed0ce20fc6be41a7e49ea1433095d4cf583e56 URL: https://github.com/llvm/llvm-project/commit/8aed0ce20fc6be41a7e49ea1433095d4cf583e56 DIFF: https://github.com/llvm/llvm-project/commit/8aed0ce20fc6be41a7e49ea1433095d4cf583e56.d

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG84ea6b6f78df: [lldb] Add diagnostics (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Gith

[Lldb-commits] [lldb] 0d01300 - [lldb] Add a "diagnostics dump" command

Author: Jonas Devlieghere Date: 2022-10-31T14:40:41-07:00 New Revision: 0d01300aacf6029b6d63f7dcede3ca8e15229d34 URL: https://github.com/llvm/llvm-project/commit/0d01300aacf6029b6d63f7dcede3ca8e15229d34 DIFF: https://github.com/llvm/llvm-project/commit/0d01300aacf6029b6d63f7dcede3ca8e15229d34.d

[Lldb-commits] [lldb] 84ea6b6 - [lldb] Add diagnostics

Author: Jonas Devlieghere Date: 2022-10-31T14:40:38-07:00 New Revision: 84ea6b6f78df789db6724ef8d774cf04d94d2313 URL: https://github.com/llvm/llvm-project/commit/84ea6b6f78df789db6724ef8d774cf04d94d2313 DIFF: https://github.com/llvm/llvm-project/commit/84ea6b6f78df789db6724ef8d774cf04d94d2313.d

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

dblaikie added a comment. In D137098#3897289 , @aeubanks wrote: > updated description with why this doesn't produce false positives with > breakpoints > > this doesn't support regex function name lookup, not sure if we care enough > about the interactio

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks added a comment. updated description with why this doesn't produce false positives with breakpoints this doesn't support regex function name lookup, not sure if we care enough about the interaction between regexes/function names under simple template names. if we do, we could instead

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. > You can't provide the --regex option and this matcher at the same time Thanks for spotting this. I'll get to it. > it is also an error to have both this matcher function and any arguments in > the argument list Not with the code as it is. I've made the new flag have s

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks added a comment. Herald added a subscriber: JDevlieghere. (I don't understand why this works yet, it should be giving us false positives?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137098/new/ https://reviews.llvm.org/D137098

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks created this revision. Herald added a subscriber: arphaman. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This makes setting breakpoints work with -gsimple-template-names. Repository: rG

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet wrote: > egorzhdan wrote: > > kadircet wrote: > > > i d

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

stella.stamenova added a comment. Looks like in addition to the Linux failure, this also broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136761/ne

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks updated this revision to Diff 472061. aeubanks added a comment. capitalize comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137045/new/ https://reviews.llvm.org/D137045 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7612 + ->getIntegerType() + ->isSpecificBuiltinType(BuiltinType::Bool)) && "only boolean supported"); DavidSpickett wrote: > C

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks updated this revision to Diff 472053. aeubanks added a comment. Herald added a reviewer: shafik. undo a lot of code added in D135169 . it seems a little overengineered when we can just check if the type is bool when setting the initializer. Repository

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. Not really the place for it, but the idea is: if lldb launched a process, when lldb quits, the inferior process should be killed. But if lldb attached to a running process, when lldb quits, the inferior process should be

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG279fe6281d2c: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [lldb] 279fe62 - [clang] Instantiate alias templates with sugar

Author: Matheus Izvekov Date: 2022-10-31T17:57:19+01:00 New Revision: 279fe6281d2ca5b2318c7437316c28750feaac8d URL: https://github.com/llvm/llvm-project/commit/279fe6281d2ca5b2318c7437316c28750feaac8d DIFF: https://github.com/llvm/llvm-project/commit/279fe6281d2ca5b2318c7437316c28750feaac8d.dif

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks good. The one detail that remains is error handling for the command. You can't provide the --regex option and this matcher at the same time, and it is also an error to

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov updated this revision to Diff 472021. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://reviews.llvm.org/D136565 Files: clang-tools-extra/clangd/unittests/HoverTests.cpp clang/lib/Sema/SemaTemplate.cpp clang/test/AST/a

[Lldb-commits] [lldb] 9dd413a - [lldb][Test] Fix TestFrameFormatNameWithArgs.test on Linux

Author: Michael Buch Date: 2022-10-31T14:35:37Z New Revision: 9dd413a1be61f8fd84e67d255a245260755d8230 URL: https://github.com/llvm/llvm-project/commit/9dd413a1be61f8fd84e67d255a245260755d8230 DIFF: https://github.com/llvm/llvm-project/commit/9dd413a1be61f8fd84e67d255a245260755d8230.diff LOG:

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

Michael137 added a comment. Closed with commit `031096d04d09ac4a93859d161fb42d1a1b308253` (for some reason the Phab link wasn't in the commit message) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136761/new/ https://reviews.llvm.org/D136761

[Lldb-commits] [lldb] 6268a67 - [LLDB][AArch64] Add SME2 to disassembler test

Author: David Spickett Date: 2022-10-31T14:13:55Z New Revision: 6268a6704a848ab880f1740f420e18449d9c06f2 URL: https://github.com/llvm/llvm-project/commit/6268a6704a848ab880f1740f420e18449d9c06f2 DIFF: https://github.com/llvm/llvm-project/commit/6268a6704a848ab880f1740f420e18449d9c06f2.diff LOG

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

Michael137 added inline comments. Comment at: lldb/test/Shell/Settings/TestFrameFormatNameWithArgs.test:14 +c +# CHECK: frame int ns::foo>(t= Function = (anonymous namespace)::anon_bar() ) +c The `__1` breaks the linux build bots apparently. Will make this check

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

labath added a comment. Seems fine to me. Comment at: lldb/source/Commands/Options.td:1231 Desc<"Type names are actually regular expressions.">; + def type_synth_add_recognizer_function : Option<"recognizer-function", "R">, +Desc<"Type names are actually the names of

[Lldb-commits] [lldb] 76f34ed - [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

Author: Michael Buch Date: 2022-10-31T12:25:18Z New Revision: 76f34ed2837880c1865202f28988b01c93ac4f89 URL: https://github.com/llvm/llvm-project/commit/76f34ed2837880c1865202f28988b01c93ac4f89 DIFF: https://github.com/llvm/llvm-project/commit/76f34ed2837880c1865202f28988b01c93ac4f89.diff LOG:

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

This revision was automatically updated to reflect the committed changes. Closed by commit rG76f34ed28378: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 031096d - [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

Author: Michael Buch Date: 2022-10-31T12:25:19Z New Revision: 031096d04d09ac4a93859d161fb42d1a1b308253 URL: https://github.com/llvm/llvm-project/commit/031096d04d09ac4a93859d161fb42d1a1b308253 DIFF: https://github.com/llvm/llvm-project/commit/031096d04d09ac4a93859d161fb42d1a1b308253.diff LOG:

[Lldb-commits] [PATCH] D136934: [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0bf48c7b179: [lldb][FormatEntity][NFC] Move function argument parsing code into separate… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] d0bf48c - [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

Author: Michael Buch Date: 2022-10-31T12:25:18Z New Revision: d0bf48c7b179027d978c479167e23825b8d0c4f6 URL: https://github.com/llvm/llvm-project/commit/d0bf48c7b179027d978c479167e23825b8d0c4f6 DIFF: https://github.com/llvm/llvm-project/commit/d0bf48c7b179027d978c479167e23825b8d0c4f6.diff LOG:

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This isn't your fault, but this `GetFunctionDisplayName` doesn't seems particularly well suited, as it forces you to reimplement a lot of the printing functionality for each language plugin.

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

seehearfeel updated this revision to Diff 471973. seehearfeel added a comment. (1) Rename LOONGARCHSubType to LoongArchSubType (2) Define min_opcode_byte_size as 4 for LoongArch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137057/new/ https://reviews.llvm.org/D137057 Files: lldb/inc

[Lldb-commits] [PATCH] D136934: [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

Michael137 added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1057 + // the arguments list + if (generic && open_paren && generic < open_paren) { +int generic_depth = 1; labath wrote: > aprantl wrote: > > Would be nice to rewrite this on t

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

seehearfeel added a comment. In D137057#3895926 , @DavidSpickett wrote: > Looks good to me. Thanks for your review. Let me update the diff to do some small modifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D136935: [lldb][CPlusPlus] Introduce CPlusPlusLanguage::MethodName::GetReturnType

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D136935#3892336 , @Michael137 wrote: > In D136935#3892082 , @labath wrote: > >> The return type handling

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

seehearfeel added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:223 +{eByteOrderLittle, 4, 1, 4, llvm::Triple::loongarch32, + ArchSpec::eCore_loongarch32, "loongarch32"}, SixWeining wrote: > xen0n wrote: > > `min_opcode_byte_size` should

[Lldb-commits] [PATCH] D136934: [lldb][FormatEntity][NFC] Move function argument parsing code into separate functions

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1057 + // the arguments list + if (generic && open_paren && generic < open_paren) { +int generic_depth = 1; aprantl wrote: > Would be nice to rewrite

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

SixWeining added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:223 +{eByteOrderLittle, 4, 1, 4, llvm::Triple::loongarch32, + ArchSpec::eCore_loongarch32, "loongarch32"}, xen0n wrote: > `min_opcode_byte_size` should be 4 too, all LoongArc

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

xen0n added inline comments. Comment at: lldb/include/lldb/Utility/ArchSpec.h:111 + enum LOONGARCHSubType { +eLOONGARCHSubType_unknown, Should be `LoongArch`. It's that way everywhere else in LLVM land. Comment at: lldb/source/Utility/Ar

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137057/new/ https://reviews.llvm.org/D137057

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7612 + ->getIntegerType() + ->isSpecificBuiltinType(BuiltinType::Bool)) && "only boolean supported"); Can you call `TypeS

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. egorzhdan wrote: > kadircet wrote: > > i don't follow the reason

[Lldb-commits] [PATCH] D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

Emmmer added a comment. In D136362#3895385 , @seehearfeel wrote: > ... > This is OK used with gcc/c++ 12. > ... > We can see that "ninja check-lldb" failed due to OOM > used with gcc/c++ 13. Then I guess it is a gcc-specific bug and you could try to rep

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

seehearfeel created this revision. seehearfeel added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, DavidSpickett. Herald added subscribers: StephenFan, emaste. Herald added a project: All. seehearfeel requested review of this revision. Herald added a project: LLDB. Herald added a subsc