labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This isn't your fault, but this `GetFunctionDisplayName` doesn't seems 
particularly well suited, as it forces you to reimplement a lot of the printing 
functionality for each language plugin.  I'd expect the customization point to 
be something like your helper `PrettyPrintFunctionNameWithArgs` function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136761/new/

https://reviews.llvm.org/D136761

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to