[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

tschuett added inline comments. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:6264 major_version, minor_version, patch_version); -if (platform) { +if (platform.has_value()) { os_handled = true; ---

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi added a comment. Thanks for the fix Will! Just one question: cpp test file contains the expression `a[10].c` and the test complains about the expression path `a->c`. If I understand correctly, with the latest fix, that would become `a[10]->c`, which is not the original expression (objec

[Lldb-commits] [lldb] 59f0827 - [clang] Instantiate alias templates with sugar

Author: Matheus Izvekov Date: 2022-10-27T06:18:52+02:00 New Revision: 59f0827e2cf3755834620e7e0b6d946832440f80 URL: https://github.com/llvm/llvm-project/commit/59f0827e2cf3755834620e7e0b6d946832440f80 DIFF: https://github.com/llvm/llvm-project/commit/59f0827e2cf3755834620e7e0b6d946832440f80.dif

[Lldb-commits] [PATCH] D136801: [intelpt] Update Python tests to account for new errrors

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136801/new/ https://reviews.llvm.org/D136801 __

[Lldb-commits] [lldb] 7bbd0fb - Revert "[lldb-vscode] Send Statistics Dump in terminated event"

Author: Wanyi Ye Date: 2022-10-26T19:49:03-07:00 New Revision: 7bbd0fba986c241162b77b7e424ad82bc7e17b41 URL: https://github.com/llvm/llvm-project/commit/7bbd0fba986c241162b77b7e424ad82bc7e17b41 DIFF: https://github.com/llvm/llvm-project/commit/7bbd0fba986c241162b77b7e424ad82bc7e17b41.diff LOG:

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:29 +lldb::SBError BreakpointBase::AppendLogMessagePart(llvm::StringRef part, +

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

clayborg added a comment. In D126014#3886996 , @jgorbe wrote: > Hi! I've just debugged an issue that brought me to this commit. I'll start > preparing a patch tomorrow (not sure how to test it yet) but since it's a > recent-ish change I figured I'd ping

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

JDevlieghere added a comment. Thanks Will, let me apply this locally and see if that addresses the issue for which I reverted the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 _

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with @rupprecht's comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136798/new/ https://reviews.llvm.org/D136798 __

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 470975. JDevlieghere added a comment. Remove spurious `lldb` subdir CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Utility/Diagnostics.

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added a comment. Hi! I've just debugged an issue that brought me to this commit. I'll start preparing a patch tomorrow (not sure how to test it yet) but since it's a recent-ish change I figured I'd ping the commit thread to give you a heads up. `v.GetSummary()` returns a char* that is ba

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda updated this revision to Diff 470972. jasonmolenda added a comment. Update patch to pass std::string's in the optionals, and use std::nullopt. Thanks for all the feedback on this one, Thorsten. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Two other places you might need to update as well Comment at: lldb/examples/python/crashlog.py:452 with open(path, 'r') as f: buffer = f.read()

[Lldb-commits] [PATCH] D136801: [intelpt] Update Python tests to account for new errrors

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update the Python tests (ie tests run via `lldb-dotest -p TestTrace`) to hand

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

augusto2112 created this revision. augusto2112 added reviewers: mib, JDevlieghere, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The python "open" function will use the default encoding fo

[Lldb-commits] [PATCH] D136795: [LLDB] Mark placeholder modules in `target module list` output.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minidump may contain modules that are created from placeholder object files if they are

[Lldb-commits] [lldb] cb0eb9d - [test] Fix LLDB tests with just-built libcxx when using a target directory.

Author: Jordan Rupprecht Date: 2022-10-26T12:07:22-07:00 New Revision: cb0eb9d8dd5a74ed33d5dd5c62686fb6342b10bc URL: https://github.com/llvm/llvm-project/commit/cb0eb9d8dd5a74ed33d5dd5c62686fb6342b10bc DIFF: https://github.com/llvm/llvm-project/commit/cb0eb9d8dd5a74ed33d5dd5c62686fb6342b10bc.di

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0eb9d8dd5a: [test] Fix LLDB tests with just-built libcxx when using a target directory. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda added a comment. In D136719#3886254 , @tschuett wrote: > Looks great, but I would have expected `std::optional` and a > `nullopt`. Yeah I'm fine with that, it does seems more natural. In this case we're returning the address of a half-doz

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

tschuett added a comment. Looks great, but I would have expected `std::optional` and a `nullopt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136719/new/ https://reviews.llvm.org/D136719 ___ lldb-comm

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6eb089734dd: [trace][intelpt] Fix multi CPU decoding TSC assertion error (authored by jj10306). Changed prior to commit: https://reviews.llvm.org/D136610?vs=470472&id=470887#toc Repository: rG LLVM

[Lldb-commits] [lldb] f6eb089 - [trace][intelpt] Fix multi CPU decoding TSC assertion error

Author: Jakob Johnson Date: 2022-10-26T11:37:30-07:00 New Revision: f6eb089734ddbd7f9b9935a122ff4ad658f06360 URL: https://github.com/llvm/llvm-project/commit/f6eb089734ddbd7f9b9935a122ff4ad658f06360 DIFF: https://github.com/llvm/llvm-project/commit/f6eb089734ddbd7f9b9935a122ff4ad658f06360.diff

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda updated this revision to Diff 470885. jasonmolenda added a comment. Update MachProcess::GetPlatformString to return a std::optional platform string, if the platform enumeration is recognized. Update callers to handle the absence of a value appropriately. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D135983: [lldb] Fix a -Wdeprecated-declarations warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG0af7280a5ee0: [lldb] Fix a -Wdeprecated-declarations warning (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135983/new/ https://reviews

[Lldb-commits] [lldb] 0af7280 - [lldb] Fix a -Wdeprecated-declarations warning

Author: Nico Weber Date: 2022-10-26T13:34:56-04:00 New Revision: 0af7280a5ee005737fbf1b709909d9600e2b5c75 URL: https://github.com/llvm/llvm-project/commit/0af7280a5ee005737fbf1b709909d9600e2b5c75 DIFF: https://github.com/llvm/llvm-project/commit/0af7280a5ee005737fbf1b709909d9600e2b5c75.diff LO

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

tschuett added a comment. In D136719#3885974 , @jasonmolenda wrote: > In D136719#3884836 , @tschuett > wrote: > >> How about an optional instead, if GetPlatformString is fallible. > > Ah, interesting idea. debu

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda added a comment. In D136719#3884836 , @tschuett wrote: > How about an optional instead, if GetPlatformString is fallible. Ah, interesting idea. debugserver doesn't use any llvm, but I believe we're building with C++17 these days so I could

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 470837. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Tes

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:52 logMessage_prefix = "This is log message for { -- " -# Trailing newline is needed for splitlines() -logMessage = logMessage_prefix + "{i +

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

Michael137 added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1673 if (open_paren) - close_paren = strchr(open_paren, ')'); + close_paren = strrchr(open_paren, ')'); } else labath

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

labath added a comment. In D136761#3885557 , @Michael137 wrote: > In D136761#3885529 , @labath wrote: > >> Wow, another name parser I knew nothing about. :/ >> >> I'm probably being naive, but I don't suppose the

[Lldb-commits] [PATCH] D136766: [lldb][Docs][NFC] Fix sphinx warnings/errors for LLDB docs

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ran `ninja docs-lldb-html` and made sure the docs are fixed. Repository: rG

[Lldb-commits] [PATCH] D136650: Add a check for TypeSystem use-after-free problems

labath added a comment. The Halloween theme is nice, but I think it'd be more traditional if we kept a list of active instances, instead of inactive ones. That said, a part of me dies every time I see a class keeping a list of its instances. I don't know if you've seen it, but I think the `Modu

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

Michael137 added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1673 if (open_paren) - close_paren = strchr(open_paren, ')'); + close_paren = strrchr(open_paren, ')'); } else labath

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

Michael137 added a comment. In D136761#3885529 , @labath wrote: > Wow, another name parser I knew nothing about. :/ > > I'm probably being naive, but I don't suppose there's an easy a way to > reuse/repurpose the parser in the C++ language plugin for thi

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

labath added a comment. Wow, another name parser I knew nothing about. :/ I'm probably being naive, but I don't suppose there's an easy a way to reuse/repurpose the parser in the C++ language plugin for this (?) This is the first time I see this code, so it's hard to construct counter-examples,

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw added a comment. If you would like, I'd be happy to reopen this patch as a separate issue if that's the better way to handle it! Sorry for the SPAM! Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

Michael137 updated this revision to Diff 470791. Michael137 added a comment. - Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136761/new/ https://reviews.llvm.org/D136761 Files: lldb/source/Core/FormatEntity.cpp lldb/test/Sh

[Lldb-commits] [lldb] 6cc5bcc - [LLDB] Correct env vars for Android port selection

Author: David Spickett Date: 2022-10-26T12:31:27Z New Revision: 6cc5bcc12d3095376fa28b794b3bbb09ea6a9e4e URL: https://github.com/llvm/llvm-project/commit/6cc5bcc12d3095376fa28b794b3bbb09ea6a9e4e DIFF: https://github.com/llvm/llvm-project/commit/6cc5bcc12d3095376fa28b794b3bbb09ea6a9e4e.diff LOG

[Lldb-commits] [PATCH] D136761: [lldb][FormatEntity] Fix closing parenthesis for function.name-with-args frame format

Michael137 created this revision. Michael137 added reviewers: aprantl, labath, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we would try to find the closing parenthesis by doing

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

tschuett added a comment. How about an optional instead, if GetPlatformString is fallible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136719/new/ https://reviews.llvm.org/D136719 ___ lldb-commits mail

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

DavidSpickett added a comment. Thanks for your efforts here, very much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136465/new/ https://reviews.llvm.org/D136465 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] a58d83b - Revert "[clang] Instantiate alias templates with sugar"

Author: Matheus Izvekov Date: 2022-10-26T10:14:21+02:00 New Revision: a58d83b2c97cd480a8533b11b86c7cd709c48176 URL: https://github.com/llvm/llvm-project/commit/a58d83b2c97cd480a8533b11b86c7cd709c48176 DIFF: https://github.com/llvm/llvm-project/commit/a58d83b2c97cd480a8533b11b86c7cd709c48176.dif

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

DavidSpickett added a comment. Landed as https://github.com/llvm/llvm-project/commit/1e210abf9925ad08fb7c79894b4ec5ef8f0ef173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136465/new/ https://reviews.llvm.org/D136465

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e210abf9925: [LLDB] Make remote-android local ports configurable (authored by mark2185, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] 1e210ab - [LLDB] Make remote-android local ports configurable

Author: Luka Markušić Date: 2022-10-26T08:14:22Z New Revision: 1e210abf9925ad08fb7c79894b4ec5ef8f0ef173 URL: https://github.com/llvm/llvm-project/commit/1e210abf9925ad08fb7c79894b4ec5ef8f0ef173 DIFF: https://github.com/llvm/llvm-project/commit/1e210abf9925ad08fb7c79894b4ec5ef8f0ef173.diff LOG:

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3884755 , @DavidSpickett wrote: >> Great! I'd just like to note that I do not have commit access, per the >> guide's instructions. > > What name/email address do you want on the commit? Luka Markušić (markusicl...@g

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

DavidSpickett added a comment. > Great! I'd just like to note that I do not have commit access, per the > guide's instructions. What name/email address do you want on the commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136465/new/ https://r