jasonmolenda added a comment. In D136719#3886254 <https://reviews.llvm.org/D136719#3886254>, @tschuett wrote:
> Looks great, but I would have expected `std::optional<std::string>` and a > `nullopt`. Yeah I'm fine with that, it does seems more natural. In this case we're returning the address of a half-dozen const strings in the text section, so there wasn't any lifetime worries or anything, I left it as a char* after thinking about it for a few seconds. I'll update to use a std::string, this is not a hot code path, a small object allocation doesn't matter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136719/new/ https://reviews.llvm.org/D136719 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
