rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.
Two other places you might need to update as well
================
Comment at: lldb/examples/python/crashlog.py:452
with open(path, 'r') as f:
buffer = f.read()
----------------
Do you need to specify encoding here too?
================
Comment at: lldb/examples/python/crashlog.py:647
def parse(self):
with open(self.path,'r') as f:
lines = f.read().splitlines()
----------------
(and here)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136798/new/
https://reviews.llvm.org/D136798
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
